Spring Boot for Apache Geode 1.0.0.M3 Released!

2018-09-21 Thread John Blum
It is my pleasure to announce [1] the release of *Spring Boot for Apache Geode* 1.0.0.M3. This release builds on the latest GA version of *Spring Boot*, 2.0.5.RELEASE, and adds extensive support for using *Spring Boot Actuator* [2] (specifically, providing HealthIndicators [3]) with Apache Geode,

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #1047 was SUCCESSFUL (with 2456 tests). Change made by Mark Paluch.

2018-09-21 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #1047 was successful. --- Scheduled with changes by Mark Paluch. 2458 tests in total. https://build.spring.io/bro

Re: [DISCUSS] test code style (particularly logging)

2018-09-21 Thread Kirk Lund
I would probably lean towards using System.out.println in a non-end-to-end test and using Logger in an end-to-end test that's already using our logging system. My only argument against using System.out.println in an end-to-end test is that it can easily get lost or incorrectly interleaved in the ou

Re: [DISCUSS] test code style (particularly logging)

2018-09-21 Thread Dale Emery
In general I agree. I’m an author of the PR that triggered this thread. That PR specifically prints new information to help diagnose an intermittent CI failure in a DistributedTest test, which we have been unable to reproduce outside of CI. Our working hypothesis is that an action initiated at

Re: Develop is broken

2018-09-21 Thread Kirk Lund
We killed the Gradle Daemon and pushed a fix for the geode-junit:checkPom error. Develop should be building cleanly again. On Fri, Sep 21, 2018 at 11:42 AM, Kirk Lund wrote: > Develop is broken due to geode-junit:checkPom because we excluded a bad > dependency. > > Now I'm trying to run checkPom

Develop is broken

2018-09-21 Thread Kirk Lund
Develop is broken due to geode-junit:checkPom because we excluded a bad dependency. Now I'm trying to run checkPom but this produces an error for (see below). How do I run checkPom locally? /Users/klund/dev/geode [515]$ ./gradlew geode-junit:checkPom Starting a Gradle Daemon, 1 incompatible Daemo

Re: [DISCUSS] test code style (particularly logging)

2018-09-21 Thread Jacob Barrett
Exactly what Kirk said! > On Sep 21, 2018, at 10:34 AM, Kirk Lund wrote: > > Most of these logWriter or logger usages are in larger end-to-end tests > that were written before we could using IDE debuggers on our tests. With a > debugger, I don't want to see more output from the test so I tend to

Re: [DISCUSS] test code style (particularly logging)

2018-09-21 Thread Kirk Lund
Most of these logWriter or logger usages are in larger end-to-end tests that were written before we could using IDE debuggers on our tests. With a debugger, I don't want to see more output from the test so I tend to delete all such System.out.printlns or LogWriter/Logger usage. My recommendation i