Re: Release branch for Apache Geode 1.8.0 has been cut

2018-11-14 Thread Nabarun Nag
I would also like to put in the fix for GEODE-6053. It's in the review phase and soon will be in the develop and the release branch. Regards Nabarun Nag > On Nov 14, 2018, at 10:28 AM, Jason Huynh wrote: > > I'd like to cherry pick the following two commits to release/1.8. > > >

Re: PowerMock unit test errors

2018-11-14 Thread Bruce Schuchardt
I don't think you necessarily need to redo your work Ryan.  I just think something has been left behind by the test.  It looks like a mock made its way into  the JMX "Server" in the log4j code. On 11/14/18 10:57 AM, Ryan McMahon wrote: I will write up a story to address the use of PowerMock

Re: PowerMock unit test errors

2018-11-14 Thread Ryan McMahon
I've created a Jira to track the elimination of PowerMock from these tests in particular, which will probably involve doing the major refactoring mentioned in item #4 in my previous email. https://issues.apache.org/jira/browse/GEODE-6052 On Wed, Nov 14, 2018 at 10:57 AM Ryan McMahon wrote: > I

Re: PowerMock unit test errors

2018-11-14 Thread Ryan McMahon
I will write up a story to address the use of PowerMock in these JMX tests in particular. I remember attempting to avoid PowerMock when writing this test, because I agree that it should be avoided. I just want to explain my thinking so that we can discuss what would have been a better approach.

Re: Release branch for Apache Geode 1.8.0 has been cut

2018-11-14 Thread Jason Huynh
I'd like to cherry pick the following two commits to release/1.8. https://github.com/apache/geode/commit/6d9e026feb584309dff269e593417082a71434fc https://github.com/apache/geode/commit/d22e83e167f261e933b79b2619367d2e1b788db6 Reason: There was a previous commit that modified the way

November 2018 Board Report Final Draft

2018-11-14 Thread Robert Houghton
Here is the final form our report for the quarter. If it passes muster, can someone commit it to the Apache repository for me? ## Description: > > Apache Geode provides a database-like consistency model, reliable >> transaction > > processing and a shared-nothing architecture to maintain very low

Re: PowerMock unit test errors

2018-11-14 Thread Bruce Schuchardt
I'm running into the same PowerMock problem that Kirk hit.  I can find only one test that uses PowerMock and invokes registerMBean - MBeanJMXAdapterTest.  This is a new test that was checked in mid-October. commit 76420dcd93e17f009aa73ca8188d135158358323 Author: Ryan McMahon Date:   Wed Oct