Re: [DISCUSS] Move or remove org.apache.geode.admin
+1 since it's been deprecated pre geode 1.0, and I have no idea what its purpose. On Tue, Apr 2, 2019 at 5:20 PM Jacob Barrett wrote: > > > > On Apr 2, 2019, at 5:04 PM, Dan Smith wrote: > > > > I think the best course of action is probably to remove it entirely. > > However, this does bring up a couple of questions: > > > > 1) Is it ok in general to remove deprecated API in a non X.0 release (eg > > geode 1.10 instead of geode 2.0)? > > I think a deprecated API is no longer API after a major version increment. > The deprecated symbols can be removed anytime after the major release with > merely a notice in the release notes. I think its unrealistic to expect all > deprecated symbols be removed for the x.0 release. > > > 2) How about in this case, when this feature has been deprecated for so > > long, and may or may not work? > > Given that this API was effectively deprecated in version 0 of Geode and > was never part of the release API in 1 it is fair game now. Time should not > be a factor, just major version number. > > -Jake > > -- Cheers Jinmei
Re: Need edit access to cwiki
I believe I used the Apache LDAP account, it's the same username anyway. I still keep getting this error: [image: Screen Shot 2019-04-02 at 5.52.14 PM.png] On Tue, Apr 2, 2019 at 3:12 PM Mark Bretl wrote: > Hi Jinmei, > > I have viewed your permissions and they look correct. When I click on edit > page, it was successful in loading the editor. > > Did you login with your Apache LDAP account? It looks like INFRA has > updated that fairly recently. > > --Mark > > On Tue, Apr 2, 2019 at 2:58 PM Jinmei Liao wrote: > > > Username is jinmeiliao. I used to have edit access, but now Confluence > > throws "The editor didn't load this time" error when trying to edit a > page > > > > -- > > Cheers > > > > Jinmei > > > -- Cheers Jinmei
Re: [DISCUSS] Move or remove org.apache.geode.admin
> On Apr 2, 2019, at 5:04 PM, Dan Smith wrote: > > I think the best course of action is probably to remove it entirely. > However, this does bring up a couple of questions: > > 1) Is it ok in general to remove deprecated API in a non X.0 release (eg > geode 1.10 instead of geode 2.0)? I think a deprecated API is no longer API after a major version increment. The deprecated symbols can be removed anytime after the major release with merely a notice in the release notes. I think its unrealistic to expect all deprecated symbols be removed for the x.0 release. > 2) How about in this case, when this feature has been deprecated for so > long, and may or may not work? Given that this API was effectively deprecated in version 0 of Geode and was never part of the release API in 1 it is fair game now. Time should not be a factor, just major version number. -Jake
Re: [DISCUSS] Move or remove org.apache.geode.admin
+1 on removing the JMXManager stuff for Geode 2.0 release. But this "hidden" feature, what is that? Is this something that we would like to support or is this something that would be replaced with our existing efforts in the ConfigurationService and Metrics area. On 4/2/19 17:04, Dan Smith wrote: Hi devs, The org.apache.geode.admin package has been deprecated for about 7 years [1]. I'd like to remove it, or at least move it to a separate module. I actually started some work to move it to a separate module [2]. However in the course of this process, I've found that this module has extremely little test coverage, so I'm not confident in the move. For example, it has a whole JMX manager feature (different than our current JMX manager) which does not appear to have any tests. This JMX manager feature won't work as shipped unless you find and add some mx4j jars to your classpath. I think the best course of action is probably to remove it entirely. However, this does bring up a couple of questions: 1) Is it ok in general to remove deprecated API in a non X.0 release (eg geode 1.10 instead of geode 2.0)? 2) How about in this case, when this feature has been deprecated for so long, and may or may not work? -Dan [1] https://geode.apache.org/releases/latest/javadoc/org/apache/geode/admin/package-summary.html [2] Draft PR for moving the org.apache.geode.admin to a separate module - https://github.com/apache/geode/pull/3392
[DISCUSS] Move or remove org.apache.geode.admin
Hi devs, The org.apache.geode.admin package has been deprecated for about 7 years [1]. I'd like to remove it, or at least move it to a separate module. I actually started some work to move it to a separate module [2]. However in the course of this process, I've found that this module has extremely little test coverage, so I'm not confident in the move. For example, it has a whole JMX manager feature (different than our current JMX manager) which does not appear to have any tests. This JMX manager feature won't work as shipped unless you find and add some mx4j jars to your classpath. I think the best course of action is probably to remove it entirely. However, this does bring up a couple of questions: 1) Is it ok in general to remove deprecated API in a non X.0 release (eg geode 1.10 instead of geode 2.0)? 2) How about in this case, when this feature has been deprecated for so long, and may or may not work? -Dan [1] https://geode.apache.org/releases/latest/javadoc/org/apache/geode/admin/package-summary.html [2] Draft PR for moving the org.apache.geode.admin to a separate module - https://github.com/apache/geode/pull/3392
Re: Need edit access to cwiki
Hi Jinmei, I have viewed your permissions and they look correct. When I click on edit page, it was successful in loading the editor. Did you login with your Apache LDAP account? It looks like INFRA has updated that fairly recently. --Mark On Tue, Apr 2, 2019 at 2:58 PM Jinmei Liao wrote: > Username is jinmeiliao. I used to have edit access, but now Confluence > throws "The editor didn't load this time" error when trying to edit a page > > -- > Cheers > > Jinmei >
Need edit access to cwiki
Username is jinmeiliao. I used to have edit access, but now Confluence throws "The editor didn't load this time" error when trying to edit a page -- Cheers Jinmei
