Re: "Output path is not specified for module" (IntelliJ)

2019-06-06 Thread Eric Shu
I worked around this issue by choosing Inherit project compile output path. On Thu, Jun 6, 2019 at 3:16 PM Jens Deppe wrote: > I have only experienced this when I switch to building with IntelliJ (it is > also dependent on what Intellij deems necessary to build). Building with > gradle has

Re: "Output path is not specified for module" (IntelliJ)

2019-06-06 Thread Jens Deppe
I have only experienced this when I switch to building with IntelliJ (it is also dependent on what Intellij deems necessary to build). Building with gradle has never produced this. My setup is to build with gradle but run tests with IntelliJ. I've never had to do any kind of re-import for this.

Re: "Output path is not specified for module" (IntelliJ)

2019-06-06 Thread Ryan McMahon
Fair warning - some have wiped their .idea file and it works temporarily, but inevitably will return. I would recommend the setting changes as described above if it recurs. Ryan On Thu, Jun 6, 2019 at 12:04 PM Peter Tran wrote: > Awesome - a wipe of my .idea file worked. Thank you! > > On

Re: "Output path is not specified for module" (IntelliJ)

2019-06-06 Thread Peter Tran
Awesome - a wipe of my .idea file worked. Thank you! On Thu, Jun 6, 2019 at 2:54 PM Jacob Barrett wrote: > This seems to happen frequently with 2019.1. The easiest way I found to > fix this was to start over with the IJ project. Some have had luck > switching between the gradle builder and the

Re: "Output path is not specified for module" (IntelliJ)

2019-06-06 Thread Ryan McMahon
I have seen this issue and this seems to be a pretty reliable solution: 1. Upgrade to IntelliJ 2019.1.3 (the latest and greatest) if you haven't already. 2. Reimport the Geode project as described in the "Setting up IntelliJ" section of the BUILDING.MD 3. Set your "Build and run using" setting in

Re: "Output path is not specified for module" (IntelliJ)

2019-06-06 Thread Jacob Barrett
This seems to happen frequently with 2019.1. The easiest way I found to fix this was to start over with the IJ project. Some have had luck switching between the gradle builder and the IJ builder in the cradle configuration panel. > On Jun 6, 2019, at 11:47 AM, Peter Tran wrote: > > Hello, >

"Output path is not specified for module" (IntelliJ)

2019-06-06 Thread Peter Tran
Hello, Has anyone had an issue in IntelliJ running tests with the error: "Cannot start compilation: the output path is not specified for module" I setup intelliJ using the BUILDING.md instructions and haven't come across this problem. I haven't updated intelliJ since the last time I ran tests

Re: [DISCUSS] require reviews before merging a PR

2019-06-06 Thread Joris Melchior
Thanks Patrick. That's what we're doing currently so we'll continue to do so :). On Thu, Jun 6, 2019 at 12:40 PM Patrick Rhomberg wrote: > > > > I'm not sure it's possible to do this with the "reviewers" field - if > > someone can figure out how to do this with the github IU, we can at least >

Please review PR #3650

2019-06-06 Thread Kirk Lund
Reminder: Please review PR #3650 https://github.com/apache/geode/pull/3650. Cleanup commits are separated from the fix commits to help facilitate review. GEODE-6183: Fix isAttachAPIFound and launcher tests Thanks, Kirk

Re: [DISCUSS] require reviews before merging a PR

2019-06-06 Thread Patrick Rhomberg
> > I'm not sure it's possible to do this with the "reviewers" field - if > someone can figure out how to do this with the github IU, we can at least > try filing an ticket with apache infrastructure. > According to their docs [1], "collaborator with write access" is the GitHub required criteria

Re: [DISCUSS] require reviews before merging a PR

2019-06-06 Thread Dan Smith
> > Would it be possible to allow people who do not have committer status to > request reviewers on a pull request. I'm not sure it's possible to do this with the "reviewers" field - if someone can figure out how to do this with the github IU, we can at least try filing an ticket with apache

Re: [DISCUSS] require reviews before merging a PR

2019-06-06 Thread Joris Melchior
Would it be possible to allow people who do not have committer status to request reviewers on a pull request. In some cases we may know who should take a look at it and in that case making it official by adding these people to the pull request would be good IMO. On Thu, Jun 6, 2019 at 10:26 AM

Re: [DISCUSS] require reviews before merging a PR

2019-06-06 Thread Jens Deppe
As reviewers we should also feel empowered to request additional reviewers on a PR (perhaps beyond whomever the original submitter may already have requested). I think that, sometimes the complexity of a change prevents someone from commenting on just a portion of the change if they do not feel