+1, if the LongAdders have already added and the additional memory usage
has already been dealt with, then adding the accessors does not really
make a difference anymore.
On 6/7/19 13:47, Jacob Barrett wrote:
I like this!
I’d go ahead and change all the usage of the int methods to the long me
+1 - this sounds like a good change to me.
-Dan
On Fri, Jun 7, 2019 at 1:47 PM Jacob Barrett wrote:
> I like this!
>
> I’d go ahead and change all the usage of the int methods to the long
> methods. I’d deprecate the int methods to make it very clear.
>
> If some consumer is using the int metho
I like this!
I’d go ahead and change all the usage of the int methods to the long methods.
I’d deprecate the int methods to make it very clear.
If some consumer is using the int methods they will still work with the same
rollover issues but perhaps with the deprecated warning they will update
We have had a couple of tickets that have problems with 32-bit counters
changing too fast and causing them to be hard to understand when they wrap
around (see GEODE-6425 and GEODE-6834). We have also had problems with some
stats being broken because they were changing the 32-bit one when they
shoul
Thanks for investigating this. Looking forward to hearing the results of your
testing. Note that when we create an oplog file we allocate all the bytes
(including writing to each disk page) to avoid corruption if the disk becomes
full while writing records.
Anthony
> On Jun 7, 2019, at 4:26
Hi,
An update about this issue. I think the problem is in the PersistentOplogSet
class, in the following method:
/**
* Returns the next available DirectoryHolder which has space. If no dir has
space then it will
* return one anyway if compaction is enabled.
*
* @param minAvailable
