Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-19 Thread Owen Nichols
There appears to be consensus that this is a critical fix. PR #3949 has passed all PR checks and has been brought into release/1.10.0 as the critical fix for GEODE-3870

Re: [DISCUSS] what region types to support in the new management rest api

2019-08-19 Thread Darrel Schneider
Keep in mind that the context of the regions in question is the cluster. So these regions would be created on servers. So, for example, does anyone see a need to create PROXY regions on the server? Even if we did not support them on the server, they would still be supported on clients. On Mon,

Re: Hardcoded list of jars for Jetty tests

2019-08-19 Thread Ryan McMahon
Hi Kirk, I’m curious if you’ve found an alternative so we don’t have to hard code this list? We actually recently ran into an issue where this test list was updated due to missing dependencies, but our documentation was not updated and therefore it was missing the new dependencies. I currently

[DISCUSS] what region types to support in the new management rest api

2019-08-19 Thread Jinmei Liao
Region type (in another word Region shortcut) defines a set of attributes for a region. These are the list of region types we have: LOCAL, LOCAL_PERSISTENT, LOCAL_HEAP_LRU, LOCAL_OVERFLOW, LOCAL_PERSISTENT_OVERFLOW, PARTITION, PARTITION_REDUNDANT, PARTITION_PERSISTENT,

Re: Hardcoded list of jars for Jetty tests

2019-08-19 Thread Kirk Lund
PS: it's in TomcatInstall... private static final String[] tomcatRequiredJars = {"antlr", "commons-io", "commons-lang", "commons-validator", "fastutil", "geode-common", "geode-core", "geode-log4j", "geode-management", "javax.transaction-api", "jgroups", "log4j-api",

Hardcoded list of jars for Jetty tests

2019-08-19 Thread Kirk Lund
Can anyone point me at the hardcoded list of jars for the Jetty and Tomcat tests? I can't seem to find it this time despite grepping for several things that should be in the list. Maybe it was changed since I last had to look for it... I found the one in dunit ProcessManager:

Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-19 Thread Bruce Schuchardt
Ah, I see - I need to create a PR and tell it both of the branches.  The link from "git push" is for merging to develop. I'll give it another try. On 8/19/19 1:53 PM, Owen Nichols wrote: PR 3947 appears to be against develop. Looking for a PR against release/1.10.0... On Aug 19, 2019, at

Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-19 Thread Owen Nichols
PR 3947 appears to be against develop. Looking for a PR against release/1.10.0... > On Aug 19, 2019, at 1:50 PM, Bruce Schuchardt wrote: > > Unfortunately the code I'm working with went through some refactoring after > the 1.10.0 branch was cut. A PR based on release/1.10.0 membership

Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-19 Thread Bruce Schuchardt
Unfortunately the code I'm working with went through some refactoring after the 1.10.0 branch was cut.  A PR based on release/1.10.0 membership changes can't go through a PR pipeline because it won't compile once the changes are merged to develop.

Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-19 Thread Owen Nichols
Hi Bruce, unfortunately 8e9b04470264983d0aa1c7900f6e9be2374549d9 does not cherry-pick cleanly into release/1.10.0. Can you please open a PR against release/1.10.0? -Owen > On Aug 19, 2019, at 9:16 AM, Kirk Lund wrote: > > +1 > > On Mon, Aug 19, 2019 at 8:29 AM Alexander Murmann > wrote: >

Re: [DISCUSS] Release Geode 1.9.1 with logging improvements

2019-08-19 Thread Dave Barnes
I'll update the docs: - Geode user guide - Geode API docs - Native client user guide - Native client API docs - Apache Geode website On Mon, Aug 19, 2019 at 9:26 AM Owen Nichols wrote: > I will pair with you on a 1.9.1 release. > > > On Aug 19, 2019, at 9:23 AM, Kirk Lund wrote: > > > > I

Re: [DISCUSS] Release Geode 1.9.1 with logging improvements

2019-08-19 Thread Owen Nichols
I will pair with you on a 1.9.1 release. > On Aug 19, 2019, at 9:23 AM, Kirk Lund wrote: > > I volunteer to pair with a more experienced release manager for 1.9.1. > Anyone willing to mentor me on this? > > On Sun, Aug 18, 2019 at 7:53 AM Anthony Baker wrote: > >> Yep. Get a release manager,

Re: [DISCUSS] Release Geode 1.9.1 with logging improvements

2019-08-19 Thread Kirk Lund
I volunteer to pair with a more experienced release manager for 1.9.1. Anyone willing to mentor me on this? On Sun, Aug 18, 2019 at 7:53 AM Anthony Baker wrote: > Yep. Get a release manager, identify and cherry pick all the changes, then > do the release. > > Anthony > > > On Aug 16, 2019, at

Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-19 Thread Kirk Lund
+1 On Mon, Aug 19, 2019 at 8:29 AM Alexander Murmann wrote: > +1 > > it's a regression in 1.10 and a serious problem. > > On Mon, Aug 19, 2019 at 7:38 AM Bruce Schuchardt > wrote: > > > It sounds like Udo is okay with this now. Any other concerns? > > > > On 8/17/19 2:07 AM, Owen Nichols

Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-19 Thread Alexander Murmann
+1 it's a regression in 1.10 and a serious problem. On Mon, Aug 19, 2019 at 7:38 AM Bruce Schuchardt wrote: > It sounds like Udo is okay with this now. Any other concerns? > > On 8/17/19 2:07 AM, Owen Nichols wrote: > > On Aug 15, 2019, at 2:09 PM, Bruce Schuchardt > wrote: > > > > This is a

Re: Proposal to Include GEODE-7079 in 1.10.0

2019-08-19 Thread Juan José Ramos
Thanks Owen!!. On Mon, Aug 19, 2019 at 3:44 PM Owen Nichols wrote: > There appears to be consensus that this is a critical fix. > > The following commit has been brought into release/1.10.0 < > https://github.com/apache/geode/tree/release/1.10.0> as the critical fix > for GEODE-7079

Re: Proposal to Include GEODE-7079 in 1.10.0

2019-08-19 Thread Owen Nichols
There appears to be consensus that this is a critical fix. The following commit has been brought into release/1.10.0 as the critical fix for GEODE-7079 : git cherry-pick -x

Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-19 Thread Bruce Schuchardt
It sounds like Udo is okay with this now.  Any other concerns? On 8/17/19 2:07 AM, Owen Nichols wrote: On Aug 15, 2019, at 2:09 PM, Bruce Schuchardt wrote: This is a fix for a problem where a member that has lost quorum does not detect it and does not shut down. The fix is small and has

Re: Proposal to Include GEODE-7079 in 1.10.0

2019-08-19 Thread Juan José Ramos
Hello team, Just following up on my proposal to include GEODE-7079 in release 1.10.0, I think there's enough consensus at this point (+1: 7, +0: 1), can we cherry pick commit *6f4bbbd [1]* into the release branch?. Best regards. [1]: