I cannot login now for some reason. I need your vote to turn on the
permissions.
Regards
Xiaojian Zhou
The Template Checklist is a great reference for the committer who builds
and submits the PR, but I find it of little value as a posted comment for
reviewers of the PR - just takes up a lot of space. As a frequent reviewer,
I like to see:
- A clear and concise title beginning with the ticket number
back to Juan's original point: (I think this was anyway)
+1 to details and more details on the commit message and if removing
pedantic guidelines and just using tooling to word wrap will encourage
better communication via better commit messages
On Tue, Oct 8, 2019 at 8:33 AM Owen Nichols wrote:
Apache values people over process. So I am in favor of removing any “rules”
regarding commit messages (except for: must put a colon after the GEODE ticket
number!)
Guidelines (not rules) can be helpful. I would like developers reading our
commit message guidelines
Hello Alberto,
It might help to add the reminder to the PR template but, honestly, I don't
think many people is actually paying much attention to that... in fact I
recall another email thread from some time ago discussing getting rid of
the template altogether :-/.
Cheers.
On Tue, Oct 8, 2019 at
Yes, the 50 chars cap rule is *only for the subject of the commit message*.
The actual body of the commit message should contain all the details, with
a maximum of 72 characters per line.
Example:
*GEODE-XXX: 50 chars or less summary - [Commit Message Subject]Blank
lineMore details about the
Isn't this only regarding the "headline" commit message, but there can be
sub-bulletted text further describing the commit in greater detail...?
This is how I have always interpreted this business...
EB
On Tue, Oct 8, 2019 at 3:58 AM Alberto Bustamante Reyes
wrote:
> I think its a good idea to
I think its a good idea to have an automatic mechanism to reject commits that
exceed a given limit.
In the previous project I was assigned we used Gerrit instead of Github, and we
had an automatic check to vote -1 if your commit message exceeded the limit.
Anyway, while this is decided, a quick
Hello Owen,
Yes, I fully agree with you. And just to be clear, I wasn't trying to
discourage descriptive commit messages, on the contrary, we certainly must
encourage them at all cost!!. It was decided that we should, however, try
to keep consistency across all commits and make the subject brief,
I don’t care how long it is, but knowing that many tools show only the
first bit, it’s helpful if the message is phrased with the most important
words near the beginning.
I’d much prefer to encourage rather than discourage descriptive commit
messages. Even better if all commit messages mentioned
Hello devs,
I've notice that, lately, not everybody is following the guidelines we have
highlighted in our Wiki under *Commit Message Format [1]*, specially the
first requirement: *GEODE-nn: Capitalized, 50 chars or less summary. *As an
example, out of the last 33 commits in develop, only 11
11 matches
Mail list logo
