Re: PR process and etiquette

So far I would like to thank everyone for their thoughts and input. @Dave, I would love to find a solution to the partial sign-off. I’ve been experimenting with the “Projects” setting. I wonder if we cannot have a “Documentation Check” project, that is added to every PR as a default project.

Re: PR process and etiquette

Here's a common use case that we should address: A single PR may require two reviews, one for code and another for docs, before it can be said to be fully reviewed and ready to merge. Points to consider: - Many PRs, especially those introducing new features or user-settable properties,

Re: PR process and etiquette

How about we make this a recommendation rather than a rule? I'd like to also recommend that contributors consider prefixing the PR title with "DRAFT: " while it is in draft. This just makes it easier to see at a glance that it's a draft. When I change the PR to "ready for review" I edit the title

Full diffs in Jira comments

Anyone else notice that we're getting full diffs as comments to Jira tickets again?

Re: PR process and etiquette

Hi Owen - I wasn't aware that non-committers can't add reviewers to their PRs but I don't see how using DRAFT mode helps with that. The idea that I can't request a review until the commit checks all pass seems absurd to me. On 10/28/20, 9:15 AM, "Owen Nichols" wrote: Hey Bruce, please

Re: PR process and etiquette

For the narrow goal of making it easier for non-committers to get reviewers for their PRs, we could also consider defining a "reviewers wanted" label. However it might not be very obvious to new committers that they need to click the gear to look for that label, unless we also update the PR

Re: PR process and etiquette

I think exploring these additions to PR reviews would be pretty helpful. It’s worth spending the extra time to get a PR right before merging. Anthony > On Oct 28, 2020, at 8:40 AM, Robert Houghton wrote: > > There are some pieces of Apache infrastructure we can control without needing >

Re: PR process and etiquette

Hey Bruce, please consider that non-committers are not permitted to add reviewers themselves, so a consistent convention to indicate when a PR has moved from work-in-progress to ready-for-review will help alert the community when to assign reviewers. Currently, I see countless creative

Re: PR process and etiquette

There are some pieces of Apache infrastructure we can control without needing tickets: Specifically required_pull_request_reviews: dismiss_stale_reviews: true require_code_owner_reviews: true I think these specific controls could go a long way towards helping keep our PR quality

Re: How to add a new REST end point in Cluster Management Service

Hi Jinmei- I put feedback and other comments in the Wiki page. Regards, John From: Jinmei Liao Sent: Monday, October 26, 2020 10:53 AM To: dev@geode.apache.org Subject: How to add a new REST end point in Cluster Management Service Hi, Geode developers, I

Re: PR process and etiquette

-1 While I often use the Draft option I don't see why we want to add even more rules about how we use github. I think it's enough to put in a PR and then add reviewers when you're ready for comments. Getting the stink-eye for putting up a non-Draft PR is just going to make it more difficult

Re: PR process and etiquette

Oops, sorry for the confusion! I’ve been working through Mario’s PRs a lot lately. From: Alberto Gomez Date: Wednesday, October 28, 2020 at 7:10 AM To: "dev@geode.apache.org" , Blake Bender Subject: Re: PR process and etiquette +1 to draft PRs. By the way @Blake

Re: PR process and etiquette

+1 to draft PRs. By the way @Blake Bender, it's me the one having the draft PR for GEODE-8318. Alberto G. From: Blake Bender Sent: Wednesday, October 28, 2020 2:28 PM To: dev@geode.apache.org Subject: Re: PR process and etiquette +1

Re: PR process and etiquette

+1 for draft PRs. Native has been using these for a few months now, and they're quite effective. Right now, for example, we have 6 PRs up, 3 of which are draft. They also turn out to be a convenient way to share work, in certain circumstances. Mario, for instance, has a draft up for

Re: PR process and etiquette

Great information Darrel. Thank you for sharing that. --Udo From: Darrel Schneider Date: Wednesday, October 28, 2020 at 3:32 PM To: dev@geode.apache.org Subject: Re: PR process and etiquette +1 to your idea of using "draft" mode until things are green. Something to be aware of is that if your