Geode - store and query JSON documents

2020-11-20 Thread ankit Soni
Hello team, I am *evaluating usage of Geode (1.12) with storing JSON documents and querying the same*. I am able to store the json records successfully in geode but seeking guidance on how to query them. More details on code and sample json is, *Sample client-code* import

Re: Committing broken javadocs to develop

2020-11-20 Thread Jacob Barrett
I think we can make javadoc warnings an error in Gradle. I have fixed several modules to treat java warnings as errors already. Perhaps we can just extend that effort. > On Nov 20, 2020, at 10:39 AM, Kirk Lund wrote: > > Please remember to: > * fix all broken javadocs before submitting a PR >

Re: [PROPOSAL] Change the default value of conserve-sockets to false

2020-11-20 Thread Donal Evans
Regarding behaviour during RollingUpgrade; I created a draft PR with this change to test the feasibility and see what problems, if any, would be caused by tests assuming the default setting to be true. After fixing two DUnit tests that were not explicitly setting the value of conserve-sockets

Re: [PROPOSAL] Change the default value of conserve-sockets to false

2020-11-20 Thread Udo Kohlmeyer
@Anthony I cannot think of a single reason, why the server should not start up, even in a rolling upgrade. This setting should not have an effect on the cluster (other than potentially positive). Also, if the Geode were to enforce this setting across the cluster, then we have seriously broken

Re: [DISCUSS] Adding CODEOWNERS to Apache Geode

2020-11-20 Thread Xiaojian Zhou
+1 I saw the template of splitting the geode code. Can someone nominate a few codeowners in the file as examples? On 11/20/20, 7:32 AM, "Alexander Murmann" wrote: +1 I agree with Owen's point that this will improve the experience for new contributors. It also helps people new to

Committing broken javadocs to develop

2020-11-20 Thread Kirk Lund
Please remember to: * fix all broken javadocs before submitting a PR * always review javadocs when reviewing PRs Thanks, Kirk

Re: [PROPOSAL] Change the default value of conserve-sockets to false

2020-11-20 Thread Xiaojian Zhou
1) Conserve-socket will only impact p2p connection. If set to false, that mean the p2p connections between 2 servers can be created on request, as many as needed. 2) currently the default setting is true (I don't remember when did we change it from false to true) 3) For rollingUpgrade,

Re: [VOTE] Apache Geode 1.13.1.RC2

2020-11-20 Thread Xiaojian Zhou
+1 On 11/17/20, 12:52 PM, "Dave Barnes" wrote: +1 Docs review - Built user guides for geode and geode-native using the provided Docker scripts. - Opened the pre-built Geode javadocs in the binary distro. Everything worked and looked as it should. NOTE:

Re: [PROPOSAL] Change the default value of conserve-sockets to false

2020-11-20 Thread Anthony Baker
Question: how would this work with a rolling upgrade? If the user did not set this property and we changed the default I believe that we would prevent the upgraded member from rejoining the cluster. Of course the user could explicitly set this property as you point out. Anthony > On Nov

Re: [PROPOSAL] Change the default value of conserve-sockets to false

2020-11-20 Thread Donal Evans
While I agree that the potential impact of having the setting changed out from a user may be high, the cost of addressing that change is very small. All users have to do is explicitly set the conserve-sockets value to true if they were previously using the default and they will be back to where

Re: [DISCUSS] Adding CODEOWNERS to Apache Geode

2020-11-20 Thread Alexander Murmann
+1 I agree with Owen's point that this will improve the experience for new contributors. It also helps people new to the community to have confidence that they got the type of review they need to feel confident to merge. I might get to reviews that are both from great committers who can review

Re: needs permission to push code to geode example repo

2020-11-20 Thread aashish choudhary
Opened a PR https://github.com/apache/geode-examples/pull/104. Please review With Best Regards, Ashish On Fri, Nov 20, 2020 at 11:24 AM aashish choudhary < aashish.choudha...@gmail.com> wrote: > Thanks a lot! > > With best regards, > Ashish > > On Fri, Nov 20, 2020, 10:42 AM Owen Nichols