Re: Commit message review opt-in

2022-03-08 Thread Kirk Lund
So, we just submit edits to COMMITWATCHERS going forward?

Thanks Owen!

On Tue, Mar 8, 2022 at 11:07 AM Owen Nichols  wrote:

> To make opt-in and opt-out less noisy for the dev list, the subscription
> mechanism has been moved to COMMITWATCHERS file under source control to
> provide self-service (like with CODEOWNERS or CODEWATCHERS).
>
> From: Jacob Barrett 
> Date: Friday, March 4, 2022 at 1:20 PM
> To:
> Subject: Re: Commit message review opt-in
> Can we please agree to send requests for inclusion directly to
> onich...@vmware.com rather than back to this
> thread.
>
> On Mar 4, 2022, at 1:09 PM, Owen Nichols  onich...@vmware.com>> wrote:
>
> Thanks Udo, I have added kohlmu-pivotal as requested, for non-draft PRs
> only.
>
> From: Udo Kohlmeyer mailto:u...@vmware.com>>
> Date: Friday, March 4, 2022 at 1:03 PM
> To: dev@geode.apache.org <
> dev@geode.apache.org>
> Subject: Re: Commit message review opt-in
> I’ll opt-in please.
>
> --Udo
>
> From: Owen Nichols mailto:onich...@vmware.com>>
> Date: Saturday, February 26, 2022 at 10:44 AM
> To: geode mailto:dev@geode.apache.org>>
> Subject: Commit message review opt-in
> If you received an automated-looking PR review comment from
> onichols-pivotal in the past few weeks without consent, I apologize and
> have withdrawn it.
>
> If you would like to continue receiving these automated reviews, you may
> opt-in by emailing me your github username (also let me know if you want
> your Draft PRs included or not).
>
> Geode’s guidelines for commit messages should be interpreted as
> suggestions, not rules.  All Geode committers are welcomed with "we like to
> work on trust, not unnecessary restrictions".  I hope this change to opt-in
> better reflects that spirit.
>


Re: Commit message review opt-in

2022-03-08 Thread Owen Nichols
To make opt-in and opt-out less noisy for the dev list, the subscription 
mechanism has been moved to COMMITWATCHERS file under source control to provide 
self-service (like with CODEOWNERS or CODEWATCHERS).

From: Jacob Barrett 
Date: Friday, March 4, 2022 at 1:20 PM
To:
Subject: Re: Commit message review opt-in
Can we please agree to send requests for inclusion directly to 
onich...@vmware.com rather than back to this thread.

On Mar 4, 2022, at 1:09 PM, Owen Nichols 
mailto:onich...@vmware.com>> wrote:

Thanks Udo, I have added kohlmu-pivotal as requested, for non-draft PRs only.

From: Udo Kohlmeyer mailto:u...@vmware.com>>
Date: Friday, March 4, 2022 at 1:03 PM
To: dev@geode.apache.org 
mailto:dev@geode.apache.org>>
Subject: Re: Commit message review opt-in
I’ll opt-in please.

--Udo

From: Owen Nichols mailto:onich...@vmware.com>>
Date: Saturday, February 26, 2022 at 10:44 AM
To: geode mailto:dev@geode.apache.org>>
Subject: Commit message review opt-in
If you received an automated-looking PR review comment from onichols-pivotal in 
the past few weeks without consent, I apologize and have withdrawn it.

If you would like to continue receiving these automated reviews, you may opt-in 
by emailing me your github username (also let me know if you want your Draft 
PRs included or not).

Geode’s guidelines for commit messages should be interpreted as suggestions, 
not rules.  All Geode committers are welcomed with "we like to work on trust, 
not unnecessary restrictions".  I hope this change to opt-in better reflects 
that spirit.