Consensus on this thread is to move ahead with removing CODEOWNERS requirement from PR review.
Thanks, Anthony > On Jun 29, 2022, at 4:11 PM, Alexander Murmann <amurm...@vmware.com.INVALID> > wrote: > > ⚠ External Email > > +1 to removing CODEOWNERS. It was a good idea, but isn’t working well, in > part due to the way GitHub doesn’t provide enough information to determine > who is actually needed for review. > > From: Anthony Baker <bak...@vmware.com.INVALID> > Date: Wednesday, June 29, 2022 at 9:34 AM > To: dev@geode.apache.org <dev@geode.apache.org> > Subject: CODEOWNERS? (was Re: Pending PR reviews) > ⚠ External Email > > I realize that this is a thread hijack, but hopefully a useful one. I’ve seen > several requests for timely reviews in recent months. I think that the > CODEOWNERS goals were important and laudable—directing review requests to > those most suited to provide oversight—but the implementation has been > problematic. The size, complexity, and interconnectedness of the code base > meant that many pull requests tagged not just one expert but just about EVERY > expert in the community. This is rather inefficient, to say the least. > > I propose that we revert CODEOWNERS and return to the review-then-commit > model requiring at least one +1 vote from a committer. I see Owen has already > created a PR [1] for this change. > > Thoughts? > > Anthony > > [1] > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7820&data=05%7C01%7Cbakera%40vmware.com%7C79811d072fc74726126008da5a24ab05%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637921410800473067%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=WCbjKRcWfv%2B1iBgkg60xaE1dkBJz4q2RUm36aTBupVE%3D&reserved=0 > > >> On Jun 28, 2022, at 5:43 AM, Mario Ivanac <mario.iva...@est.tech> wrote: >> >> ⚠ External Email >> >> Hi, >> >> The following PRs: >> >> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7323&data=05%7C01%7Cbakera%40vmware.com%7C79811d072fc74726126008da5a24ab05%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637921410800473067%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=eWy%2BcIeCFPIKrmtf9ivd02HjsPiArqyo9D0UnYfwBHk%3D&reserved=0 >> >> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7749&data=05%7C01%7Cbakera%40vmware.com%7C79811d072fc74726126008da5a24ab05%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637921410800473067%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=9Xhng%2F8o1cRW%2BOJ9g0UeL9Tshjh4B0yVXlRmxIV0wxk%3D&reserved=0 >> >> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7664&data=05%7C01%7Cbakera%40vmware.com%7C79811d072fc74726126008da5a24ab05%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637921410800473067%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=2UjXX1hos4K0nK2D7tqg%2Flr1mBwMtGVZcvKj9QTAlEw%3D&reserved=0 >> >> are waiting for review for some time. >> >> >> Could code owners review these PRs? >> >> Thanks, >> Mario >> >> ________________________________ >> >> ⚠ External Email: This email originated from outside of the organization. Do >> not click links or open attachments unless you recognize the sender.
