Re: Buildbot build failing for a long time

[Mark Bretl]

I am not familiar with it and would be in favor to turn it off/delete it
for now.

--Mark

On Mon, Jan 23, 2023 at 11:57 AM Gavin McDonald 
wrote:

>
>
> On 2023/01/23 14:59:56 Sai Boorlagadda wrote:
> > Thanks Gavin,
> >
> > This nightly build has been failing for quite a while. I will see
> > whats going on.
> >
> > Devs, Do we know about this nightly build? Any info on the setup and how
> it
> > is configured?
>
> Your config file lives at:-
>
> https://github.com/apache/infrastructure-bb2/blob/master/geode.py
>
> any changes to it should go live immediately.
>
> I placed the file there as it was transitioned from the old Buildbot
> server to the new.
>
> You can either try and fix it, or delete the file which will remove it
> from the Buildbot config.
>
> Happy to help in any way I can if you feel you would like it fixed.
>
> Gav...
>
> >
> > Sai
> >
> > On Mon, 23 Jan 2023 at 00:58, Gavin McDonald 
> wrote:
> >
> > > Hi All,
> > >
> > > https://ci2.apache.org/#/builders/72
> > >
> > > Has been failing for a long time. can someone investigate please, if
> > > necessary open an INFRA ticket if something is required our end.
> > >
> > > Thanks
> > >
> > > --
> > >
> > > *Gavin McDonald*
> > > Systems Administrator
> > > ASF Infrastructure Team
> > >
> >
>

Re: Bad Practice: Static constant values set by system properties

[Mark Bretl]

Thank you for the effort Kirk and Sai!

--Mark

On Sun, Jan 22, 2023 at 7:16 AM Kirk Lund  wrote:

> Sai and I worked together yesterday and fixed almost all of the failing
> unit tests in the new build we're trying to set up. I think we have one
> failure remaining. Most of the failures we fixed turned out to be caused by
> new code that was committed to Geode in 2022 that causes values in static
> constants that are set by system properties breaking later unit tests that
> will only pass if the constant has the default value.
>
> I want to point out that using system properties to set the values in a
> static constant is definitely an anti-pattern or bad practice that should
> be avoided going forward. It pollutes the JVM for later unit tests and
> cannot be unset because constants are defined as final and static.
>
> In the coming weeks, I plan to update the Apache Geode wiki to spell out
> the anti-pattern bad practices that we need to avoid going forward and this
> will definitely be one of them.
>
> Thanks,
> Kirk
>