[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

2017-08-15 Thread DivineEnder
Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133256792 --- Diff: geode-assembly/src/test/java/org/apache/geode/session/tests/ContainerInstall.java --- @@ -18,6 +18,7 @@ import java.io.FileInputStream

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

2017-08-15 Thread DivineEnder
Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133268501 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java --- @@ -34,7 +34,6 @@ import

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

2017-08-14 Thread DivineEnder
Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133010884 --- Diff: geode-assembly/src/test/java/org/apache/geode/session/tests/ServerContainer.java --- @@ -134,6 +134,7 @@ public ServerContainer

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

2017-08-14 Thread DivineEnder
Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133011336 --- Diff: geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatInstall.java --- @@ -131,15 +142,20 @@ public TomcatInstall(TomcatVersion

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

2017-08-14 Thread DivineEnder
Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133012057 --- Diff: geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatInstall.java --- @@ -150,6 +166,66 @@ public TomcatInstall(TomcatVersion

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

2017-08-14 Thread DivineEnder
Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133012849 --- Diff: geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatSessionBackwardsCompatibilityTest.java --- @@ -0,0 +1,254

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

2017-08-14 Thread DivineEnder
Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133013329 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java --- @@ -34,6 +34,7 @@ import

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

2017-08-14 Thread DivineEnder
Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133013984 --- Diff: geode-old-versions/build.gradle --- @@ -65,6 +100,71 @@ task createGeodeClasspathsFile { new FileOutputStream(classpathsFile

[GitHub] geode issue #622: GEODE-1731: Modifying region size check to be more accurat...

2017-07-10 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/622 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode issue #626: GEODE-3179: Fixing bundled jars test finding slf4j-jdk jar

2017-07-12 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/626 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode pull request #626: GEODE-3179: Fixing bundled jars test finding slf4j-...

2017-07-12 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/626 GEODE-3179: Fixing bundled jars test finding slf4j-jdk jar This fixes the failing verify bundled jars test, caused by an unexpected slf4j-jdk jar coming from the tomcat module folder when

[GitHub] geode pull request #639: GEODE-3112: Fixing improper ordering of client time...

2017-07-17 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/639 GEODE-3112: Fixing improper ordering of client timeout setting Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you

[GitHub] geode issue #639: GEODE-3112: Fixing improper ordering of client timeout set...

2017-07-17 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/639 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode issue #584: GEODE-2901: Adding integration tests of session replicatio...

2017-06-28 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/584 Single successful run on course when only running the Distributed tests in geode-assembly. Testing again with fully concourse run. 🤞 --- If your project is set up for it, you can reply

[GitHub] geode pull request #608: GEODE-3140: Removed DiskDirRule and replaced use wi...

2017-06-28 Thread DivineEnder
Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/608#discussion_r124621529 --- Diff: geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPersistenceIntegrationTest.java --- @@ -48,13 +49,13 @@ public

[GitHub] geode issue #618: GEODE-3167: Added commons-validator dependency to modify_w...

2017-07-05 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/618 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode pull request #618: GEODE-3167: Added commons-validator dependency to m...

2017-07-05 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/618 GEODE-3167: Added commons-validator dependency to modify_war script a… …nd Tomcat required jars Thank you for submitting a contribution to Apache Geode. In order

[GitHub] geode issue #619: Feature/geode 2901

2017-07-05 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/619 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode pull request #619: Feature/geode 2901

2017-07-05 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/619 Feature/geode 2901 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been

[GitHub] geode issue #619: Feature/geode 2901

2017-07-05 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/619 Still working on adding javadoc, but the actual code is all in place --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode pull request #688: GEODE-3397: Fixed issue with Tomcat locators in cac...

2017-08-04 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/688 GEODE-3397: Fixed issue with Tomcat locators in cache-client.xml file Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we

[GitHub] geode issue #688: GEODE-3397: Fixed issue with Tomcat locators in cache-clie...

2017-08-04 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/688 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode issue #666: GEODE-3329: Changed logging output of modify_war script

2017-07-28 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/666 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou @PurelyApplied --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] geode pull request #666: GEODE-3329: Changed logging output of modify_war sc...

2017-07-28 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/666 GEODE-3329: Changed logging output of modify_war script Changed the modify_war script so that its output and error streams write to a log file instead of to standard out. Thank you

[GitHub] geode pull request #662: GEODE-3301: Installations now cleanup previously le...

2017-07-27 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/662 GEODE-3301: Installations now cleanup previously left over directories… This should hopefully fix Jenkins build issues Thank you for submitting a contribution to Apache Geode

[GitHub] geode issue #662: GEODE-3301: Installations now cleanup previously left over...

2017-07-27 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/662 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode pull request #722: GEODE-3184: Cleaned up Cargo tests

2017-08-18 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/722 GEODE-3184: Cleaned up Cargo tests Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] geode issue #603: GEODE-3128: Changed the batch size to 1000 when creating A...

2017-06-26 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/603 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode pull request #603: GEODE-3128: Changed the batch size to 1000 when cre...

2017-06-26 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/603 GEODE-3128: Changed the batch size to 1000 when creating AEQFactory * Prevously the batch size was the default 100 * Also added Lucene index overhead tests as performance tests. Currently

[GitHub] geode pull request #527: GEODE-2961: Fixed distinct multiple OR query return...

2017-05-23 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/527 GEODE-2961: Fixed distinct multiple OR query returning partial results Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we

[GitHub] geode issue #531: GEODE-2955: Validating region names when creating lucene i...

2017-05-24 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/531 @upthewaterspout @nabarunnag @ladyVader @jhuynh1 @boglesby --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] geode pull request #533: GEODE-2944: Added __REGION_VALUE_FIELD explanation ...

2017-05-24 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/533 GEODE-2944: Added __REGION_VALUE_FIELD explanation to Lucene create i… …ndex help Thank you for submitting a contribution to Apache Geode. In order to streamline the review

[GitHub] geode pull request #532: GEODE-2950: Adding validation checks on create Luce...

2017-05-24 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/532 GEODE-2950: Adding validation checks on create Lucene index parameter… … names Thank you for submitting a contribution to Apache Geode. In order to streamline the review

[GitHub] geode issue #532: GEODE-2950: Adding validation checks on create Lucene inde...

2017-05-24 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/532 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode issue #540: GEODE-2950: Updated error messages

2017-05-25 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/540 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode pull request #540: GEODE-2950: Updated error messages

2017-05-25 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/540 GEODE-2950: Updated error messages * Different error messages are displayed when validating region names versus indexes. * Added flexible enum allowing for expanded error messages

[GitHub] geode issue #543: GEODE-2957 gfsh create lucene index "null" becomes "DEFAUL...

2017-05-30 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/543 Looks good 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] geode pull request #587: GEODE-2018: Added instantiators to SessionCachingFi...

2017-06-16 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/587 GEODE-2018: Added instantiators to SessionCachingFilter init method Also removed unused registerInstantiator methods from GatewayDeltaCreateEvent, GatewayDeltaDestroyEvent

[GitHub] geode issue #587: GEODE-2018: Added instantiators to SessionCachingFilter in...

2017-06-16 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/587 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode issue #589: GEODE-393: Providing cache for FunctionContext

2017-06-16 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/589 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode pull request #589: GEODE-393: Providing cache for FunctionContext

2017-06-16 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/589 GEODE-393: Providing cache for FunctionContext Added the ability to pass a Cache to a function context as well as tests to check for this. Thank you for submitting a contribution

[GitHub] geode pull request #584: GEODE-2901: Adding integration tests of session rep...

2017-06-15 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/584 GEODE-2901: Adding integration tests of session replication Adding integration tests that test both session replications frameworks shipped with geode. These tests use cargo to download

[GitHub] geode issue #584: GEODE-2901: Adding integration tests of session replicatio...

2017-06-15 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/584 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode pull request #527: GEODE-2961: Fixed distinct multiple OR query return...

2017-05-24 Thread DivineEnder
Github user DivineEnder closed the pull request at: https://github.com/apache/geode/pull/527 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode pull request #537: GEODE-2957: Added DEFAULT as a standardAnalyzer key...

2017-05-25 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/537 GEODE-2957: Added DEFAULT as a standardAnalyzer keyword specifier whe… …n creating Lucene index Thank you for submitting a contribution to Apache Geode. In order

[GitHub] geode issue #537: GEODE-2957: Added DEFAULT as a standardAnalyzer keyword sp...

2017-05-25 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/537 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode pull request #547: GEODE-2957: Create Lucene index analyzer help updat...

2017-05-30 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/547 GEODE-2957: Create Lucene index analyzer help updated to include keyw… …ord DEFAULT Thank you for submitting a contribution to Apache Geode. In order to streamline

[GitHub] geode issue #608: GEODE-3140: Removed DiskDirRule and replaced use with Temp...

2017-06-27 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/608 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode pull request #608: GEODE-3140: Removed DiskDirRule and replaced use wi...

2017-06-27 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/608 GEODE-3140: Removed DiskDirRule and replaced use with TemporaryFolder… … rule Thank you for submitting a contribution to Apache Geode. In order to streamline the review