Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/402#discussion_r102356823
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionManagerDUnitTest.java
---
@@ -159,77 +159,74 @@ public void
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/398
@metatype there are no changes in the netty NOTICE.txt between 4.1.7 and
4.1.8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/305
It looks like you also need to run "./gradlew spotlessApply" to reformat
your changes. The Travis build complained that spotlessJavaCheck failed.
---
If your project is set up for i
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/323#discussion_r93273028
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/Locator.java ---
@@ -253,7 +253,7 @@ private static Locator startLocator(int port, File
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/323#discussion_r93273525
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/DistributionLocator.java ---
@@ -166,9 +166,9 @@ public void run() {
try
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/426
Also, since we're talking about releasing v 1.2 soon it would be nice to
add the Experimental annotation with this same commit since it is breaking
compatibility with v 1.1.
---
If your project
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/426
I don't think we can merge these changes until the lock-service variables
in ExeuctionHandlerContext are made static. As it's currently implemented
every ExecutionContextHandler has its own lock
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/426
my bad - I checkout out ggreen's branch by mistake. I don't see any
@Experimental at all in your branch. It looks like your second commit removed
it from GeodeRedisServer.java when you meant
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/426
got it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/444#discussion_r110697384
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedCacheOperation.java
---
@@ -240,12 +240,37 @@ public boolean
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/444#discussion_r110699099
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedCacheOperation.java
---
@@ -240,12 +240,37 @@ public boolean
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/444#discussion_r110708948
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java ---
@@ -1261,7 +1333,14 @@ void basicUpdateEntryVersion
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/458
Yes, I think it could be an attribute of the connection pool. That would
be perfect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/412
There are "spotless" problems I'm cleaning up, and I'm removing the
commented out code from the test.
---
If your project is set up for it, you can reply to this email and have your
re
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/412#discussion_r104259153
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
---
@@ -77,9 +77,9 @@
*
* This should
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/412#discussion_r104260160
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
---
@@ -360,6 +360,13 @@ private void processRequest
GitHub user bschuchardt opened a pull request:
https://github.com/apache/geode/pull/412
GEODE-1793 LocatorDUnitTest.testStartTwoLocatorsOneWithSSLAndTheOtherâ¦
This was a product issue. When the locator using plain-text sockets is
contacted by a TcpClient using SSL the locator
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/412
remote: geode git commit: GEODE_1793 spotless fixes and removal of dead code
remote: geode git commit: GEODE-1793
LocatorDUnitTest.testStartTwoLocatorsOneWithSSLAndTheOtherNonSSL
To https
Github user bschuchardt closed the pull request at:
https://github.com/apache/geode/pull/412
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/702#discussion_r133325744
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/net/SocketCloser.java ---
@@ -96,46 +99,55 @@ public int getMaxThreads() {
return
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127276853
--- Diff: geode-protobuf/src/main/proto/basicTypes.proto ---
@@ -52,7 +52,12 @@ message CallbackArguments {
message Region {
string
GitHub user bschuchardt opened a pull request:
https://github.com/apache/geode/pull/634
Feature/geode 3175
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/634
@kohlmu-pivotal @hiteshk25 @galen-pivotal @pivotal-amurmann
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bschuchardt closed the pull request at:
https://github.com/apache/geode/pull/634
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/676
The license header was probably damaged during some search
operations to transform the google-doc version of the list into an enum
---
If your project is set up for it, you can reply
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/673
Locators aren't configured via cluster config. None of the
distributed-system properties are configured through cluster configuration
because you must connect to the distributed system in order
GitHub user bschuchardt opened a pull request:
https://github.com/apache/geode/pull/719
GEODE-3447 Implement client authorization for the new protocol
Implementation of authorization checks for the new protocol. This will
have to be merged with the Locator Protobuf communications
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/719#discussion_r134600589
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java
---
@@ -40,20 +42,28 @@ public void
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/719#discussion_r134599066
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthorizer.java
---
@@ -0,0 +1,42 @@
+/*
+ * Licensed
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/474#discussion_r114618650
--- Diff:
geode-core/src/main/resources/META-INF/schemas/geode.apache.org/schema/cache/cache-1.0.xsd
---
@@ -1191,6 +1191,7 @@ As of 6.5 disk-dirs
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/475
Hi Masaki,
I will do the merge for you
Le 5/10/2017 à 4:00 AM, Masaki Yamakawa a écrit :
>
> Thanks @bschuchardt <https://github.com/bschuchardt> @kirklund
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/475
I am running precheckin on this PR and will merge it to develop afterward.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/474
I am running precheckin on this PR and will merge it to develop afterward.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/483
I will merge this pull request to develop. I may not get it done until
early next week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/474
Masaki, this change set is breaking unit tests because the new XSD
attribute is being put into XML files generated for older versions.
CacheXml80DUnitTest, for instance, is breaking. l80Please
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/586
I'm running precheckin on this PR & will merge it to develop when finished
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/586
There was a failure in one of the new tests
:geode-core:integrationTest
org.apache.geode.internal.cache.tier.sockets.ServerConnectionFactoryIntegrationTest
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/474
Masaki, it looks like there are some conflicts that need to be resolved
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user bschuchardt reopened a pull request:
https://github.com/apache/geode/pull/746
GEODE-3529 move new client/server security classes to a different pacâ¦
@kohlmu-pivotal @hiteshk25 @galen-pivotal @pivotal-amurmann @metatype
The new classes/interfaces have been
Github user bschuchardt closed the pull request at:
https://github.com/apache/geode/pull/746
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/746#discussion_r135888279
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
---
@@ -41,8 +41,8 @@ private synchronized
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/746
okay - travis ci passed this time
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/719
GetAvailableServers will be executed on a Locator which installs a no-op
authorizer in the execution "context". That can change if we decide later on
that we want to perform auth
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/702#discussion_r134339691
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/net/SocketCloser.java ---
@@ -96,46 +99,55 @@ public int getMaxThreads() {
return
Github user bschuchardt closed the pull request at:
https://github.com/apache/geode/pull/719
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user bschuchardt reopened a pull request:
https://github.com/apache/geode/pull/719
GEODE-3447 Implement client authorization for the new protocol
Implementation of authorization checks for the new protocol. This will
have to be merged with the Locator Protobuf
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/719#discussion_r135575597
--- Diff:
geode-core/src/main/java/org/apache/geode/security/StreamAuthenticator.java ---
@@ -46,6 +44,14 @@ void receiveMessage(InputStream inputStream
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/719
@metatype After reviewing StreamAuthenticator I get your point. I think
these new interfaces and classes need to be in a different package.
---
If your project is set up for it, you can reply
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/746
Travis check failed in an unrelated unit test. This test passes on my
branch when I run it individually or as part of the "build" task.
---
If your project is set up for it, you
GitHub user bschuchardt opened a pull request:
https://github.com/apache/geode/pull/746
GEODE-3529 move new client/server security classes to a different pacâ¦
@kohlmu-pivotal @hiteshk25 @galen-pivotal @pivotal-amurmann @metatype
The new classes/interfaces have been moved
50 matches
Mail list logo
