Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/549#discussion_r119220596
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
@@ -1794,18 +1801,20 @@ public
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/549#discussion_r119219867
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
@@ -771,11 +771,18 @@ public
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/549#discussion_r119229190
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
@@ -771,11 +771,18 @@ public
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/549#discussion_r119231037
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
---
@@ -2747,6 +2749,8 @@
public static final
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/549#discussion_r119233486
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
@@ -771,11 +771,18 @@ public
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/551#discussion_r119420029
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/ShellExitCode.java ---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/551#discussion_r119419341
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/ShellExitCode.java ---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/530
Thank you for your contribution, looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/557
Looks like travis-ci failed. LGTM as soon as travis passes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/508
This PR has already been merged in, but feel free to open a new ticket for
that. We unfortunately still have a lot of other "gemfire" references
scattered around.
---
If your proj
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/566
Some more feedback after walking through the example.. Now that we start a
locator (which starts an http server of its own on 7070) we need to specify a
different http port for the server
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/566
(I also need to file a bug since that command appeared to hang.. But it did
end up starting the server despite gfsh hanging with an endless ".")
---
If your project is set up f
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/508
Merged as `ac404ad`. Thank you for your contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r122066276
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/query/internal/OrderByComparator.java
---
@@ -228,4 +139,55 @@ void addEvaluatedSortCriteria
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/566
I think it would probably be best to omit
`--J=-Dgemfire.http-service-bind-address=localhost` from the `start server`
command for the sake of simplicity. You also might want to consider
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/508
Looks good to me. I'll merge it in shortly and cherry pick onto the
release branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/730#discussion_r134872863
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/MBeanJMXAdapter.java
---
@@ -72,16 +72,13 @@
private DistributedMember
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/730#discussion_r134869226
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java
---
@@ -158,7 +156,7 @@
private Thread runner
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/730#discussion_r134869699
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java
---
@@ -212,8 +211,7 @@ public static void bytesToFiles(byte
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/730#discussion_r134867453
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
---
@@ -415,9 +413,8 @@ public Result
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/729#discussion_r134348604
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/AbstractProcessStreamReaderIntegrationTest.java
---
@@ -149,7 +147,7 @@ protected
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/753#discussion_r136444815
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportDataCommand.java
---
@@ -41,44 +44,34 @@ public Result
101 - 122 of 122 matches
Mail list logo
