Re: Request for bulk change permission

2019-10-01 Thread Dan Smith
I think you should have permissions now. -Dan On Tue, Oct 1, 2019 at 10:00 AM Jens Deppe wrote: > I don't seem to have this - please could someone grant it. > > Thanks > --Jens >

Re: Lingering Geode 1.10.0 release issues

2019-09-27 Thread Dan Smith
Bruce has picked up GEODE-7250. -Dan On Fri, Sep 27, 2019 at 9:27 AM Dick Cavender wrote: > If you try and brew update to Geode 1.10.0 you won't get it until our > 1.10.0 homebrew PR > gets > through their checks and their Jenkins servers

Re: [DISCUSS] Logging module separation

2019-09-26 Thread Dan Smith
Sorry Anil. Maybe this will work - https://cwiki.apache.org/confluence/x/cRLABw -Dan

Re: [DISCUSS] Logging module separation

2019-09-26 Thread Dan Smith
If you are wondering how this relates to the geode-log4j work that Kirk did, the following diagram might help. Basically, he made a geode-log4j module that makes log4j-core optional. This geode-logging module allows the use of some of our log4j wrapper classes from modules other than geode-core.

Re: [PROPOSAL] adding java-jq to GEODE dependency for testing

2019-09-25 Thread Dan Smith
+1 - sounds good. BTW - We've previously found libraries that use JNA tend to be more flaky/platform dependent than pure java libaries - for example we ripped out a snappy native wrapper in favor of a pure java implementation. -Dan On Wed, Sep 25, 2019 at 8:39 AM Anthony Baker wrote: > Sounds

Re: [DISCUSS] GEODE-7241 - make Jar not War?

2019-09-25 Thread Dan Smith
I could see value in publishing the war files, if geode will actually pick up the war file from the classpath and deploy it when these features are enabled. Udo - it looks like you actually made a change with GEODE-5660 to enable that? +1 to making them .GWAR instead :) -Dan On Wed, Sep 25,

Re: War's vs JArs

2019-09-24 Thread Dan Smith
Huh. Looks like we're missing a 'from components.web' in publish.gradle if we want to publish the war files. I'm not sure why this has changed. I'm not sure how we want to actually ship these projects - they are in the .tgz of geode. They are not really standalone war files, from what I remember

Re: [VOTE] Apache Geode 1.10.0.RC2

2019-09-24 Thread Dan Smith
+1 Ran geode-release-check (checks signatures, source build, simple gfsh test) -Dan On Mon, Sep 23, 2019 at 3:20 PM Jacob Barrett wrote: > +1 > > Still think it is ok to ship but found another annoying issue. When > running Geode Native C++ integration tests (new framework) an indented >

Re: Reviewers for PR #3888

2019-09-24 Thread Dan Smith
Reviewed and merged. Thanks for all your hard work on this one! -Dan On Mon, Sep 23, 2019 at 6:18 AM Alberto Gomez wrote: > Hi, > > Could I please get some extra reviewers for > https://github.com/apache/geode/pull/3888? > > This PR is about GEODE-7049: Add timeout parameter to Java client >

Re: [DISCUSS] Improvements on client function execution API

2019-09-16 Thread Dan Smith
implementation. > > -Alberto G. > > On 12/9/19 8:15, Jacob Barrett wrote: > > +1 > > > > I echo Dan’s comments as well. > > > > Thanks for tackling this. > > > > -jake > > > > > >> On Sep 11, 2019, at 2:36 PM, Dan Smith wrote: >

Re: Propose including GEODE-7178 in 1.10

2019-09-12 Thread Dan Smith
+1 for getting this in 1.10. I am curious though - is the native client behaving like an older versions of the java client, or is this totally unique behavior for the native client? Is there some integration test that we are missing here? -Dan On Thu, Sep 12, 2019 at 11:52 AM Michael Oleske

Re: [DISCUSS] Improvements on client function execution API

2019-09-11 Thread Dan Smith
a client. > > - Do not implement the blocking execute(timeout) method on the server > and leave the current execute() implementation on the server as it is > (non-blocking) > > Does this make sense? > > -Alberto > > On 29/8/19 12:56, Alberto Gómez wrote: > > >

Re: Question about excluding serialized classes

2019-09-11 Thread Dan Smith
vice class does not specify that > >> getFunction must return the same type function as the one passed to > >> registerFunction, but I could see how users might be relying on that > >> behavior since there is no other way to get a specific function type &

Re: Question about excluding serialized classes

2019-09-11 Thread Dan Smith
e passed to > registerFunction, but I could see how users might be relying on that > behavior since there is no other way to get a specific function type out of > the FunctionService without doing a cast. > > - Aaron > > > On Wed, Sep 11, 2019 at 10:52 AM Dan Smith wrote: >

Re: [Proposal] Make gfsh "stop server" command synchronous

2019-09-11 Thread Dan Smith
ghts? > > Thanks, > Mark > > > On Sep 11, 2019, at 10:23 AM, Dan Smith wrote: > > > > It does seem like we should make stop synchronous, or at least make start > > wait for the old process to die as Bruce suggested. Otherwise it is > > difficult for some

Re: Question about excluding serialized classes

2019-09-11 Thread Dan Smith
Functions are serialized when you call Execution.execute(Function) instead of Execution.execute(String). Invoking execute on a function object serializes the function and executes it on the remote side. Functions executed this way don't have be registered. Users can also get registered function

Re: [Proposal] Make gfsh "stop server" command synchronous

2019-09-11 Thread Dan Smith
It does seem like we should make stop synchronous, or at least make start wait for the old process to die as Bruce suggested. Otherwise it is difficult for someone to script the restart of a server. Looking at the code, it does look like gfsh stop is asynchronous. There are multiple ways to stop

Re: [DISCUSS] RFC - Move membership code to a separate gradle sub-project

2019-09-10 Thread Dan Smith
e and believe some attention is to be given to this, once a > decision to convert the serialization to a stand alone module. > > --Udo > > On 8/30/19 3:50 PM, Dan Smith wrote: > > Hi all, > > > > We added the following RFC to the wiki about moving Geode's membership > >

Re: [VOTE] Apache Geode 1.10.0.RC1

2019-09-09 Thread Dan Smith
> >> > org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter.execute(EventFiringTaskExecuter.java:49) > >>>>>> at > >>>>>> > >>>>> > >> > org.gradle.execution.plan.LocalTaskNodeExecutor.execute(LocalTaskNode

Re: [VOTE] Apache Geode 1.10.0.RC1

2019-09-05 Thread Dan Smith
> > > > to fail. > > > > > > > > I am not sure if this is harmless or has some adverse consequences. I > > > would > > > > like to know why it's designed this way. > > > > > > > > Regards > > > > Naba

Re: Wiki write access needed

2019-09-05 Thread Dan Smith
Ok, you should have access now. -Dan On Wed, Sep 4, 2019 at 5:01 PM Ernest Burghardt wrote: > echobravo > > On Wed, Sep 4, 2019 at 4:43 PM Dan Smith wrote: > > > What's your username on the wiki? > > > > -Dan > > > > On Wed, Sep 4, 2019 at 4:36 PM Er

Re: Wiki write access needed

2019-09-04 Thread Dan Smith
What's your username on the wiki? -Dan On Wed, Sep 4, 2019 at 4:36 PM Ernest Burghardt wrote: > Hello, > > May I please have write access to the wiki? > > Thank you, > EB >

Re: [VOTE] Apache Geode 1.10.0.RC1

2019-09-04 Thread Dan Smith
s/dist/dev/geode/1.10.0.RC1/ > Please continue to review RC1 as a viable 1.10 RC. The voting deadline > remains 3PM PST Thursday Sept 5th. > > -Dick > > > On Tue, Sep 3, 2019 at 3:09 PM Dan Smith wrote: > > > Everything but the missing native source looks good. If

Re: [VOTE] Apache Geode 1.9.1.RC3

2019-09-04 Thread Dan Smith
+1 Ran geode-release-check - https://github.com/upthewaterspout/geode-release-check I have no opinion on the bug Jens found - since was a bug in 1.9.0, I'm ok shipping 1.9.1 without it. -Dan On Wed, Sep 4, 2019 at 10:16 AM Robert Houghton wrote: > Hi Jens, > > Does this issue appear in

Re: [VOTE] Apache Geode 1.10.0.RC1

2019-09-03 Thread Dan Smith
Everything but the missing native source looks good. If we can fix that, I'll +1 this RC. -Dan On Tue, Sep 3, 2019 at 2:26 PM Dan Smith wrote: > -1 It looks like this RC is also missing the native source, just like > 1.9.1.RC3. The tar file is there, but it is empty. > > -Dan >

Re: [VOTE] Apache Geode 1.10.0.RC1

2019-09-03 Thread Dan Smith
-1 It looks like this RC is also missing the native source, just like 1.9.1.RC3. The tar file is there, but it is empty. -Dan On Fri, Aug 30, 2019 at 2:06 PM Dick Cavender wrote: > Hello Geode dev community, > > This is a release candidate for Apache Geode, version 1.10.0.RC1. > Thanks to all

Re: [VOTE] Apache Geode 1.9.1.RC3

2019-09-03 Thread Dan Smith
It looks like the native source is missing from this RC? There is a tar file, but it is emply if you try to unzip it. -Dan On Fri, Aug 30, 2019 at 11:11 AM Owen Nichols wrote: > Hello Geode dev community, > > This is a release candidate for Apache Geode, version 1.9.1.RC3. > Thanks to all the

[DISCUSS] RFC - Move membership code to a separate gradle sub-project

2019-08-30 Thread Dan Smith
Hi all, We added the following RFC to the wiki about moving Geode's membership system to a separate gradle sub-project. Please review and comment by 9/6/2019. https://cwiki.apache.org/confluence/x/WRB4Bw Thanks! -Dan

Re: [VOTE] Apache Geode 1.9.1 RC1 (new vote)

2019-08-29 Thread Dan Smith
I'm going to vote -1 until we get the Version.java issue figured out. It is sounding like we will need to revert the changes and create a new RC unless we come to an agreement that bumping the version for 1.9.1 is the right way to go. -Dan On Thu, Aug 29, 2019 at 11:47 AM Jens Deppe wrote: >

Re: [VOTE] Apache Geode 1.9.1 RC1

2019-08-29 Thread Dan Smith
103 and 104) if we *ever* need to issue > more 1.9 patches. I recommend removing that Version and leaving the > serialization version at 1.9.0 for this release. > > > > On 8/28/19 2:51 PM, Dan Smith wrote: > >> I missed this vote email as well - if we reopen the vote

Re: [DISCUSS] Improvements on client function execution API

2019-08-28 Thread Dan Smith
Sorry for the slow response, I've been trying to decide what I think is the right approach here. For (1) - conceptually, I don't have a problem with having both blocking and non blocking methods on Execution. So adding blocking versions of execute() with a timeout seems ok. But I do think if we

Re: [VOTE] Apache Geode 1.9.1 RC1

2019-08-28 Thread Dan Smith
I missed this vote email as well - if we reopen the vote I'll cast one. I don't really have much context on why we want a 1.9.1 but I'm happy to double check the bits. One comment on this RC - I noticed that we bumped the ordinal in Version.java - is that what we actually want to do? That implies

Re: [DISCUSS] Pulling the current proposed 1.10 release until we can agree on develop being stable

2019-08-27 Thread Dan Smith
+1 to creating RC1 with the current release/1.10 branch this week. I don't see a fundamental problem with cherry-picking some targeted and tested fixes to release/1.10, based on our assessment of the risk to customers vs. the risk of destabilizing the branch. I think release/1.10 is in a good

Propose including GEODE-7085 in 1.10

2019-08-26 Thread Dan Smith
Hi, I'd like to propose including the fixes for GEODE-7085 into 1.10 (SHA's below). This is not a new issue, but it does result not being able to recover from disk without this fix if a cluster has more than 2 billion updates to a single bucket from a single member. SHAs: f587101 , f17931bf

Fwd: [DISCUSS] Improvements on client function execution API

2019-08-22 Thread Dan Smith
For the two new execute() methods you are proposing, are you also suggesting that they be implemented on the server? I took a look at the C++ API. The C++ API also has a ResultCollector.getResult(timeout) method. Does that timeout do anything, given that execute(timeout) already waited for the

Re: Rat check reporting error in travis-ci for geode-native

2019-08-21 Thread Dan Smith
Hi Helena, I think the problem is that rat is currently broken on geode-native develop. -Dan On Wed, Aug 21, 2019 at 2:55 PM Helena Bales wrote: > Hi Alberto, > > If you have added a file as part of your PR, please add the header as a > commit to your working branch and add that as part of

Re: [DISCUSS] Controlling event dispatch to AsyncEventListener (review by Aug 22)

2019-08-16 Thread Dan Smith
Hi Anil, While I like the idea of matching the API of GatewaySender, I'm not sure I see how this solves the problem. Is it required of the user to call pause on the AsyncEventQueue as soon as it is created? How would someone do that when creating AEQs with xml or cluster configuration? Maybe it

Re: Propose fix for 1.10 release: Prevent NPE in getLocalSize()

2019-08-15 Thread Dan Smith
@kirk - go ahead and push it. -Dan On Thu, Aug 15, 2019 at 3:13 PM Kirk Lund wrote: > I have the cherry-pick ready to push or file a PR. Let me know what you > prefer... > > On Thu, Aug 15, 2019 at 3:01 PM Dan Smith wrote: > > > Normally cherry-picking to the release

Re: Propose fix for 1.10 release: Prevent NPE in getLocalSize()

2019-08-15 Thread Dan Smith
Normally cherry-picking to the release branch is the release managers job (Dick in this case) [1]. He asked me to help out while he was on vacation, so I will go ahead and cherry-pick it over. I kinda like the process Jake proposed though - creating a PR against the release branch. My only

Re: Proposal to Include GEODE-7079 in 1.10.0

2019-08-15 Thread Dan Smith
+1 to merging Juan's fix for GEODE-7079. I've seen systems taken down by rapidly filling up the logs in the past, this does seem to be a critical fix from the perspective of system stability. Also, this is the change, which doesn't seem particularly risky to me. - ConflationKey key =

Re: Wiki edit permissions

2019-08-09 Thread Dan Smith
Done! You should have access now. Thanks, -Dan On Fri, Aug 9, 2019 at 10:02 AM Helena Bales wrote: > Hello, > I am trying to update a wiki doc and need permissions for Confluence. My > LDAP username is heybales. > Thank you! > ~Helena >

Re: Unit tests are hanging?

2019-08-08 Thread Dan Smith
> With all that, I propose we permanently bump the timeouts on UnitTestX jobs > across the board (main pipeline, PR pipeline, etc) from 10 to 20 minutes to > be more tolerant of these types of degradations. > +1 -Dan

Another change for 1.10.0 release

2019-08-08 Thread Dan Smith
Hi all, I'd like to get the fix for GEODE-7055 (Don't send failure replies from a P2P reader thread) into the 1.10.0 release branch. This bug was causing a hang on startup for users of the session replication module that didn't put the session jars on the classpath of the locator. The hang

Re: [DISCUSS] Time to cut Geode 1.10.0?

2019-07-26 Thread Dan Smith
+1 for cutting a 1.10.0 release branch. On Fri, Jul 26, 2019 at 3:55 PM Nabarun Nag wrote: > Hi, > I believe the original authors of the feature has done their due diligence > and followed all steps, we can get this feature in under the Experimental > flag and let the community improve on it,

Re: [DISCUSS] RFC 0: Lightweight RFC Process

2019-07-15 Thread Dan Smith
cted. > > I think it is ok to have an "Icebox" of proposals that lists areas of > improvement we want to target, but as of yet, no concrete proposal has > yet been submitted. Modularity comes to mind. It is not that we don't > want to do it, it is just that there is no proposal th

Re: some pages in the wiki may be not on the right place

2019-07-12 Thread Dan Smith
+1 -Dan On Fri, Jul 12, 2019 at 9:44 AM Gang Yan wrote: > seems no disagree response( and no agree response), I am planning to do > this. > > Thanks > > Gang Yan(闫钢) > > > > On Fri, May 17, 2019 at 12:06 PM Gang Yan wrote: > > > Hi Geode Dev > > > > updated table, to add 4 sub pages: > > > >

Re: [DISCUSS] RFC 0: Lightweight RFC Process

2019-07-12 Thread Dan Smith
posals+and+Specifications > > > . > > Thank you all for you great feedback throughout this process! > > On Tue, Jun 25, 2019 at 10:07 AM Dan Smith wrote: > > > > > > > Will moving the page around on the wiki result in dead links to the > draft > &

Re: [Proposal] Refactor the Cache and Region perf stats structure.

2019-07-10 Thread Dan Smith
Seems reasonable. I'm guessing that CachePerfImpl contains many RegionStats. Does PartitionRegionStatsImpl just contain a single RegionStats? On Wed, Jul 10, 2019 at 4:49 PM Mark Hanson wrote: > Hi All, > > As many of you may know our structure for our perf stats is not great. I > would like to

Re: Proposal: For PR reviews and change requests can we have a 7 day turn around on re-reviews?

2019-07-09 Thread Dan Smith
+1 What do you think about assigning someone to each PR to make sure it gets through the process? We don't currently seem to be using github's "assignee" field. Committers can make themselves the assignee, but for contributors we could assign a committer who will make sure the PR gets reviewed

Re: [PROPOSAL]: Improve OQL Method Invocation Security

2019-07-03 Thread Dan Smith
With Juan's proposal, the user still has the option to use java's security manager. They can install a MethodAuthorizor that allows all methods and use a java SecurityManager to restrict method access to the methods they want. Regarding the question of "How far should we go to prevent users from

Re: Access to update JIRA

2019-06-26 Thread Dan Smith
Done! You should have access now. Thanks, -Dan On Wed, Jun 26, 2019 at 6:24 PM Kamilla Aslami wrote: > Hi Helena, > > My username is kaslami. > > Thanks! > Kamilla > > On Wed, Jun 26, 2019 at 6:21 PM Helena Bales wrote: > > > Hi Kamilla, > > > > What is your username for Jira? We'll need that

Re: [DISCUSS] Add a test dependency to geode-core - ArchUnit

2019-06-26 Thread Dan Smith
e other pieces) into separate gradle modules - > > proposal > > >>>>> forthcoming! However, as a first step we need to untangle those > > pieces of > > >>>>> code from the rest of geode-core. Rather than creating some long > &g

Re: [PROPOSAL]: Improve OQL Method Invocation Security

2019-06-26 Thread Dan Smith
've already looked and didn't > really > > find anything relevant you could also mention that in the proposal. > > > > - Aaron > > > > > > On Mon, Jun 24, 2019 at 4:31 PM Jason Huynh wrote: > > > >> +1 > >> > >> I have some c

Re: [DISCUSS] RFC 0: Lightweight RFC Process

2019-06-25 Thread Dan Smith
> > Will moving the page around on the wiki result in dead links to the draft > version? > No. If you use the share button in the wiki, you get a permanent link to the page. Even if you just copy the URL from the address bar it doesn't include the folder the page is in. -Dan

Re: [PROPOSAL]: Improve OQL Method Invocation Security

2019-06-24 Thread Dan Smith
+1 This proposal looks good to me! On Mon, Jun 24, 2019 at 4:15 PM Udo Kohlmeyer wrote: > +1, Count me in > > On 6/24/19 13:06, Juan José Ramos wrote: > > Hey Jake, > > > > Sure, I guess we could do a live session if there's enough interest after > > people have reviewed the proposal. > > Best

Re: [DISCUSS] RFC 0: Lightweight RFC Process

2019-06-24 Thread Dan Smith
roposal would be under development, correct? > > On Mon, Jun 24, 2019 at 3:30 PM Dan Smith wrote: > > > +1 > > > > Looks good to me! > > > > A couple of minor thoughts - it might be nice to have separate > > subdirectories on the wiki for the differe

Re: [DISCUSS] RFC 0: Lightweight RFC Process

2019-06-24 Thread Dan Smith
+1 Looks good to me! A couple of minor thoughts - it might be nice to have separate subdirectories on the wiki for the different proposal states, to easily see what state the proposals are in. One thing that isn't visible in these states - is the proposal actively under development? It might

Re: [DISCUSS] Add a test dependency to geode-core - ArchUnit

2019-06-20 Thread Dan Smith
On Thu, Jun 20, 2019 at 4:23 PM Jacob Barrett wrote: > Are you adding this dependency to just the membership module? I am cool > with that. > > > On Jun 20, 2019, at 2:39 PM, Dan Smith wrote: > > > > Hi all, > > > > Bill, Ernie, and I would l

Re: [PROPOSAL]: Improve OQL Method Invocation Security

2019-06-20 Thread Dan Smith
+1 This looks really good! I put a couple of comments inline, and I have a few more general questions here: 1. Is the RegionQueryInvocationAuthorizer different than our existing shiro permissions? I thought users can already grant permissions for specific regions. What does this add in addition

[DISCUSS] Add a test dependency to geode-core - ArchUnit

2019-06-20 Thread Dan Smith
Hi all, Bill, Ernie, and I would like to add a new (apache licensed) test dependency to geode-core - https://github.com/TNG/ArchUnit. This is a tool that lets you write tests that make assertions about the interdependencies of your code - for example enforcing that package A does not depend on

Re: Confluence access

2019-06-18 Thread Dan Smith
Done! You should have access now. Thanks, -Dan On Tue, Jun 18, 2019 at 4:03 PM Murtuza Boxwala wrote: > Can I get access to the confluence wiki, please? > > Email: mboxw...@pivotal.io > Username: mboxwala

Re: Disk dir size units in javadoc comments

2019-06-18 Thread Dan Smith
I think the comment is correct, but what that test is doing is weird. I see it's setting this property, which leads be to believe that there is some code that changes the units based on this property. DirectoryHolder.SET_DIRECTORY_SIZE_IN_BYTES_FOR_TESTING_PURPOSES = true; Maybe a better change

Re: [PROPOSAL] Instrumenting Geode Code

2019-06-11 Thread Dan Smith
+1 I like it! I like that we are not having to maintain duplicate meter and stat code. Also, I think keeping hiding metrics and stats inside an instrumentation class with methods like regionAdded makes it much easier to unit test classes that record metrics. -Dan On Mon, Jun 10, 2019, 5:13 PM

Re: Permissions to apache-geode jira dashboard

2019-06-10 Thread Dan Smith
You should have access now. Thanks, -Dan On Mon, Jun 10, 2019 at 10:31 AM Murtuza Boxwala wrote: > Can I please have permissions to edit the Apache-Geode JIRA dashboard. My > username is mboxwala. I would like to be able to add new tickets, edit > ticket, assign tickets to myself… > >

Re: [DISCUSS] changing geode 32-bit counter stats to 64-bit

2019-06-07 Thread Dan Smith
+1 - this sounds like a good change to me. -Dan On Fri, Jun 7, 2019 at 1:47 PM Jacob Barrett wrote: > I like this! > > I’d go ahead and change all the usage of the int methods to the long > methods. I’d deprecate the int methods to make it very clear. > > If some consumer is using the int

Re: [DISCUSS] require reviews before merging a PR

2019-06-06 Thread Dan Smith
> > Would it be possible to allow people who do not have committer status to > request reviewers on a pull request. I'm not sure it's possible to do this with the "reviewers" field - if someone can figure out how to do this with the github IU, we can at least try filing an ticket with apache

Re: [DISCUSS] Criteria for PMC, committers

2019-06-04 Thread Dan Smith
One concern I have about not bundling committer and PMC membership is that there is not much incentive to nominate someone to become a PMC member. When someone is an active contributor but not a committer it's visible in the fact that they have to ask others to merge their PRs, which also provides

Re: [PROPOSAL] Add hostname-for-clients to ConfigurationProperties

2019-06-04 Thread Dan Smith
A user can configure the hostname-for-clients for locators and gateway receivers - they are part of the respective gfsh commands. Are you suggesting deprecating those settings as well, or just having a global property that is the default value if it is not overridden for a specific locator,

Re: Static Analysis Tools such as SonarQube or others?

2019-06-04 Thread Dan Smith
We're currently running PMD as part of the gradle build. PMD is just running a couple of rules specifically to look for mutable statics. We've also enabled integration with lgtm to get a report - https://lgtm.com/projects/g/apache/geode/. I think added

Re: what is the best way to update a geode pull request

2019-05-31 Thread Dan Smith
+1 to pushing PR changes as separate commits. Also +1 to creating PRs with multiple commits where it makes sense. -Dan On Fri, May 31, 2019 at 1:28 PM Owen Nichols wrote: > Personally, I do not force-push to my PRs once any review comments have > been accumulated, for the reasons you mention.

Re: [DISCUSS] require reviews before merging a PR

2019-05-31 Thread Dan Smith
As others pointed out - I think it's really important to remember that people and community are much more important than process. That is a key part of "The Apache Way" - it's not a set very specific rules, but more of a philosophy of building an open community. I think this page has a good take

Re: Permission for wiki

2019-05-28 Thread Dan Smith
Added - you should have access now! Thanks, -Dan On Tue, May 28, 2019 at 3:28 PM Jack Weissburg wrote: > Hello, > > I would like to have permission to edit the wiki: > > https://cwiki.apache.org/confluence/display/GEODE/Guidelines+for+Cluster+Management+service > > Thank you, > > Jack

Re: [DISCUSS] Remove exception.getMessage() error handling

2019-05-24 Thread Dan Smith
I think the right thing to do in those 100+ cases may be different in each case, a blanket search and replace might not be the best idea. -Dan On Fri, May 24, 2019 at 3:05 PM Jinmei Liao wrote: > does exception.toString() print out the entire stack trace? If so, I don't > think we should use

Re: Could you add my username to Geode JIRA

2019-05-23 Thread Dan Smith
Hi Jack, Done! You should have access now. Thanks, -Dan On Thu, May 23, 2019 at 1:18 PM Jack Weissburg wrote: > Hello, > > Could you please add jackw26 to Geode JIRA so that I can be assigned to > tickets. > > Thanks, > > Jack >

Re: Changing external methods to no longer throw UnsupportedOperationException

2019-05-23 Thread Dan Smith
+1 to implementing this method in a minor release. I'm with Jake on this one. Every bug we fix changes the behavior of the product in some small way. This seems like a behavior change for the better - I can't picture a use case where someone is actually *relying* on this method throwing

Re: [DISCUSS] Propose new committer and PMC member - Peter Tran

2019-05-20 Thread Dan Smith
Folks, this thread is dead. Please stop voting here! >From Anthony: Discussions related to committers and PMC members should be held on the private@geode mailing list not the dev@ list. On Mon, May 20, 2019 at 1:43 PM Xiaojian Zhou wrote: > +1 > > On Mon, May 20, 2019 at 11:50 AM Mike Stolz

Re: [DISCUSS] is it time to make Windows tests gating?

2019-05-17 Thread Dan Smith
d since it's just testing test code it seemed reasonable to ignore > it). > > LauncherMemberMXBeanIntegration test still needs some love and I can look > at that since I've worked on it in the past. > > --Jens > > On Fri, May 17, 2019 at 9:33 AM Dan Smith wrote: > > >

Re: [DISCUSS] is it time to make Windows tests gating?

2019-05-17 Thread Dan Smith
Looking at the metrics for the windows jobs, it looks like the windows tests are mostly red due to a few specific tests. The acceptance and gfsh distributed tests jobs seem to be ok, it's just the unit tests and integration tests that have problems. It also looks like ExportConfigCommandTest

Re: Backwards compatibility issue with JSONFormatter

2019-05-14 Thread Dan Smith
ublic API > > was changed? > > > > Well done Gester for finding this!! > > > > --Udo > > > > On 5/14/19 10:40, Dan Smith wrote: > > > I think the changes for GEODE-6327 broke backwards compatibility in > > > JSONFormatter with the change from fromJSON

Backwards compatibility issue with JSONFormatter

2019-05-14 Thread Dan Smith
I think the changes for GEODE-6327 broke backwards compatibility in JSONFormatter with the change from fromJSON(String jsonString) to fromJSON(String jsonString, String... identityFields) Adding an additional varargs parameter to the method breaks code that was compiled against the non-varargs

Re: Permission for working on Jira

2019-05-13 Thread Dan Smith
Hi Geet, Welcome! I think I already gave you access to work with geode JIRAs earlier? I see you listed as having access in JIRA. Is there something you are trying to do that isn't working? -Dan On Mon, May 13, 2019 at 2:23 PM Geetanjali rawat wrote: > Hello Devs > > I would like to request

Re: Request to access Jira

2019-05-03 Thread Dan Smith
You should have access now. Thanks! -Dan On Fri, May 3, 2019 at 1:15 PM Donal Evans wrote: > Hi, > > Could I please be granted access to the Jira for Geode? My username is > DonalEvans, > > Thanks, > Donal >

Re: Pulse - Non-Embedded Mode

2019-05-01 Thread Dan Smith
Option 2 does sound like a good way to go. It does seem like if you are making changes to fix non-embedded mode, you probably need to add an acceptance test for that mode since there is non already, regardless of whether you deprecate non-embedded mode. I have no issues with deprecating either

Re: [VOTE] Apache Geode 1.9.0 RC4

2019-04-23 Thread Dan Smith
+1 Looks good to me. I ran the geode-release-check against the repo. -Dan On Fri, Apr 19, 2019 at 5:00 PM Owen Nichols wrote: > Hello, Geode dev community, > > > This is the fourth release candidate for Apache Geode, version 1.9.0. > > Thanks to all the community members for their

Geode release steps

2019-04-22 Thread Dan Smith
Hi devs, I'm looking at trying to automate some of the geode release steps, but one thing I noticed is that we are inconsistent about when or if we create a release branch in our different repos that we release (geode, geode-examples, geode-native). For geode, we create a branch when we start the

Re: Propose GEODE-6544 fix for release 1.9.0

2019-04-22 Thread Dan Smith
Owen and I talked to Kirk and Aaron. It sounds like this issue does not need to hold up release 1.9.0 because it's been in all previous versions. If we need to create another RC we will get this fix in there. -Dan On Fri, Apr 19, 2019 at 1:50 PM Owen Nichols wrote: > Hi Aaron, Kirk and Geode

Re: GEODE-6630 fix for release 1.9.0

2019-04-18 Thread Dan Smith
+1 - this looks like a good fix to get in if it was introduced in 1.9.0. -Dan On Thu, Apr 18, 2019 at 1:28 PM Eric Shu wrote: > I'd like to include the fix for the NPE. > It is new in 1.9. > > Regards, > Eric >

Re: defunct branches

2019-04-18 Thread Dan Smith
You just need to do git remote prune origin. Git doesn't remove remote branches from your local copy automatically. -Dan On Thu, Apr 18, 2019 at 8:08 AM Bruce Schuchardt wrote: > Sorry to spam everyone. "git branch -r" seems to be a local thing. I > made a fresh clone of the apache repo and

Re: How to publish client stats on server

2019-04-16 Thread Dan Smith
As Anthony pointed out, each member (client, server, locator, etc.) writes it's own statistics to it's own stats file. There is are some server side stats that might have the information you are looking for - see CacheServerStats. That has information about how many operations the server has

Re: [VOTE] Apache Geode 1.9.0 RC3

2019-04-15 Thread Dan Smith
+1 The java bits look good to me. I didn't look too much at geode-native - Maybe someone who knows more about the geode-native codebase can take a look at part? Thanks, -Dan On Mon, Apr 15, 2019 at 3:06 PM Sai Boorlagadda wrote: > Hello, Geode dev community, > > > This is the second release

Re: [VOTE] Apache Geode 1.9.0 RC2

2019-04-15 Thread Dan Smith
Hi Sai, It looks like you left some signing properties in gradle.properties in the source distribution. Building the source distribution is failing with this error to this. Maybe you could make a clean source distribution and re-upload it? 1: Task failed with an exception. --- * What

Re: JIRA and Wiki permissions

2019-04-11 Thread Dan Smith
Hi Alberto, You should have access to both now. Thanks! -Dan On Thu, Apr 11, 2019 at 7:53 AM Alberto Gomez wrote: > Hi, > > > Could you please grant me permissions to edit the wiki and assign JIRA > tickets? > > > My id is alberto.gomez > > > Thanks! > > > Alberto > > >

Re: Fixing Awaitility await().untilAsserted(new WaitCriterion

2019-04-11 Thread Dan Smith
WaitCriterion extends ThrowingRunnable. So this pattern should still work as WaitCriterion did before. But just using an assertion inside of a lambda is the better option. -Dan On Thu, Apr 11, 2019 at 12:02 PM Kirk Lund wrote: > Just a quick heads up... I'm seeing an Awaitility usage pattern

Re: [Geode Build] Are the idea and eclipse plugins being used by anyone?

2019-04-05 Thread Dan Smith
r modify the > currently-used XML files that live inside of the /.idea directory. > > +1 to removal of the idea plugin. > > On Wed, Apr 3, 2019 at 3:22 PM Dan Smith wrote: > > > I was under the impression that intellij's import actually used some of > the > > inf

Re: [Geode Build] Are the idea and eclipse plugins being used by anyone?

2019-04-03 Thread Dan Smith
I was under the impression that intellij's import actually used some of the information in the idea{} blocks in the build. See https://docs.gradle.org/current/userguide/idea_plugin.html. But if the import works well without that extra configuration, I think we should get rid of it. -Dan On Wed,

Re: [DISCUSS] Move or remove org.apache.geode.admin

2019-04-03 Thread Dan Smith
> But this "hidden" feature, what is that? Is this something that we would > like to support or is this something that would be replaced with our > existing efforts in the ConfigurationService and Metrics area. > The old JMX agent [1] was superseded by the newer JMX manager [2] sometime before

[DISCUSS] Move or remove org.apache.geode.admin

2019-04-02 Thread Dan Smith
Hi devs, The org.apache.geode.admin package has been deprecated for about 7 years [1]. I'd like to remove it, or at least move it to a separate module. I actually started some work to move it to a separate module [2]. However in the course of this process, I've found that this module has

Re: Request access to Jira

2019-03-29 Thread Dan Smith
Hi Mario, You should have access to assign geode tickets now. Thanks! -Dan On Fri, Mar 29, 2019 at 1:12 AM Mario Kevo wrote: > Hi all, > > Can you give me access to Jira so I can assigne on tickets? > My Jira Username is 'mkevo'. > > Thanks and BR, > Mario >

Re: Request access to JIRA

2019-03-29 Thread Dan Smith
Hi Mario, You should have access to assign geode tickets now. Thanks! -Dan On Fri, Mar 29, 2019 at 1:29 AM Mario Ivanac wrote: > Hi Geode Dev, > > > Can you give me access to JIRA, so I can assign to tickets. > > My JIRA username is "mivanac". > > > Thanks, > > Mario >

Re: need edit access to ciwiki

2019-03-26 Thread Dan Smith
Hi Bill, You should have access now. -Dan On Tue, Mar 26, 2019 at 3:06 PM Bill Burcham wrote: > I need edit access to https://cwiki.apache.org for: > > bill.burc...@gmail.com > > The immediate need is to update some UML here: > >

  1   2   3   4   5   6   7   >