Re: CODEOWNERS? (was Re: Pending PR reviews)

2022-06-29 Thread Joris Melchior
+1 to Anthony’s suggestion. From: Anthony Baker Date: Wednesday, June 29, 2022 at 12:34 PM To: dev@geode.apache.org Subject: CODEOWNERS? (was Re: Pending PR reviews) ⚠ External Email I realize that this is a thread hijack, but hopefully a useful one. I’ve seen several requests for timely

Re: [PROPOSAL] Relocate Geode Docs from code repo to seperate repo

2022-06-16 Thread Joris Melchior
I like this idea. I agree that changes to documentation are different from changes to code, and documentation should be able to move in a different cadence. Would committers to Geode and Geode-docs be the same after this proposed change? Joris Melchior From: Dave Barnes Date: Tuesday, June

Re: Fw: [DISCUSS] Rebase and Squash Options on Github develop

2021-06-29 Thread Joris Melchior
+1 for Naburan’s proposed options. From: Nabarun Nag Date: Monday, June 28, 2021 at 4:06 PM To: Owen Nichols , dev@geode.apache.org Subject: Re: Fw: [DISCUSS] Rebase and Squash Options on Github develop Just a clarification. The options I am proposing to be kept in the PRs are: * Squash

Re: [ANNOUNCE] New Geode Committer - Kamilla Aslami

2021-04-20 Thread Joris Melchior
Congratulations Kamilla! Joris From: Ernie Burghardt Date: Monday, April 19, 2021 at 5:22 PM To: dev@geode.apache.org Subject: [ANNOUNCE] New Geode Committer - Kamilla Aslami The Apache Geode Project Management Committee has invited Kamilla Aslami to join the Geode as a Committer and we are

Re: [DISCUSS] removal of experimental Protobuf client/server interface

2021-03-30 Thread Joris Melchior
+1 On this approach. If we could somehow have side project to implement this I think it would be really helpful. I also think it's less intimidating to contribute to for a lot of people. Joris On 2021-03-29, 2:55 PM, "John Blum" wrote: How hard is it to put the work like Protobuf in a

Re: [ANNOUNCE] New Geode Committer - Matt Reddington

2021-03-23 Thread Joris Melchior
Welcome Matt! On 2021-03-23, 1:56 PM, "Ernie Burghardt" wrote: The Apache Geode Project Management Committee has invited Matt Reddington to join the Geode as a Committer and we are pleased to announce he has accepted. Please join me in welcoming Mat! Best regards, EB

Re: PROPOSAL: Backport GEODE-9044 - Introduce RedisKey as key object for RedisData entries

2021-03-19 Thread Joris Melchior
+1 On 2021-03-19, 10:35 AM, "Jens Deppe" wrote: This work builds on GEODE-9023 which added sharding support to the compatible with Redis region. This change cleans up data structures and will allow for easier, future rolling upgrades and data migrations if necessary. Thanks

Re: [Proposal] Backport GEODE-9045 to support/1.14

2021-03-17 Thread Joris Melchior
+1 On 2021-03-17, 2:43 PM, "Hale Bales" wrote: Hello, I am putting forward the proposal to backport GEODE-9045 (Rename Redis properties and error messages) to support/1.14 branch, What does GEODE-9045 do? * It renames the redis-port property to

[DISCUSS] - RFC make key and trust stores reload automatically upon change

2021-02-04 Thread Joris Melchior
February 18, 2021. Thanks, Joris Melchior

Re: [DISCUSS] CODEOWNERS and .asf.yml

2021-01-14 Thread Joris Melchior
I’ll give this an informal +1 then. Joris From: Robert Houghton Date: Thursday, January 14, 2021 at 4:40 PM To: dev@geode.apache.org Subject: [DISCUSS] CODEOWNERS and .asf.yml Hello fellow Geode developers. The CODEOWNERS file has been merged to Geode develop for a few days now, and we are

Re: [VOTE] Apache Geode 1.13.1.RC2

2020-11-17 Thread Joris Melchior
+1 Looks good to me. Did a build and gfsh test-drive. From: Dan Smith Date: Monday, November 16, 2020 at 1:29 PM To: dev@geode.apache.org Subject: Re: [VOTE] Apache Geode 1.13.1.RC2 +1 Looks good to me! I ran the geode-release-check against it, looked for binary artifacts, checked the

Re: Apache Geode 1.13.1 patch proposal

2020-11-12 Thread Joris Melchior
+1 From: Dick Cavender Date: Thursday, November 12, 2020 at 2:01 PM To: dev@geode.apache.org Subject: Apache Geode 1.13.1 patch proposal It's been two months since the 1.13.0 release and there have been 28 important fixes on support/1.13 that the community would benefit from. Based on this I'd

Re: [PROPOSAL] Backport fix for GEODE-8620 to 1.13.1

2020-10-21 Thread Joris Melchior
+1 From: Donal Evans Date: Wednesday, October 21, 2020 at 12:00 PM To: dev@geode.apache.org Subject: [PROPOSAL] Backport fix for GEODE-8620 to 1.13.1 Hi Geode dev, I would like to backport the fix for

Re: [PROPOSAL] backport fix for GEODE-8574 to 1.13.1

2020-10-09 Thread Joris Melchior
+1 On 2020-10-08, 10:51 AM, "Jinmei Liao" wrote: I would like to include the fix for GEODE-8574 to 1.13.1, it would greatly help the Geode on k8s experience. Thanks! Jinmei

Re: [PROPOSAL] Backport GEODE-6008 to support 1.12

2020-09-30 Thread Joris Melchior
+1 On 2020-09-29, 6:09 PM, "Xiaojian Zhou" wrote: Hi, GEODE-6008 changed “java.lang.IllegalStateException: NioSslEngine has been closed” to IOException, which enabled DirectChannel to handle it and retry the connection in the case that the connection is closed. This fix is

Re: [DISCUSS] One more 1.13 change

2020-09-28 Thread Joris Melchior
+1 On 2020-09-28, 3:21 PM, "Dan Smith" wrote: Hi, I'd like to backport this change to support/1.13 as well GEODE-8522: Switching exception log back to debug -

Re: [PROPOSAL] Backport usability improvements to support 1.13 branch

2020-09-24 Thread Joris Melchior
+1 On 2020-09-23, 7:23 PM, "Jason Huynh" wrote: Hello, I’d like to merge the pull request:

Re: [PROPOSAL] Backport GEODE-8432 to 1.13

2020-08-20 Thread Joris Melchior
+1 On 2020-08-20, 12:08 PM, "Xiaojian Zhou" wrote: It's using region path instead of getting the region. It should be no risk. On 8/19/20, 10:25 AM, "Xiaojian Zhou" wrote: This problem also exists in 1.13.

Re: [PROPOSAL] Postpone Geode 1.14

2020-07-29 Thread Joris Melchior
+1 On 2020-07-28, 7:34 PM, "Alexander Murmann" wrote: Hi all, As mentioned on the previous discuss thread, I propose to hold off cutting 1.14 until we have shipped 1.13. Once we have shipped 1.13, we should discuss when we want to cut the 1.14 release. The actual ship

Re: [VOTE] change Default branch for geode-examples to 'develop'

2020-07-10 Thread Joris Melchior
+1 On 2020-07-10, 12:39 AM, "Owen Nichols" wrote: A fresh checkout of geode and all but one geode- repos checks out develop as the Default branch. The lone exception is geode-examples. Please vote +1 if you are in favor of changing its Default branch to develop for consistency with

Re: geode docker question

2020-07-08 Thread Joris Melchior
You might also want to look at docker compose so that locator and server can run in separate containers. On 2020-07-08, 12:18 AM, "Mark Hanson" wrote: Here is a command that actually runs.. You need to be in the Geode directory, the run the command below to start everything.

Re: [PROPOSAL]: Backport GEODE-8029 to support/1.12 and support/1.13

2020-07-03 Thread Joris Melchior
+1 On 2020-07-03, 9:06 AM, "Ju@N" wrote: Hello devs, I'd like to propose bringing GEODE-8029 [1] to the support/1.12 and support/1.13 branches. No, you're not having deja vú (neither this is an error within the Matrix): a couple of weeks ago I've backported another fix for

Re: Client Usage of RMI

2020-06-22 Thread Joris Melchior
Pulse communicates to the locator over jmx/rmi as well. From: Kirk Lund Sent: June 19, 2020 14:24 To: dev@geode.apache.org Subject: Re: Client Usage of RMI The only use of RMI in Geode that I'm aware of is: 1) GFSH to Locator communication over jmx/rmi 2)

Re: Refactor to Restore Redundancy Command for 1.13?

2020-06-16 Thread Joris Melchior
Yes, +1 on this change. Joris From: Mark Hanson Sent: June 15, 2020 16:30 To: dev@geode.apache.org Subject: Re: Refactor to Restore Redundancy Command for 1.13? To be clear the code for 1.13 using the Restore Redundancy Command in GFSH is fine as it stands. We

Re: [PROPOSAL]: BackPort GEODE-8029 to support/1.12 and support/1.13

2020-06-10 Thread Joris Melchior
+1 From: Ju@N Sent: June 10, 2020 6:18 To: dev@geode.apache.org Subject: [PROPOSAL]: BackPort GEODE-8029 to support/1.12 and support/1.13 Hello devs, I'd like to propose bringing GEODE-8029 [1] to the *support/1.12* and *support/1.13* branches. The fix has been

Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches

2020-06-03 Thread Joris Melchior
I lean towards forks as well. I understand Naba's concerns but for most of the work we do, forks are a straightforward way to work on contributions to Geode. It's easy to give people rights on your fork if you work with multiple contributors. Joris From: Ernie

Re: [PROPOASAL] backport GEODE-8144

2020-05-28 Thread Joris Melchior
+1 From: Bruce Schuchardt Sent: May 27, 2020 16:35 To: dev@geode.apache.org Subject: [PROPOASAL] backport GEODE-8144 This ticket has two PRs. One passed all normal CI runs but then we hit a faulty test that failed on a Windows machine. There’s a new PR that

Re: [PROPOSAL] Bring GEODE-8100 to support branches

2020-05-20 Thread Joris Melchior
More documentation is good! +1 From: Jinmei Liao Sent: May 19, 2020 14:26 To: geode Subject: [PROPOSAL] Bring GEODE-8100 to support branches This is to update documentation to better explain the Cluster management service and various geode/system properties

Re: [PROPOSAL] bring GEODE-8131 PR to support branches

2020-05-20 Thread Joris Melchior
+1 From: Bruce Schuchardt Sent: May 19, 2020 11:53 To: dev@geode.apache.org Subject: [PROPOSAL] bring GEODE-8131 PR to support branches While investigating a distributed hang we discovered that the alerting system was blocking the logging of critical

Re: [DISCUSS] enable GitHub PR blocking on API breaking changes

2020-05-14 Thread Joris Melchior
This seems like a good thing to have. +1 From: Robert Houghton Sent: May 13, 2020 17:32 To: dev@geode.apache.org ; Mario Ivanac Subject: [DISCUSS] enable GitHub PR blocking on API breaking changes We have enabled this job on the develop and support 1.13

Re: [PROPOSAL] Merge PR 5103 (GEODE-8083) to support/1.13

2020-05-13 Thread Joris Melchior
+1 From: Robert Houghton Sent: May 12, 2020 18:57 To: dev@geode.apache.org ; Dave Barnes (Pivotal) Subject: [PROPOSAL] Merge PR 5103 (GEODE-8083) to support/1.13 This is a squash of GEODE-8083 and 8087, to bring the Java API comparison jobs from Gradle and

Re: Proposal to bring GEODE-8068 to support/1.13

2020-05-11 Thread Joris Melchior
+1 From: Patrick Johnson Sent: May 8, 2020 17:40 To: dev@geode.apache.org Subject: Proposal to bring GEODE-8068 to support/1.13 I’d like to bring GEODE-8068 to support/1.13. This commit reverts two prior commits (GEODE-8033 and GEODE-8044). GEODE-8033 and

Re: Discussion - Change Public API Before Initial Release

2020-05-11 Thread Joris Melchior
+1 From: Jacob Barrett Sent: May 8, 2020 21:26 To: dev@geode.apache.org Subject: Discussion - Change Public API Before Initial Release Hey Ya’ll, We have a new API going into 1.13 that has an inconsistency I want to address before we are stuck with it. The

Re: [DISCUSS] etiquette around breaking the pipeline

2020-04-29 Thread Joris Melchior
Recent experience makes me lean towards quick revert as well. Takes the pressure off when trying to produce a fix and if done soon enough it is usually quite straightforward. From: Owen Nichols Sent: April 29, 2020 7:06 PM To: dev@geode.apache.org Subject:

Re: Reconfiguring our notifications and more

2020-04-21 Thread Joris Melchior
+1 From: Anthony Baker Sent: April 21, 2020 11:54 AM To: dev@geode.apache.org Subject: Reconfiguring our notifications and more I’d like a quick round of feedback so we can stop the dev@ spamming [1]. ASF has implemented a cool way to give projects control of

Re: [PROPOSAL]: GEODE-7940 to support/1.12

2020-04-17 Thread Joris Melchior
[2]: > > https://github.com/apache/geode/commit/bfbb398891c5d96fa3a5975365b29d71bd849ad6 > > -- > Ju@N > -- *Joris Melchior * CF Engineering Pivotal Toronto 416 877 5427 “Programs must be written for people to read, and only incidentally for machines to execute.” – *Hal Abelson* <https://en.wikipedia.org/wiki/Hal_Abelson>

Re: Proposal to bring GEODE-7969 to support/1.12

2020-04-08 Thread Joris Melchior
velop since February via GEODE-7798. > > This fix is critical to avoid false positives in automated vulnerability > scans. > > -Owen -- *Joris Melchior * CF Engineering Pivotal Toronto 416 877 5427 “Programs must be written for people to read, and only incidentally for machines to e

Re: [DISCUSS] Redundancy Gfsh Commands

2020-03-31 Thread Joris Melchior
d from an earlier draft > version that some of you may have seen, so the content may have changed. > > Thanks, > Donal > -- *Joris Melchior * CF Engineering Pivotal Toronto 416 877 5427 “Programs must be written for people to read, and only incidentally for machines to execute.

Re: [DISCUSS] Client side configuration for a SNI proxy

2020-03-19 Thread Joris Melchior
gt; This hopefully addresses some of the concerns with the previous RFC for > this feature. The new proposal is for a more general SocketFactory property > that users can implement, along the lines of what Jake and Owen suggested. > > -Dan > -- *Joris Melchior * CF Engineering Pivotal

Re: Discussion on Deprecation

2020-03-16 Thread Joris Melchior
gt;* {@code > >* Bar bar = Bar(); > >* bar.doSomethingBetter(); > >* bar.doSomethingElse(); > >* } > >*/ > > @Deprecated > > public void doSomethingAndSomethingElse() {} > > } > > > > class Bar { > > public void doSomethingBetter() {} > > public void doSomethingElse() {} > > } > > > > -Jake > > > > > -- *Joris Melchior * CF Engineering Pivotal Toronto 416 877 5427 “Programs must be written for people to read, and only incidentally for machines to execute.” – *Hal Abelson* <https://en.wikipedia.org/wiki/Hal_Abelson>

Re: Discussion on Deprecation

2020-03-16 Thread Joris Melchior
r bar = Bar(); >* bar.doSomethingBetter(); >* bar.doSomethingElse(); >* } >*/ > @Deprecated > public void doSomethingAndSomethingElse() {} > } > > class Bar { > public void doSomethingBetter() {} > public void doSomethingElse() {} > } > >

Re: RFC - Client side configuration for a SNI proxy

2020-03-09 Thread Joris Melchior
o > > On 3/6/20 11:04 AM, Bill Burcham wrote: > > Please review the RFC for *Client side configuration for a SNI proxy*: > > > > > https://cwiki.apache.org/confluence/display/GEODE/Client+side+configuration+for+a+SNI+proxy > > > > Please comment by Monday, March

Re: [PROPOSAL]: Include GEODE-7717 in Release 1.12.0

2020-02-07 Thread Joris Melchior
it in this release, where > most users are just starting to experiment with CMS rest service would be > great. > > [1]: https://issues.apache.org/jira/browse/GEODE-7717 > > https://github.com/apache/geode/commit/bda6bdf50c0a6a3e7cc39fb3ff654a0c26c86d94 > > -- > Cheers

Re: [DISCUSSION] De/un-deprecate IndexType ENUM

2020-01-15 Thread Joris Melchior
Since the feedback has been to proceed with this proposal I will open a JIRA ticket and start the work on this. Thanks for the feedback on this. Joris. On Fri, Jan 3, 2020 at 1:11 PM Kirk Lund wrote: > I'm for un-deprecating it. > > On Fri, Jan 3, 2020 at 7:01 AM Joris Melchior

Re: [DISCUSSION] De/un-deprecate IndexType ENUM

2020-01-03 Thread Joris Melchior
tring-java.lang.String-java.lang.String- > [4] > > https://geode.apache.org/releases/latest/javadoc/org/apache/geode/cache/query/QueryService.html#createIndex-java.lang.String-org.apache.geode.cache.query.IndexType-java.lang.String-java.lang.String-java.lang.String- > [5] > > https://geode.apache.org

Re: [DISCUSSION] De/un-deprecate IndexType ENUM

2020-01-02 Thread Joris Melchior
me why it was originally deprecated or what the intended new direction > (instead of IndexType) was ever going to be. Do you know more about why it > was deprecated or what the devs were going to replace it with? > > On Thu, Jan 2, 2020 at 6:31 AM Joris Melchior > wrote: > > &g

Re: [DISCUSSION] De/un-deprecate IndexType ENUM

2020-01-02 Thread Joris Melchior
ems reasonable to me > > On 12/3/19 10:19 AM, Joris Melchior wrote: > > Ah, that makes sense. I will update! > > > > > > On Tue, Dec 3, 2019 at 12:41 PM Alexander Murmann > > wrote: > > > >> Joris, the "to be reviewed by" field is for a ta

Re: [DISCUSS] Replacing singleton PoolManager

2019-12-06 Thread Joris Melchior
hat Spring Data Geode and friends > had trying to mock Pools and remove the need for those projects to try to > inject mock Pools into a Geode singleton. > > > https://cwiki.apache.org/confluence/display/GEODE/Replace+singleton+PoolManager+with+ClientCache+scoped+service > > T

Re: [DISCUSSION] De/un-deprecate IndexType ENUM

2019-12-03 Thread Joris Melchior
eframe you envision? > > Thanks! > > On Mon, Dec 2, 2019 at 1:41 PM Joris Melchior > wrote: > > > Hi All, > > > > Looking for feedback on the proposal to [un/de]deprecate the IndexType > ENUM > > on Geode. > > > > > https://cwiki.apa

[DISCUSSION] De/un-deprecate IndexType ENUM

2019-12-02 Thread Joris Melchior
Hi All, Looking for feedback on the proposal to [un/de]deprecate the IndexType ENUM on Geode. https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=135863477 Thanks, Joris. -- *Joris Melchior * CF Engineering Pivotal Toronto 416 877 5427 “Programs must be written for people

Re: Certificate Based Authorization

2019-12-02 Thread Joris Melchior
we just take the certificate subject DN instead and provide > it > >> to the security manager for authorization. > >> > >> > >> > >> This wouldn’t lower the level of security (we can have TLS enabled > without > >> access control already), but would provide authentication without the > >> hassle of username and password handling. > >> > >> > >> > >> This is the basic description of the idea. There would be more things to > >> consider, like multi user authentication, but for now we would just > like to > >> get some initial feedback. If it is considered useful, we could get into > >> the details. > >> > >> > >> BR, > >> > >> Mario > >> > >> > > -- *Joris Melchior * CF Engineering Pivotal Toronto 416 877 5427 “Programs must be written for people to read, and only incidentally for machines to execute.” – *Hal Abelson* <https://en.wikipedia.org/wiki/Hal_Abelson>

Re: IndexType deprecation question

2019-12-02 Thread Joris Melchior
ns for the Functional type. Under the covers we create a > > memory-optimized version based on the indexed expression. > > > > Things have changed since deprecation, so maybe it should be > > un/de-deprecated or an alternative solution can probably be t

Re: IndexType deprecation question

2019-12-02 Thread Joris Melchior
unctional index. > > I am not sure if there is an alternative in gfsh... it might still be using > the IndexType enum or something similar. > > > > > On Fri, Nov 29, 2019 at 12:18 PM Joris Melchior > wrote: > > > Thanks John. > > > > I'm trying to use it

Re: IndexType deprecation question

2019-11-29 Thread Joris Melchior
dexType.html > [2] > > https://geode.apache.org/releases/latest/javadoc/org/apache/geode/cache/query/IndexType.html > > > On Fri, Nov 29, 2019 at 8:17 AM Joris Melchior > wrote: > > > Hi All, > > > > I notice that the ENUM > > > > org.apache.g

IndexType deprecation question

2019-11-29 Thread Joris Melchior
) are still valid and I believe we should be able to use them without using deprecated code. Can anyone tell me how this is accomplished? Thanks, Joris. -- *Joris Melchior * CF Engineering Pivotal Toronto 416 877 5427 “Programs must be written for people to read, and only incidentally for machines

Re: [DISCUSS/VOTE] Proposal to bring GEODE-7465 to release/1.11.0

2019-11-26 Thread Joris Melchior
> > WAN/AEQ such as AEQ-pause are increasing user interaction with > > WAN-related > > > gfsh commands. > > > > > > > > The fix is simple, low risk, tested, and has been on develop for 5 > > days: > > > > > > > > > > https://github.com/apache/geode/commit/e148cef9cb63eba283cf86bc490eb280023567ce > > > > > > -- *Joris Melchior * CF Engineering Pivotal Toronto 416 877 5427 “Programs must be written for people to read, and only incidentally for machines to execute.” – *Hal Abelson* <https://en.wikipedia.org/wiki/Hal_Abelson>

Re: [DISCUSS] Move TcpServer and friends to new geode-tcp-server module

2019-11-18 Thread Joris Melchior
group of types, which in > >> turn > >>> are (were) highly-dependent on geode-core. We have been systematically > >>> eliminating dependencies from these types to geode-core as part of > >>> https://issues.apache.org/jira/browse/GEODE-7343 _TcpServer should not > >>>

Re: Proposal to modify Servlet spec support for the HTTP Session Management Module for AppServers

2019-11-16 Thread Joris Melchior
s_notes > >>>>> [4] - https://en.wikipedia.org/wiki/IBM_WebSphere_Application_Server > >>>>> [5] - > >>>>> > >>>>> > >>>> > >>> > >> > https://www.solstice.com/fwd/survival-guide-to-webspheres-an

Re: Jira permission to assign myself

2019-11-01 Thread Joris Melchior
Thanks Dan! On Fri, Nov 1, 2019 at 3:01 PM Dan Smith wrote: > Hi Joris, > > You now also have access. > > Thanks! > -Dan > > On Fri, Nov 1, 2019 at 8:12 AM Joris Melchior > wrote: > > > Hi Dan, > > > > Can you provide me with the ability to as

Re: Jira permission to assign myself

2019-11-01 Thread Joris Melchior
; > > > > > -Dan > > > > > > On Thu, Oct 31, 2019 at 10:09 AM Szu-Yu Lo > > wrote: > > > > > > > Hi, > > > > > > > > I am new to geode and would love to contributed to geode. I am not > > able > > > t

Re: [DISCUSS] Tweak to branch protection rules

2019-10-30 Thread Joris Melchior
pprove minor changes (Fixing merge > > > > > conflicts, spotless, etc.) > > > > > > > > > > If you all agree I'll ask infra to uncheck "Dismiss stale pull > > request > > > > > approvals when new commits are pushed." in our branch protection > > rules. > > > > > > > > > > -Dan > > > > > > > > > > > > > > > > -- > Ju@N > -- *Joris Melchior * CF Engineering Pivotal Toronto 416 877 5427 “Programs must be written for people to read, and only incidentally for machines to execute.” – *Hal Abelson* <https://en.wikipedia.org/wiki/Hal_Abelson>

Re: Deprecate SystemFailure Class

2019-10-29 Thread Joris Melchior
nning > > elimination of usage of it within Geode? > > > > Regards, > > Bill > > > > [1] > > https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-6.html#jvms-6.3 > > [2] oh and here's a ticket > > https://issues.apache.org/jira/browse/GEODE-7369 > > > -- *Joris Melchior * CF Engineering Pivotal Toronto 416 877 5427 “Programs must be written for people to read, and only incidentally for machines to execute.” – *Hal Abelson* <https://en.wikipedia.org/wiki/Hal_Abelson>

Re: [DISCUSS] Blocking merge button in PR

2019-10-21 Thread Joris Melchior
it at least until all CIs are done)*. *I also agree in that that we > should require *at least one* official approval. > Cheers. > -- *Joris Melchior * CF Engineering Pivotal Toronto 416 877 5427 “Programs must be written for people to read, and only incidentally for machines to ex

Re: Token based authentication support added in Geode Develop

2019-10-07 Thread Joris Melchior
ator with this property: > > > > *security-auth-token-enabled-components = all (or management)* > > > > 2. implement your SecurityManager to authenticate the jwt token > passed > > > in. > > > > The jwt token will be available in the propertie

Re: [DISCUSS] RFC - Move membership code to a separate gradle sub-project

2019-09-06 Thread Joris Melchior
s today. We're shooting > for > > >> > closing this RFC this week. > > >> > > > >> > > > >> > On 8/30/19 3:50 PM, Dan Smith wrote: > > >> > > Hi all, > > >> > > > > >> > > We added the following RFC to the wiki about moving Geode's > > membership > > >> > > system to a separate gradle sub-project. Please review and comment > > by > > >> > > 9/6/2019. > > >> > > > > >> > > https://cwiki.apache.org/confluence/x/WRB4Bw > > >> > > > > >> > > Thanks! > > >> > > -Dan > > >> > > > > >> > > > >> > > > > > > -- *Joris Melchior * CF Engineering Pivotal Toronto 416 877 5427 “Programs must be written for people to read, and only incidentally for machines to execute.” – *Hal Abelson* <https://en.wikipedia.org/wiki/Hal_Abelson>

Re: Use of Internal JDK API

2019-08-22 Thread Joris Melchior
gt; The geode-unsafe module compiles with API warnings suppressed. Have fun > compiling without all these warnings filling your screen. > > https://issues.apache.org/jira/browse/GEODE-130 < > https://issues.apache.org/jira/browse/GEODE-130> > > -Jake > > > -- *

Re: edit permissions on wiki

2019-08-07 Thread Joris Melchior
Thanks, all good now! On Fri, Aug 2, 2019 at 4:32 PM Kirk Lund wrote: > Oops. Try now. > > On Fri, Aug 2, 2019 at 12:52 PM Joris Melchior > wrote: > > > Don't seem to have edit permissions yet though ... > > > > On Fri, Aug 2, 2019 at 3:48 PM Joris Melchior

Re: edit permissions on wiki

2019-08-02 Thread Joris Melchior
Don't seem to have edit permissions yet though ... On Fri, Aug 2, 2019 at 3:48 PM Joris Melchior wrote: > Thanks Kirk! > > On Fri, Aug 2, 2019 at 12:16 PM Kirk Lund wrote: > >> You should have permission now. Thanks! >> >> On Fri, Aug 2, 2019 at 7:32 AM Joris

Re: edit permissions on wiki

2019-08-02 Thread Joris Melchior
Thanks Kirk! On Fri, Aug 2, 2019 at 12:16 PM Kirk Lund wrote: > You should have permission now. Thanks! > > On Fri, Aug 2, 2019 at 7:32 AM Joris Melchior > wrote: > > > Hi, > > > > Can someone provide me with edit permissions on the wiki? Specifically >

edit permissions on wiki

2019-08-02 Thread Joris Melchior
Hi, Can someone provide me with edit permissions on the wiki? Specifically the tree starting with this link https://cwiki.apache.org/confluence/display/GEODE/Cluster+Management+Service My user name is 'joris.melchior'. Thanks, -- *Joris Melchior * CF Engineering Pivotal Toronto 416 877 5427

Re: Proposal: For PR reviews and change requests can we have a 7 day turn around on re-reviews?

2019-07-09 Thread Joris Melchior
I have just spent a bit of time reviewing PRs that have been open for a > >>> while and sent some emails to reviewers of the ones that are open the > >>> longest. In my humble opinion, it would be very nice if we could close > >> out > >>> some of the olde

Re: Proposal: For PR reviews and change requests can we have a 7 day turn around on re-reviews?

2019-07-09 Thread Joris Melchior
could close out > some of the older PRs where the requester has made changes to, but > reviewers have not re-reviewed. An ideal norm would seem to be 7 days. One > might notice that I have a PR that I requested a change on, that I have not > provided feedback on, so I am in the same boat..

Re: need access for commit

2019-06-15 Thread Joris Melchior
udhary < aashish.choudha...@gmail.com> wrote: > Hi Team, > > I am interested to work on Geode development, bug fixes etc. Let me know > the process for same. > > > With Best Regards, > Ashish > -- *Joris Melchior * CF Engineering Pivotal Toronto 416 877 5427 “Prog

Re: [DISCUSS] require reviews before merging a PR

2019-06-06 Thread Joris Melchior
> someone can figure out how to do this with the github IU, we can at least > > try filing an ticket with apache infrastructure. > > > > In the meantime, you can also just add a comment mentioning the people > > you'd like to review the request. That works for requ

Re: [DISCUSS] require reviews before merging a PR

2019-06-06 Thread Joris Melchior
s the project's > > > criteria > > > >>> for code quality and test coverage. It also becomes easier to > measure > > > the > > > >>> PRs of a non-committer to determine if we think they would make a > > good > > > >>> committer (fo