[jira] [Assigned] (GEODE-2708) Update Gradle Wrapper to Gradle 3
[ https://issues.apache.org/jira/browse/GEODE-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Bretl reassigned GEODE-2708: - Assignee: Mark Bretl > Update Gradle Wrapper to Gradle 3 > - > > Key: GEODE-2708 > URL: https://issues.apache.org/jira/browse/GEODE-2708 > Project: Geode > Issue Type: Task > Components: build >Reporter: Galen O'Sullivan >Assignee: Mark Bretl > Fix For: 1.2.0 > > > It looks like we're still running on a very old version of Gradle. This may > be related to incremental builds not working properly. > {code} > $ ./gradlew --version > > Gradle 2.14.1 > > Build time: 2016-07-18 06:38:37 UTC > Revision: d9e2113d9fb05a5caabba61798bdb8dfdca83719 > Groovy: 2.4.4 > Ant: Apache Ant(TM) version 1.9.6 compiled on June 29 2015 > JVM: 1.8.0_111 (Oracle Corporation 25.111-b14) > OS: Mac OS X 10.12.3 x86_64 > $ gradle --version > > Gradle 3.4.1 > > Build time: 2017-03-03 19:45:41 UTC > Revision: 9eb76efdd3d034dc506c719dac2955efb5ff9a93 > Groovy: 2.4.7 > Ant: Apache Ant(TM) version 1.9.6 compiled on June 29 2015 > JVM: 1.8.0_111 (Oracle Corporation 25.111-b14) > OS: Mac OS X 10.12.3 x86_64 > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (GEODE-2708) Update Gradle Wrapper to Gradle 3
[ https://issues.apache.org/jira/browse/GEODE-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Bretl resolved GEODE-2708. --- Resolution: Fixed Fix Version/s: 1.2.0 Gradle Wrapper now updated to 3.4.1 > Update Gradle Wrapper to Gradle 3 > - > > Key: GEODE-2708 > URL: https://issues.apache.org/jira/browse/GEODE-2708 > Project: Geode > Issue Type: Task > Components: build >Reporter: Galen O'Sullivan >Assignee: Mark Bretl > Fix For: 1.2.0 > > > It looks like we're still running on a very old version of Gradle. This may > be related to incremental builds not working properly. > {code} > $ ./gradlew --version > > Gradle 2.14.1 > > Build time: 2016-07-18 06:38:37 UTC > Revision: d9e2113d9fb05a5caabba61798bdb8dfdca83719 > Groovy: 2.4.4 > Ant: Apache Ant(TM) version 1.9.6 compiled on June 29 2015 > JVM: 1.8.0_111 (Oracle Corporation 25.111-b14) > OS: Mac OS X 10.12.3 x86_64 > $ gradle --version > > Gradle 3.4.1 > > Build time: 2017-03-03 19:45:41 UTC > Revision: 9eb76efdd3d034dc506c719dac2955efb5ff9a93 > Groovy: 2.4.7 > Ant: Apache Ant(TM) version 1.9.6 compiled on June 29 2015 > JVM: 1.8.0_111 (Oracle Corporation 25.111-b14) > OS: Mac OS X 10.12.3 x86_64 > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2734) Investigate/discuss message encoding
[ https://issues.apache.org/jira/browse/GEODE-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949986#comment-15949986 ] Mark Bretl commented on GEODE-2734: --- This may be only a task to track the overall discussion, however, please remember to have the discuss discussion on the dev mailing list. Thanks, --Mark > Investigate/discuss message encoding > > > Key: GEODE-2734 > URL: https://issues.apache.org/jira/browse/GEODE-2734 > Project: Geode > Issue Type: Sub-task > Components: messaging >Reporter: Brian Baynes > > Out of all the great ways to encode messages (Thrift, Protobuf, etc), which > should we use here? Let's discuss and come to consensus. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2738) There are many typos throughout the codebase.
[ https://issues.apache.org/jira/browse/GEODE-2738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949979#comment-15949979 ] Mark Bretl commented on GEODE-2738: --- [~prhomberg] This is a vague subject and hard to determine the scope of the changes. Are you able to narrow the issue? > There are many typos throughout the codebase. > - > > Key: GEODE-2738 > URL: https://issues.apache.org/jira/browse/GEODE-2738 > Project: Geode > Issue Type: Bug >Reporter: Patrick Rhomberg >Assignee: Patrick Rhomberg >Priority: Trivial > > The most pervasive that I've noticed is that "occurred" is spelled with only > one R. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2715) Move Pulse to its own repo
[ https://issues.apache.org/jira/browse/GEODE-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941152#comment-15941152 ] Mark Bretl commented on GEODE-2715: --- This should be discussed on the dev list before any other actions take place > Move Pulse to its own repo > -- > > Key: GEODE-2715 > URL: https://issues.apache.org/jira/browse/GEODE-2715 > Project: Geode > Issue Type: Improvement > Components: pulse >Reporter: Swapnil Bawaskar > > Pulse should be moved to a separate repository so that it can be > independently released. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2232) Rename GemFireConfigException
[ https://issues.apache.org/jira/browse/GEODE-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15768352#comment-15768352 ] Mark Bretl commented on GEODE-2232: --- I would vote for removing product names from class names as well. I think the addition of product names came from the history and the 'sharing' of code between products. This seems to be a bigger topic and should be discussed on the dev list. > Rename GemFireConfigException > - > > Key: GEODE-2232 > URL: https://issues.apache.org/jira/browse/GEODE-2232 > Project: Geode > Issue Type: Improvement > Components: docs, general >Reporter: Dor >Assignee: Bruce Schuchardt > Fix For: 1.1.0 > > > All GemFire*Exception classes should be refactor renamed to have Geode as a > prefix instead. > For example: >GemFireConfigException - Should be GeodeConfigException. >GemFireException Should be GeodeException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (GEODE-165) Add build support for generating antlr classes from grammar
[ https://issues.apache.org/jira/browse/GEODE-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Bretl updated GEODE-165: - Assignee: Avinash Dongre (was: Mark Bretl) > Add build support for generating antlr classes from grammar > --- > > Key: GEODE-165 > URL: https://issues.apache.org/jira/browse/GEODE-165 > Project: Geode > Issue Type: Bug > Components: build >Reporter: Dan Smith >Assignee: Avinash Dongre > > The OQL engine currently uses antlr to generate some parsing classes from > gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/parse/oql.g > These are the generated classes. They are currently checked into the source. > OQLLexer.java > OQLLexerTokenTypes.java > OQLLexerTokenTypes.txt > OQLParser.java > They can be generated manually by running antlr.Tool on the provided grammar. > cd gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/parse/ > java -cp antlr.jar antlr.Tool oql.g > We should add support to the gradle build to generate these classes. > In my opinion we should also remove the checked in classes. With gradle we > can configure things so that the gradle eclipse target will generate these > classes and make them available to the IDE as well. Look at > gemfire-core/build.gradle for how we do this with the version properties file: > sourceSets { > main { > output.dir(generatedResources, builtBy: 'createVersionPropertiesFile') > } > } -- This message was sent by Atlassian JIRA (v6.3.4#6332)