GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode-examples/pull/14
GEODE-3440: Add example for function execution.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PivotalSarge/geode-examples feature
GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode-examples/pull/13
GEODE-3428: Add example of putting multiple values all at once.
Add an example of `Region.putAll()`.
You can merge this pull request into a Git repository by running:
$ git pull
Github user PivotalSarge closed the pull request at:
https://github.com/apache/geode-examples/pull/12
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode-examples/pull/12
Add OQL example
Perry Birch and I paired on an example for OQL. To prepare for that, I also
created an example for Region.putAll().
You can merge this pull request into a Git
Github user PivotalSarge commented on the issue:
https://github.com/apache/geode-native/pull/74
To quote Montgomery Scott, "I did what I could, Captain!"
> On 4 Apr, 2017, at 11:40, Ernie Burghardt <notificati...@github.com>
wrote:
>
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/82#discussion_r109194938
--- Diff:
src/cppcache/integration-test/testThinClientPoolExecuteFunctionThrowsException.cpp
---
@@ -0,0 +1,362 @@
+/*
+ * Licensed
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/81#discussion_r108795285
--- Diff: BUILDING.md ---
@@ -39,6 +39,9 @@ Building requires access to an installation of Geode. By
default the value of `G
## Installing
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/77#discussion_r108702132
--- Diff:
docs/geode-native-docs/client-cache/application-plugins.html.md.erb ---
@@ -262,7 +261,7 @@ void removeListener(RegionPtr& re
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/77#discussion_r108701675
--- Diff:
docs/geode-native-docs/cache-init-file/chapter-overview.html.md.erb ---
@@ -33,26 +33,23 @@ The initialization file can have any name
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/75#discussion_r108524165
--- Diff:
docs/geode-native-book/master_middleman/source/subnavs/geode-nc-nav.erb ---
@@ -439,7 +439,7 @@ limitations under the License
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/75#discussion_r108500455
--- Diff:
docs/geode-native-book/master_middleman/source/subnavs/geode-nc-nav.erb ---
@@ -473,7 +473,7 @@ limitations under the License
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/75#discussion_r108496561
--- Diff:
docs/geode-native-docs/dotnet-caching-api/implementing-igfserializable.html.md.erb
---
@@ -31,21 +31,21 @@ Examples follow
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/74#discussion_r107995262
--- Diff: src/cppcache/src/ThinClientRegion.hpp ---
@@ -416,14 +416,21 @@ class ChunkedFunctionExecutionResponse : public
TcrChunkedResult
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/74#discussion_r107993045
--- Diff: src/cppcache/src/ThinClientRegion.hpp ---
@@ -416,14 +416,21 @@ class ChunkedFunctionExecutionResponse : public
TcrChunkedResult
GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode-native/pull/74
GEODE-2713: Wrap result collector lock in shared_ptr.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PivotalSarge/geode-native
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/73#discussion_r107939092
--- Diff:
docs/geode-native-book/master_middleman/source/subnavs/geode-nc-nav.erb ---
@@ -20,26 +20,26 @@ limitations under the License
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106922752
--- Diff: src/clicache/src/CacheFactory.cpp ---
@@ -84,6 +85,12 @@ namespace Apache
//TODO::split
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/59#discussion_r106483611
--- Diff:
docs/geode-native-docs/function-execution/handling-function-results.html.md.erb
---
@@ -19,7 +19,7 @@ See the License for the specific
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/50#discussion_r105266335
--- Diff: src/quickstart/cpp/PdxSerializer.cpp ---
@@ -165,15 +165,15 @@ int main(int argc, char** argv) {
LOGINFO("Registered P
GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode-native/pull/50
GEODE-2636: Switch to CMake variable for library name.
- Parameterize the name of the library for which the quickstarts look.
- Fix warnings that obfuscate when the quickstarts can
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/48#discussion_r104836958
--- Diff: src/cppcache/include/geode/DataOutput.hpp ---
@@ -378,9 +378,8 @@ class CPPCACHE_EXPORT DataOutput {
*/
inline void
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/48#discussion_r104769132
--- Diff: src/cppcache/test/DataOutputTest.cpp ---
@@ -305,15 +305,9 @@ TEST_F(DataOutputTest, TestCursorAdvance
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/48#discussion_r104768886
--- Diff: src/cppcache/include/geode/DataOutput.hpp ---
@@ -378,9 +378,8 @@ class CPPCACHE_EXPORT DataOutput {
*/
inline void
GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode-native/pull/48
GEODE-2578: Remove 64 KiB limit on query strings.
- Remove artificial cap of 65535 for query string
length by using 32 bits for the length of query
strings in DataOutput
Github user PivotalSarge commented on the issue:
https://github.com/apache/geode-native/pull/44
Roger that. Expect a new PR forthwith...
Sarge
> On 7 Mar, 2017, at 08:10, Jacob Barrett <notificati...@github.com> wrote:
>
> @PivotalSarge <
Github user PivotalSarge closed the pull request at:
https://github.com/apache/geode-native/pull/44
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user PivotalSarge commented on the issue:
https://github.com/apache/geode-native/pull/44
The unit tests failed on Linux but not other platforms. It turns out that
DataOutput has some not-very-obvious (and apparently platform-specific)
behavior around buffer management
GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode-native/pull/44
GEODE-2578: Remove 64 KiB limit on query strings.
- Remove artificial cap of 65535 for query string
length by using 32 bits for the length of query
strings in DataOutput
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103281152
--- Diff: src/tests/cpp/security/Security.cpp ---
@@ -41,16 +41,18 @@
#include "security/CredentialGenerator.hpp"
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103280043
--- Diff: src/cppcache/src/LRUEntriesMap.cpp ---
@@ -297,7 +295,7 @@ GfErrType LRUEntriesMap::put(const CacheableKeyPtr&
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103280113
--- Diff: src/cppcache/src/LRUEntriesMap.cpp ---
@@ -20,6 +20,9 @@
#include "MapSegment.hpp"
#include "CacheImpl.hpp"
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103279753
--- Diff: src/cppcache/src/MapSegment.hpp ---
@@ -164,9 +166,9 @@ class CPPCACHE_EXPORT MapSegment {
m_entryFactory->newMapEntry(
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103279475
--- Diff: src/cppcache/src/MapSegment.cpp ---
@@ -316,16 +320,16 @@ GfErrType MapSegment::remove(const CacheableKeyPtr&
key, Cacheabl
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103278690
--- Diff: src/cppcache/src/LRUList.cpp ---
@@ -15,12 +15,18 @@
* limitations under the License.
*/
#include "LRULis
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103279163
--- Diff: src/cppcache/src/LRUList.hpp ---
@@ -20,32 +20,32 @@
* limitations under the License.
*/
+#include
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/37#discussion_r103255168
--- Diff: src/cppcache/include/geode/SharedBase.hpp ---
@@ -56,11 +57,12 @@ class CPPCACHE_EXPORT SharedBase {
protected:
inline
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/37#discussion_r103254380
--- Diff: src/cppcache/include/geode/CacheStatistics.hpp ---
@@ -102,8 +102,8 @@ class CPPCACHE_EXPORT CacheStatistics : public
SharedBase
Github user PivotalSarge commented on the issue:
https://github.com/apache/geode-native/pull/39
Where is .ratignore? I don't see it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode-native/pull/29
GEODE-2480: Correct the version of CMake.
- Modify BUILDING.md to correct the typo in the version of CMake.
You can merge this pull request into a Git repository by running:
$ git
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/25#discussion_r102769835
--- Diff: src/xsds/gfcpp-cache-9.0.xsd ---
@@ -33,7 +33,7 @@ limitations under the License.
version="9.0">
Github user PivotalSarge commented on the issue:
https://github.com/apache/geode-native/pull/23
Good idea. I think you're right about redundancies. I'll look into that.
Sarge
> On 22 Feb, 2017, at 10:48, Jacob Barrett <notificati...@github.com&
GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode-native/pull/23
GEODE-2478: Replace gf with geode.
- Rename directories and files with gf into their name to
instead use geode and update all references thereto.
- Ensure formatting style guide
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/13#discussion_r101796694
--- Diff: src/CMakeLists.txt ---
@@ -224,7 +222,7 @@ add_subdirectory(cppcache)
add_subdirectory(cryptoimpl)
add_subdirectory(dhimpl
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/13#discussion_r101796329
--- Diff: src/cppcache/include/geode/AttributesFactory.hpp ---
@@ -20,7 +20,7 @@
* limitations under the License
GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode-native/pull/13
GEODE-2476: Replace gfcpp with geode.
- Rename directories and files with gfcpp into their name to
instead use geode and update all references thereto.
- Rename the gfcpp
GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode-native/pull/10
Fix build on Windows.
There was a lingering reference to one of the example files,
ComplexNumber.cs, in the CLI tests. Restoring that file to a different location
was insufficient
Github user PivotalSarge commented on the issue:
https://github.com/apache/geode-native/pull/2
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user PivotalSarge commented on the issue:
https://github.com/apache/geode-native/pull/7
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user PivotalSarge commented on the issue:
https://github.com/apache/geode-native/pull/9
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode-native/pull/8
GEODE-2376: Remove low-value comments from ThinClientPoolDM.cpp.
- Remove the stack trace comment.
- Remove commented-out code that already exists in the history
of the file
GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode-native/pull/5
GEODE-2462: Remove examples directory.
Remove the examples directory as it does not contain any examples that are
not already covered in src/quickstart.
You can merge this pull request
GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode-native/pull/4
GEODE-2446: Remove cclient directory.
Remove the cclient directory which contains obsolete code.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user PivotalSarge commented on the issue:
https://github.com/apache/geode/pull/387
This closes #387.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user PivotalSarge closed the pull request at:
https://github.com/apache/geode/pull/387
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user PivotalSarge commented on the issue:
https://github.com/apache/geode/pull/389
I pulled this PR, built it on Windows, and ran the quick integration tests.
This validates that the header addition has not broken the Visual Studio
project files.
---
If your project is set
Github user PivotalSarge commented on the issue:
https://github.com/apache/geode/pull/391
Done. GEODE-2348
> On 6 Feb, 2017, at 14:29, Michael Martell <notificati...@github.com>
wrote:
>
> Good catch that must not be used. So we should remove it. Pleas
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode/pull/394#discussion_r99872593
--- Diff: .travis.yml ---
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements
Github user PivotalSarge commented on the issue:
https://github.com/apache/geode/pull/387
They've been googlified.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode/pull/387
GEODE-2411: Remove references to Gemfire from include guards
In the process of replacing references to Gemfire with references to Apache
Geode in the include guards, standardize the include
Github user PivotalSarge closed the pull request at:
https://github.com/apache/geode/pull/376
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user PivotalSarge commented on the issue:
https://github.com/apache/geode/pull/376
It's just an integer literal value for a static constant variable called
ordinal. Are you think along the lines of the remove #define statements? Is
your concern determining which version
GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode/pull/376
GEODE-2344: Updated the ordinal to match 9.0.
- Switch to the correct constructor to avoid errors.
- Remove unnecessary mechanism to modify version ordinal.
- Remove commented-out code
Github user PivotalSarge commented on the issue:
https://github.com/apache/geode/pull/344
Elegant. Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user PivotalSarge reopened a pull request:
https://github.com/apache/geode/pull/341
GEODE-2306: Update native client BUILDING.md to reflect changes for Geode
- Replaced GEMFIRE_HOME with GEODE_ROOT.
- Corrected build instructions.
- Minor copy-editing.
You can merge
Github user PivotalSarge commented on the issue:
https://github.com/apache/geode/pull/341
Mark Doxygen as required and fix typo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user PivotalSarge closed the pull request at:
https://github.com/apache/geode/pull/341
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode/pull/341
GEODE-2306: Update native client BUILDING.md to reflect changes for Geode
- Replaced GEMFIRE_HOME with GEODE_ROOT.
- Corrected build instructions.
- Minor copy-editing.
You can merge
67 matches
Mail list logo
