[GitHub] geode pull request #751: GEODE-2719 : Deprecated setTotalMaxMemory and getTo...

2017-08-31 Thread ameybarve15
GitHub user ameybarve15 opened a pull request: https://github.com/apache/geode/pull/751 GEODE-2719 : Deprecated setTotalMaxMemory and getTotalMaxMemory and updated their javadocs. Thank you for submitting a contribution to Apache Geode. In order to streamline the review

[GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...

2017-08-11 Thread ameybarve15
Github user ameybarve15 commented on a diff in the pull request: https://github.com/apache/geode/pull/609#discussion_r132678804 --- Diff: geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java --- @@ -331,6 +331,29 @@ public void

[GitHub] geode issue #609: GEODE-2886 : sent IllegalStateException instead of throwin...

2017-08-10 Thread ameybarve15
Github user ameybarve15 commented on the issue: https://github.com/apache/geode/pull/609 @upthewaterspout , @jhuynh1 I have updated PR, please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...

2017-08-02 Thread ameybarve15
Github user ameybarve15 commented on a diff in the pull request: https://github.com/apache/geode/pull/609#discussion_r131056489 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java --- @@ -85,8 +72,10 @@ public void

[GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...

2017-07-25 Thread ameybarve15
Github user ameybarve15 commented on a diff in the pull request: https://github.com/apache/geode/pull/609#discussion_r129480518 --- Diff: geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java --- @@ -290,6 +295,24 @@ public void

[GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...

2017-06-28 Thread ameybarve15
GitHub user ameybarve15 opened a pull request: https://github.com/apache/geode/pull/609 GEODE-2886 : sent IllegalStateException instead of throwing IllegalArgumentException inside WaitUntilFlushedFunction 1. sent IllegalStateException instead of throwing IllegalArgumentException

[GitHub] geode pull request #595: GEODE-3104 : Modified code to use --include-locator...

2017-06-21 Thread ameybarve15
GitHub user ameybarve15 opened a pull request: https://github.com/apache/geode/pull/595 GEODE-3104 : Modified code to use --include-locators instead of existing --shutdown-locators option in shutdown command. GEODE-3104 : Modified code to use --include-locators instead of existing

[GitHub] geode issue #568: GEODE-290 : Removed deprecated method stopWithPort from Lo...

2017-06-08 Thread ameybarve15
Github user ameybarve15 commented on the issue: https://github.com/apache/geode/pull/568 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] geode issue #515: GEODE-240: Remove deprecated methods on TransactionEvent

2017-05-22 Thread ameybarve15
Github user ameybarve15 commented on the issue: https://github.com/apache/geode/pull/515 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] geode issue #507: GEODE-231 : Remove deprecated AttributesMutator.setCacheLi...

2017-05-22 Thread ameybarve15
Github user ameybarve15 commented on the issue: https://github.com/apache/geode/pull/507 +1 Looks good , only fix conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] geode pull request #505: [GEODE-2890]: Corrected debug log location in Abstr...

2017-05-10 Thread ameybarve15
GitHub user ameybarve15 opened a pull request: https://github.com/apache/geode/pull/505 [GEODE-2890]: Corrected debug log location in AbstractGatewaySenderEventProcessor.processQueue(). Corrected debug log location in AbstractGatewaySenderEventProcessor.processQueue(). You can

[GitHub] geode-native issue #90: GEODE-2763: Remove of nonSingleHopsCount stat in cli...

2017-04-21 Thread ameybarve15
Github user ameybarve15 commented on the issue: https://github.com/apache/geode-native/pull/90 Ok, but for this branch I have already merged develop, Let me know If you can merge this request in this state or else I will create a new branch again and follow the entire procedure again

[GitHub] geode-native issue #90: GEODE-2763: Remove of nonSingleHopsCount stat in cli...

2017-04-20 Thread ameybarve15
Github user ameybarve15 commented on the issue: https://github.com/apache/geode-native/pull/90 Hi @echobravopapa , and @PivotalSarge Thanks for your review. I am trying to merge my pull request but get this error. >~/source/open/t/geode-native (develop) $ git fe

[GitHub] geode-native issue #90: GEODE-2763: Remove of nonSingleHopsCount stat in cli...

2017-04-17 Thread ameybarve15
Github user ameybarve15 commented on the issue: https://github.com/apache/geode-native/pull/90 @echobravopapa I am following https://cwiki.apache.org/confluence/display/GEODE/Code+contributions I can squash commits post pull request is approved. --- If your project is set up

[GitHub] geode-native pull request #90: GEODE-2763: Remove of nonSingleHopsCount stat...

2017-04-13 Thread ameybarve15
GitHub user ameybarve15 opened a pull request: https://github.com/apache/geode-native/pull/90 GEODE-2763: Remove of nonSingleHopsCount stat in client GEODE-2763: Remove of nonSingleHopsCount stat in client from 1. source 2. cpp and csharp unit tests and 3

[GitHub] geode pull request #332: GEODE-2049: Replaced unit of measure for all of the...

2017-01-09 Thread ameybarve15
GitHub user ameybarve15 opened a pull request: https://github.com/apache/geode/pull/332 GEODE-2049: Replaced unit of measure for all of the tcpfinalCheck statistics from currently "nanoseconds" to be "messages". You can merge this pull request into a Git r

[GitHub] geode issue #323: GEODE-1754: Cleaned up loadSharedConfigFromDir argument fr...

2017-01-04 Thread ameybarve15
Github user ameybarve15 commented on the issue: https://github.com/apache/geode/pull/323 These changes have been merged in commit id: c33ce7db8148fe0b300066581f26582e3e044e96 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] geode pull request #323: GEODE-1754: Cleaned up loadSharedConfigFromDir argu...

2017-01-04 Thread ameybarve15
Github user ameybarve15 closed the pull request at: https://github.com/apache/geode/pull/323 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode issue #323: GEODE-1754: Cleaned up loadSharedConfigFromDir argument fr...

2017-01-04 Thread ameybarve15
Github user ameybarve15 commented on the issue: https://github.com/apache/geode/pull/323 These changes have been merged in commit id: c33ce7db8148fe0b300066581f26582e3e044e96 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] geode pull request #314: GEODE-789: Added 'create defined indexes', 'clear d...

2016-12-15 Thread ameybarve15
Github user ameybarve15 closed the pull request at: https://github.com/apache/geode/pull/314 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode issue #304: GEODE-1835: A message logged by the configure pdx command ...

2016-12-06 Thread ameybarve15
Github user ameybarve15 commented on the issue: https://github.com/apache/geode/pull/304 Is this PR ready for commit? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-geode pull request #292: [GEODE-1509] Fixed : Reduce the memory us...

2016-11-20 Thread ameybarve15
GitHub user ameybarve15 opened a pull request: https://github.com/apache/incubator-geode/pull/292 [GEODE-1509] Fixed : Reduce the memory usage of GatewayEventCallbackArgument You can merge this pull request into a Git repository by running: $ git pull https://github.com