[GitHub] geode issue #749: GEODE-3502: Added awaitility clauses.

2017-08-29 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/749 @ladyVader @jhuynh1 @upthewaterspout @boglesby -- Potential reviewers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode pull request #749: GEODE-3502: Added awaitility clauses.

2017-08-29 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/749 GEODE-3502: Added awaitility clauses. * Added awaitility clauses while waiting for the stat comparison checks * Replaced the deprecated Wait Criterion with Awaitility clause

[GitHub] geode pull request #743: GEODE-3131: Increasing the time

2017-08-24 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/743 GEODE-3131: Increasing the time * Increasing the time elapsed before the dispatchers are started. * All validations must be done before the dispatcher start dispatching. Thank

[GitHub] geode pull request #732: GEODE-3276: Managing race conditions while the send...

2017-08-22 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/732 GEODE-3276: Managing race conditions while the senders are stopped * When a connection is initialized, a readAckThread may be alive from a previous incarnation. * This AckThread

[GitHub] geode pull request #659: GEODE-3308: Lucene rolling upgrade and backwards co...

2017-08-22 Thread nabarunnag
Github user nabarunnag closed the pull request at: https://github.com/apache/geode/pull/659 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode issue #681: Lucene refactoring and clean up

2017-08-02 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/681 Potential reviewers @ladyVader @jhuynh1 @boglesby @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] geode pull request #681: Lucene refactoring and clean up

2017-08-02 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/681 Lucene refactoring and clean up Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps

[GitHub] geode pull request #678: GEODE-3384: Javadoc change for PageableLuceneQueryR...

2017-08-02 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/678 GEODE-3384: Javadoc change for PageableLuceneQueryResults * Javadocs now mention that PageableLuceneQueryResults are serializable and can be sent to other members Thank you

[GitHub] geode pull request #674: GEODE-3380: There're 2 problems here

2017-08-01 Thread nabarunnag
Github user nabarunnag commented on a diff in the pull request: https://github.com/apache/geode/pull/674#discussion_r130654524 --- Diff: geode-cq/src/test/java/org/apache/geode/internal/cache/PutAllCSDUnitTest.java --- @@ -500,6 +502,81 @@ public void run2() throws CacheException

[GitHub] geode pull request #659: GEODE-3308: Lucene rolling upgrade and backwards co...

2017-07-26 Thread nabarunnag
Github user nabarunnag commented on a diff in the pull request: https://github.com/apache/geode/pull/659#discussion_r129679647 --- Diff: geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneSearchWithRollingUpgradeDUnit.java --- @@ -0,0 +1,1044

[GitHub] geode issue #659: GEODE-3308: Lucene rolling upgrade and backwards compatibi...

2017-07-26 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/659 * These tests were ported from RollingUpgradeDUnitTest and RollingUpgrade2DUnitTest * Instead of put and get verification, it is now lucent query result size verification Potential

[GitHub] geode pull request #659: GEODE-3308: Lucene rolling upgrade and backwards co...

2017-07-26 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/659 GEODE-3308: Lucene rolling upgrade and backwards compatibility tests … …added Thank you for submitting a contribution to Apache Geode. In order to streamline the review

[GitHub] geode issue #628: GEODE-3131: Replaced Thread.sleep

2017-07-12 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/628 Thank you @ladyVader . Fixed the typo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] geode issue #628: GEODE-3131: Replaced Thread.sleep

2017-07-12 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/628 Potential Reviewers: @ladyVader @boglesby @jhuynh1 @upthewaterspout @gesterzhou @DivineEnder --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] geode pull request #628: GEODE-3131: Replaced Thread.sleep

2017-07-12 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/628 GEODE-3131: Replaced Thread.sleep * Replaced sleeps with an Awaitility clause which waits for the region sizes to be correct before starting validation. Thank you for submitting

[GitHub] geode issue #625: GEODE-1988: Increased the readTimeout

2017-07-11 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/625 Potential reviewers @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] geode issue #622: GEODE-1731: Modifying region size check to be more accurat...

2017-07-11 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/622 Merging into develop --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] geode issue #588: GEODE-2820: Added awaitlity clause to wait for the region ...

2017-06-20 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/588 @jhuynh1 Changed the validation checks to verify that the size of the indexes are correct. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] geode pull request #588: GEODE-2820: Added awaitlity clause to wait for the ...

2017-06-16 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/588 GEODE-2820: Added awaitlity clause to wait for the region size to be … …correct * Added awaitility clause to wait for all the regions to have all the entries

[GitHub] geode issue #574: GEODE-3066: Test tweaks to stabilize it.

2017-06-12 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/574 @jhuynh1 , Last when we experimented with this function in WANTestBase tests, the listener is destroyed once the vm is closed, which I believe that happens at the end of each test. --- If your

[GitHub] geode pull request #574: GEODE-3066: Test tweaks to stabilize it.

2017-06-12 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/574 GEODE-3066: Test tweaks to stabilize it. * Regions created before senders and receivers are started. * Added a listener to slow down the puts so that when the remote region

[GitHub] geode issue #562: GEODE-3025: GET operation before Lucene query

2017-06-09 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/562 @ladyVader @upthewaterspout @boglesby @gesterzhou -- Adding more potential reviewers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] geode pull request #562: GEODE-3025: GET operation before Lucene query

2017-06-05 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/562 GEODE-3025: GET operation before Lucene query * To allow Lucene queries in single hop with transaction enabled mode, the client must get the metadata about the regions. * A Get

[GitHub] geode issue #547: GEODE-2957: Create Lucene index analyzer help updated to i...

2017-05-30 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/547 I will be merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] geode issue #543: GEODE-2957 gfsh create lucene index "null" becomes "DEFAUL...

2017-05-30 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/543 I will be merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] geode issue #541: GEODE-2960 : Trim field parameter values from create lucen...

2017-05-30 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/541 Working on merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] geode issue #523: GEODE-2967: ResultCollection instead of StructCollection

2017-05-23 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/523 @DivineEnder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] geode pull request #523: GEODE-2967: ResultCollection instead of StructColle...

2017-05-23 Thread nabarunnag
Github user nabarunnag closed the pull request at: https://github.com/apache/geode/pull/523 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode issue #526: GEODE-269 : Removing deprecated API's from FunctionService...

2017-05-22 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/526 Working on merging this change --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] geode issue #523: GEODE-2967: ResultCollection instead of StructCollection

2017-05-22 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/523 Potential reviewers @jhuynh1 @ladyVader @boglesby @gesterzhou @upthewaterspout --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] geode pull request #523: GEODE-2967: ResultCollection instead of StructColle...

2017-05-22 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/523 GEODE-2967: ResultCollection instead of StructCollection * If we have one runtime iterator which is in case of self joins, ResultSet or ResultBags are created * Otherwise StructBag

[GitHub] geode issue #517: GEODE-2587: Refactored the OrderByComparator's compare met...

2017-05-17 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/517 Yes, we are opening a new ticket for eliminating the repeated code. Analyzing the testcode for ORDER BY queries. --- If your project is set up for it, you can reply to this email and have your

[GitHub] geode issue #517: GEODE-2587: Refactored the OrderByComparator's compare met...

2017-05-17 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/517 @ladyVader I am assuming that there should be tests already present testing the functional aspect. One of the tests did fail and caught an issue in my fix. @jhuynh1 what do you think

[GitHub] geode issue #517: GEODE-2587: Refactored the OrderByComparator's compare met...

2017-05-17 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/517 Potential Reviewers @ladyVader @jhuynh1 @boglesby @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] geode pull request #517: GEODE-2587: Refactored the OrderByComparator's comp...

2017-05-17 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/517 GEODE-2587: Refactored the OrderByComparator's compare method Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you

[GitHub] geode pull request #516: GEODE-2587: Refactored the OrderByComparator's comp...

2017-05-17 Thread nabarunnag
Github user nabarunnag closed the pull request at: https://github.com/apache/geode/pull/516 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode pull request #516: GEODE-2587: Refactored the OrderByComparator's comp...

2017-05-17 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/516 GEODE-2587: Refactored the OrderByComparator's compare method Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you

[GitHub] geode pull request #514: GEODE-2905: Added extra logging to determine the ca...

2017-05-14 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/514 GEODE-2905: Added extra logging to determine the cause of failure. * Replaced assertTrue with assertEquals so that the commandResult is displayed in case of an error. Thank you

[GitHub] geode issue #512: GEODE-2637: Refactored LuceneQueryFactory.setResultLimit()

2017-05-12 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/512 Potential reviewers @ladyVader @upthewaterspout @jhuynh1 @boglesby @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] geode pull request #512: GEODE-2637: Refactored LuceneQueryFactory.setResult...

2017-05-12 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/512 GEODE-2637: Refactored LuceneQueryFactory.setResultLimit() * Renamed LuceneQueryFactory.getResult to setLimit() * This is done to match the cwiki documents Thank you

[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...

2017-05-09 Thread nabarunnag
Github user nabarunnag commented on a diff in the pull request: https://github.com/apache/geode/pull/503#discussion_r115629507 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneResultStruct.java --- @@ -39,6 +41,8 @@ * Return score the score

[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...

2017-05-09 Thread nabarunnag
Github user nabarunnag commented on a diff in the pull request: https://github.com/apache/geode/pull/503#discussion_r115629448 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneIndex.java --- @@ -19,39 +19,62 @@ import

[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...

2017-05-09 Thread nabarunnag
Github user nabarunnag commented on a diff in the pull request: https://github.com/apache/geode/pull/503#discussion_r115629459 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQuery.java --- @@ -37,21 +42,38 @@ * Results are returned in order

[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...

2017-05-09 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/503 GEODE-2907: Removed @Experimental tag from the Lucene module * Removed the @experimental tag fromt the files in Lucene module. * Improve on the javadocs for the interfaces present

[GitHub] geode pull request #492: GEODE-2754: Changed the name of unknown host

2017-05-08 Thread nabarunnag
Github user nabarunnag closed the pull request at: https://github.com/apache/geode/pull/492 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode pull request #498: GEODE-2881: Wait for waitForFlushBeforeExecuteTextS...

2017-05-08 Thread nabarunnag
Github user nabarunnag closed the pull request at: https://github.com/apache/geode/pull/498 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode pull request #499: GEODE-2879: Shutdown() called from close() in Loner...

2017-05-08 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/499 GEODE-2879: Shutdown() called from close() in LonerDistributionManager * LonerDistributionManager shutdown was not being called from close() method call. * This resulted in the thread

[GitHub] geode pull request #498: GEODE-2881: Wait for waitForFlushBeforeExecuteTextS...

2017-05-08 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/498 GEODE-2881: Wait for waitForFlushBeforeExecuteTextSearch to complete * Test now waits for waitForFlushBeforeExecuteTextSearch initiated by the test hook. * The test hook gets called

[GitHub] geode pull request #492: GEODE-2754: Changed the name of unknown host

2017-05-03 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/492 GEODE-2754: Changed the name of unknown host * Assert failures occured if the network contained machines named "unknown" as the test function also named the unknown host a

[GitHub] geode pull request #481: GEODE-2828: AEQ being created before the user regio...

2017-05-01 Thread nabarunnag
Github user nabarunnag commented on a diff in the pull request: https://github.com/apache/geode/pull/481#discussion_r114175681 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegion.java --- @@ -78,17 +87,9 @@ protected

[GitHub] geode pull request #481: GEODE-2828: AEQ being created before the user regio...

2017-05-01 Thread nabarunnag
Github user nabarunnag commented on a diff in the pull request: https://github.com/apache/geode/pull/481#discussion_r114175765 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java --- @@ -131,30 +131,41 @@ protected void initialize

[GitHub] geode pull request #481: GEODE-2828: AEQ being created before the user regio...

2017-05-01 Thread nabarunnag
Github user nabarunnag commented on a diff in the pull request: https://github.com/apache/geode/pull/481#discussion_r114164780 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java --- @@ -111,6 +121,10 @@ protected

[GitHub] geode pull request #481: GEODE-2828: AEQ being created before the user regio...

2017-04-28 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/481 GEODE-2828: AEQ being created before the user region Potential Reviewers @gesterzhou @jhuynh1 @upthewaterspout @ladyVader @boglesby You can merge this pull request into a Git repository

[GitHub] geode pull request #479: GEODE-2828: AEQ created before the user region

2017-04-28 Thread nabarunnag
Github user nabarunnag closed the pull request at: https://github.com/apache/geode/pull/479 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode issue #479: GEODE-2828: AEQ created before the user region

2017-04-28 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/479 Sending in a fresh pull request with all modification --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] geode pull request #479: GEODE-2828: AEQ created before the user region

2017-04-27 Thread nabarunnag
Github user nabarunnag commented on a diff in the pull request: https://github.com/apache/geode/pull/479#discussion_r113630780 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java --- @@ -53,6 +54,8 @@ Logger logger

[GitHub] geode pull request #479: GEODE-2828: AEQ created before the user region

2017-04-27 Thread nabarunnag
Github user nabarunnag commented on a diff in the pull request: https://github.com/apache/geode/pull/479#discussion_r113630711 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java --- @@ -166,28 +166,28 @@ public void createIndex

[GitHub] geode pull request #476: GEODE-2816: Redundancy recovery inititiated even if...

2017-04-26 Thread nabarunnag
Github user nabarunnag closed the pull request at: https://github.com/apache/geode/pull/476 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode issue #479: GEM-1331: AEQ created before the user region

2017-04-26 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/479 Pushed to develop Failure in Travis fixed in GEODE-2632 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] geode pull request #479: GEM-1331: AEQ created before the user region

2017-04-26 Thread nabarunnag
GitHub user nabarunnag reopened a pull request: https://github.com/apache/geode/pull/479 GEM-1331: AEQ created before the user region Potential reviewers @gesterzhou @upthewaterspout @jhuynh1 @ladyVader You can merge this pull request into a Git repository by running

[GitHub] geode pull request #479: GEM-1331: AEQ created before the user region

2017-04-26 Thread nabarunnag
Github user nabarunnag closed the pull request at: https://github.com/apache/geode/pull/479 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode pull request #479: GEM-1331: AEQ created before the user region

2017-04-26 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/479 GEM-1331: AEQ created before the user region Potential reviewers @gesterzhou @upthewaterspout @jhuynh1 @ladyVader You can merge this pull request into a Git repository by running: $ git

[GitHub] geode pull request #442: AEQ being created before region

2017-04-24 Thread nabarunnag
Github user nabarunnag closed the pull request at: https://github.com/apache/geode/pull/442 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode pull request #476: GEODE-2816: Redundancy recovery inititiated even if...

2017-04-24 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/476 GEODE-2816: Redundancy recovery inititiated even if redundancy set to 0 Potential reviewers @upthewaterspout @jhuynh1 @gesterzhou @boglesby @ladyVader You can merge this pull request

[GitHub] geode issue #449: GEODE-2764: Added checks on the region name

2017-04-13 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/449 @jhuynh1 I have the changes you mentioned and also added a dunit test to confirm the behaviour --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] geode pull request #451: GEODE-2768: Lucene Queries executed before index is...

2017-04-12 Thread nabarunnag
Github user nabarunnag commented on a diff in the pull request: https://github.com/apache/geode/pull/451#discussion_r111272945 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunction.java --- @@ -132,6 +133,25 @@ private

[GitHub] geode pull request #449: GEODE-2764: Added checks on the region name

2017-04-11 Thread nabarunnag
Github user nabarunnag commented on a diff in the pull request: https://github.com/apache/geode/pull/449#discussion_r111037135 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/CreateIndexFunction.java --- @@ -93,6 +91,31 @@ public void execute

[GitHub] geode pull request #449: GEODE-2764: Added checks on the region name

2017-04-11 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/449 GEODE-2764: Added checks on the region name * Substring the region name till the last occurance of '.' * Check if this substring is a valid region name * Continue this till we

[GitHub] geode pull request #442: AEQ being created before region

2017-04-06 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/442 AEQ being created before region @jhuynh1 Please do review , Is there any window where the redundancy failure may occur? You can merge this pull request into a Git repository by running

[GitHub] geode pull request #424: GEODE-2655: Added DUnit tests for lucene indexes on...

2017-03-14 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/424 GEODE-2655: Added DUnit tests for lucene indexes on mixed objects. * Lucene must be able to index on the common field name of mixed objects * Lucene indexes must also work when

[GitHub] geode pull request #422: GEODE-2639: Added DUnit tests for expiration on Luc...

2017-03-10 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/422 GEODE-2639: Added DUnit tests for expiration on Lucene * Tests added to validate the effect of the expiration of Lucene Index entries. * Once the entries expire, the lucene index

[GitHub] geode pull request #420: GEODE-2635: Creating DUnit tests to test eviction i...

2017-03-08 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/420 GEODE-2635: Creating DUnit tests to test eviction in lucene * DUnit tests for eviction with local destroy and overflow * Refactored the integration tests for eviction

[GitHub] geode pull request #418: GEODE-2620: Rate stats removed from LuceneIndexMetr...

2017-03-07 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/418 GEODE-2620: Rate stats removed from LuceneIndexMetrics * Commit Rate, update rate and query rate removed from LuceneIndexMetrics * They can be added back again when the getRate method

[GitHub] geode pull request #416: GEODE-2618: PrimaryBucketExceptions handled in Luce...

2017-03-07 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/416 GEODE-2618: PrimaryBucketExceptions handled in LuceneQueryFunction.ex… …ecute * PrimaryBucketException while executing a LuceneQuery will now be caught and wrapped

[GitHub] geode pull request #415: GEODE-2604: Added javadoc comments to LuceneIndexMe...

2017-03-06 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/415 GEODE-2604: Added javadoc comments to LuceneIndexMetrics.java @upthewaterspout @jhuynh1 @gesterzhou @boglesby @ladyVader You can merge this pull request into a Git repository by running

[GitHub] geode pull request #414: GEODE-2596: Lucene metrics moved to public API

2017-03-06 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/414 GEODE-2596: Lucene metrics moved to public API * LuceneIndexMetrics and LuceneServiceMXBean were moved to org.apache.geode.cache.lucene.management -- Lucene precheckin