[GitHub] geode issue #733: Keeping old versions around even during a clean
Github user scmbuildguy commented on the issue: https://github.com/apache/geode/pull/733 I am hesitant about this change since it doesn't follow the Gradle workflow very well. Would it be possible to include old versions as dependencies? Maybe then we could leverage Gradle Cache instead of managing it ourselves. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #621: GEODE-3129 - Added error messages to protobuf protocol
Github user scmbuildguy commented on the issue: https://github.com/apache/geode/pull/621 Thanks! It was not clear from the history of the pull request. --Mark --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #621: GEODE-3129 - Added error messages to protobuf protocol
Github user scmbuildguy commented on the issue: https://github.com/apache/geode/pull/621 This was opened for about 90 minutes before it was merged into develop. Was there a review done by a committer on this code? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #69: GEODE-2513 Unbrand C++ API docs
Github user scmbuildguy commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/69#discussion_r107524018
--- Diff:
docs/geode-native-docs/cpp-caching-api/accessing-entry.html.md.erb ---
@@ -35,11 +35,11 @@ for ( int32_t i=0; i< 100; i++) {
## Bulk Get Operations Using getAll
-You can use the `Region::getAll` API (`Region.GetAll` for .NET) to get
values for an array of keys from the local cache or server. If the value for a
key is not present locally, then it is requested from the server.
+You can use the `Region::getAll` methond to get values for an array of
keys from the local cache or server. If the value for a key is not present
locally, then it is requested from the server.
--- End diff --
Spelling error
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view
Github user scmbuildguy commented on a diff in the pull request:
https://github.com/apache/geode-site/pull/1#discussion_r103041344
--- Diff: build.gradle ---
@@ -16,10 +16,50 @@
*/
plugins {
- id "org.nosphere.apache.rat" version "0.3.0"
+ id 'org.nosphere.apache.rat' version '0.3.0'
+ id 'org.ajoberstar.grgit' version '1.6.0'
}
-apply plugin: "org.nosphere.apache.rat"
+apply plugin: 'org.ajoberstar.grgit'
+
+task clean << {
+ delete buildDir
+}
+
+def dockerCmd = "docker run -v '${projectDir}':/geode-site -p 3000:3000 -w
/geode-site/website apachegeode/geode-site-build "
+
+task compile(type:Exec, dependsOn: rat) {
+ inputs.dir "${projectDir}/website"
+ outputs.dir "${buildDir}/content"
+ executable 'bash'
+ args "-c", dockerCmd + "nanoc compile"
+}
+
+task view(type:Exec, dependsOn: compile) {
+ executable 'bash'
+ args "-c", dockerCmd + "nanoc view"
+}
+
+task publish(dependsOn: compile) {
--- End diff --
Sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view
Github user scmbuildguy commented on a diff in the pull request: https://github.com/apache/geode-site/pull/1#discussion_r103036407 --- Diff: README.md --- @@ -20,3 +20,58 @@ limitations under the License. [](https://travis-ci.org/apache/geode-site) [](https://www.apache.org/licenses/LICENSE-2.0) # Apache Geode Site + +This directory contains the source files for the project [website](https://geode.apache.org). Website content is written in [Markdown](https://help.github.com/articles/markdown-basics) and the site files are generated from that source by a tool called [Pandoc](http://johnmacfarlane.net/pandoc). + +Source files for the website are in `website/content`. Generated files for the website are in `build/content`. + +**NOTE:** To make changes to the [Apache Geode User Guide](http://geode.apache.org/docs/), which is published to the website: + +- Review [CONTRIBUTING](https://github.com/apache/geode/blob/develop/geode-docs/CONTRIBUTE.md) for information about contributing to the documentation source files. +- Follow the [README](https://github.com/apache/geode/blob/develop/geode-book/README.md) for information about building a local version of the guide and adding it to the website. + +The website is updated by a "sync" tool that monitors the __asf-site__ branch +of our Git repo, so after making changes you must place your updated source +and generated files on the __asf-site__ branch and push. +The content will be published to the +[Geode website](http://geode.apache.org) after a 5-20 minute delay. + +## Prerequisites + +To generate the site locally, you need to install java and docker. + +## How to change/update the website + +### 1. Find and edit the source files you need to change + +Source files for the website are in ``website/content``. When changing the content of the site, find the Markdown files that you +need to edit and make your change. If you need to change the layout or styling of the site, then you will probably need to change +an HTML, JS or CSS file. + +### 2. Locally generate the site and test your changes + +To generate the site content, run the `nanoc` compiler: + +$ ./gradlew compile + +To view the generated site, run: + +$ ./gradlew view + +and point your browser at `http://localhost:3000`. To make further changes, stop the build, edit files, recompile, and view again. + +### 3. Publish your changes to the site + +Once you are happy with your changes, commit them to the __master__ branch. +The changes also need to be propagated to the __asf-site__ branch. Run the +gradle command + +$ ./gradlew publish + +to checkout the __asf-site__ branch and copy the website files. You will +need to manually commit and push your changes on the __asf-site__ branch. + +The site should update in 5-10 minutes. If it does not, --- End diff -- Earlier in the document it states update will have in 5-20 minutes, looking for consistency --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view
Github user scmbuildguy commented on a diff in the pull request:
https://github.com/apache/geode-site/pull/1#discussion_r103036769
--- Diff: build.gradle ---
@@ -16,10 +16,50 @@
*/
plugins {
- id "org.nosphere.apache.rat" version "0.3.0"
+ id 'org.nosphere.apache.rat' version '0.3.0'
+ id 'org.ajoberstar.grgit' version '1.6.0'
}
-apply plugin: "org.nosphere.apache.rat"
+apply plugin: 'org.ajoberstar.grgit'
+
+task clean << {
+ delete buildDir
+}
+
+def dockerCmd = "docker run -v '${projectDir}':/geode-site -p 3000:3000 -w
/geode-site/website apachegeode/geode-site-build "
+
+task compile(type:Exec, dependsOn: rat) {
+ inputs.dir "${projectDir}/website"
+ outputs.dir "${buildDir}/content"
+ executable 'bash'
+ args "-c", dockerCmd + "nanoc compile"
+}
+
+task view(type:Exec, dependsOn: compile) {
+ executable 'bash'
+ args "-c", dockerCmd + "nanoc view"
+}
+
+task publish(dependsOn: compile) {
--- End diff --
Should the publish task also do the 'push' as well? When I think I am going
to publish something, I would think it do all the steps.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view
Github user scmbuildguy commented on a diff in the pull request: https://github.com/apache/geode-site/pull/1#discussion_r103038157 --- Diff: README.md --- @@ -20,3 +20,58 @@ limitations under the License. [](https://travis-ci.org/apache/geode-site) [](https://www.apache.org/licenses/LICENSE-2.0) # Apache Geode Site + +This directory contains the source files for the project [website](https://geode.apache.org). Website content is written in [Markdown](https://help.github.com/articles/markdown-basics) and the site files are generated from that source by a tool called [Pandoc](http://johnmacfarlane.net/pandoc). + +Source files for the website are in `website/content`. Generated files for the website are in `build/content`. + +**NOTE:** To make changes to the [Apache Geode User Guide](http://geode.apache.org/docs/), which is published to the website: + +- Review [CONTRIBUTING](https://github.com/apache/geode/blob/develop/geode-docs/CONTRIBUTE.md) for information about contributing to the documentation source files. +- Follow the [README](https://github.com/apache/geode/blob/develop/geode-book/README.md) for information about building a local version of the guide and adding it to the website. + +The website is updated by a "sync" tool that monitors the __asf-site__ branch +of our Git repo, so after making changes you must place your updated source +and generated files on the __asf-site__ branch and push. +The content will be published to the +[Geode website](http://geode.apache.org) after a 5-20 minute delay. + +## Prerequisites --- End diff -- Looks like Bash is needed, so does that mean this is linux flavors only? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #398: Split the redis adapter into its own package
Github user scmbuildguy commented on a diff in the pull request:
https://github.com/apache/geode/pull/398#discussion_r101351743
--- Diff:
geode-redis/src/test/java/org/apache/geode/redis/AuthJUnitTest.java ---
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
ANY KIND, either express
+ * or implied. See the License for the specific language governing
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.redis;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.fail;
+
+import org.apache.geode.distributed.ConfigurationProperties;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import org.apache.geode.internal.cache.GemFireCacheImpl;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import java.util.Properties;
+import redis.clients.jedis.Jedis;
+import redis.clients.jedis.exceptions.JedisConnectionException;
+import redis.clients.jedis.exceptions.JedisDataException;
+
+@Category(IntegrationTest.class)
+public class AuthJUnitTest extends RedisTestBase {
+
+ private static final String PASSWORD = "pwd";
+
+ private void setupCacheWithPassword() {
+if (cache != null) {
+ cache.close();
+}
+Properties redisCacheProperties = getDefaultRedisCacheProperties();
+
redisCacheProperties.setProperty(ConfigurationProperties.REDIS_PASSWORD,
PASSWORD);
+cache = (GemFireCacheImpl) createCacheInstance(redisCacheProperties);
+ }
+
+ @Test
+ public void testAuthConfig() {
+setupCacheWithPassword();
+InternalDistributedSystem distributedSystem =
cache.getDistributedSystem();
+assert
(distributedSystem.getConfig().getRedisPassword().equals(PASSWORD));
+cache.close();
+ }
+
+ @Test
+ public void testAuthRejectAccept() {
+setupCacheWithPassword();
+try (Jedis jedis = defaultJedisInstance()) {
+ Exception ex = null;
+ try {
+jedis.auth("wrongpwd");
+ } catch (JedisDataException e) {
+ex = e;
+ }
+ assertNotNull(ex);
+
+ String res = jedis.auth(PASSWORD);
+ assertEquals(res, "OK");
+}
+ }
+
+ @Test
+ public void testAuthNoPwd() {
+try (Jedis jedis = defaultJedisInstance()) {
+ jedis.auth(PASSWORD);
+ fail(
+ "We expecting either a JedisConnectionException or
JedisDataException to be thrown here");
--- End diff --
Minor grammar issue, seems to be missing 'are'.
We are expecting...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #342: GEODE-2309: Replace Pivotal Copyright and add Apache Licen...
Github user scmbuildguy commented on the issue: https://github.com/apache/geode/pull/342 +1 for this round --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-examples issue #1: GEODE-2260: Revise geode-examples to be in their ow...
Github user scmbuildguy commented on the issue: https://github.com/apache/geode-examples/pull/1 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #322: [GEODE-165] Fix for Add build support for generating antlr...
Github user scmbuildguy commented on the issue: https://github.com/apache/geode/pull/322 +1 - I agree with generating these files should be done at build time and not checked into source. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
