[GitHub] geode issue #515: GEODE-240: Remove deprecated methods on TransactionEvent

2017-07-21 Thread shankarh
Github user shankarh commented on the issue: https://github.com/apache/geode/pull/515 Can this PR be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] geode issue #507: GEODE-231 : Remove deprecated AttributesMutator.setCacheLi...

2017-05-24 Thread shankarh
Github user shankarh commented on the issue: https://github.com/apache/geode/pull/507 Thanks @ameybarve15 @dschneider-pivotal for review. Do I need to resubmit this PR after resolving conflicts? or we resolve conflicts while merging? --- If your project is set up

[GitHub] geode pull request #515: GEODE-240: Remove deprecated methods on Transaction...

2017-05-16 Thread shankarh
GitHub user shankarh opened a pull request: https://github.com/apache/geode/pull/515 GEODE-240: Remove deprecated methods on TransactionEvent Removed deprecated methods getCreateEvents, getDestroyEvents, getPutEvents, getInvalidateEvents from the TransactionEvent. Removed

[GitHub] geode pull request #324: GEODE-2235 : Adding missing test annotation

2016-12-22 Thread shankarh
GitHub user shankarh opened a pull request: https://github.com/apache/geode/pull/324 GEODE-2235 : Adding missing test annotation Added @test annotation to testCqOnAccessorServerWithUpdatesResultingInDestroyedCQEvents test You can merge this pull request into a Git repository

[GitHub] geode issue #320: GEODE-1969 : oplog closed while writing to oplog with gemf...

2016-12-20 Thread shankarh
Github user shankarh commented on the issue: https://github.com/apache/geode/pull/320 Thanks @dschneider-pivotal for the review. Will add the unit test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] geode pull request #320: GEODE-1969 : oplog closed while writing to oplog wi...

2016-12-16 Thread shankarh
GitHub user shankarh opened a pull request: https://github.com/apache/geode/pull/320 GEODE-1969 : oplog closed while writing to oplog with gemfire.syncWrites=true Moved the channel force call inside the sync block. You can merge this pull request into a Git repository