[GitHub] geode pull request #665: GEODE-3254: Refactoring ConfigCommands and ConfigCo...

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/665 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #665: GEODE-3254: Refactoring ConfigCommands and ConfigCo...

2017-08-02 Thread YehEmily
Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/665#discussion_r130965197 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/Interceptor.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] geode pull request #665: GEODE-3254: Refactoring ConfigCommands and ConfigCo...

2017-08-02 Thread YehEmily
Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/665#discussion_r130960231 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/Interceptor.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] geode pull request #665: GEODE-3254: Refactoring ConfigCommands and ConfigCo...

2017-08-01 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/665#discussion_r130658877 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/Interceptor.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to

[GitHub] geode pull request #665: GEODE-3254: Refactoring ConfigCommands and ConfigCo...

2017-08-01 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/665#discussion_r130661310 --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportConfigCommandDUnitTest.java --- @@ -0,0 +1,181 @@ +/*

[GitHub] geode pull request #665: GEODE-3254: Refactoring ConfigCommands and ConfigCo...

2017-07-28 Thread YehEmily
GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/665 GEODE-3254: Refactoring ConfigCommands and ConfigCommandsDUnitTest [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3254) `ConfigCommands.java` was a large class