Re: Review Request 58155: GEODE-2653: fix a flaky test.

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58155/#review171212
---


Ship it!




Ship It!

- Udo Kohlmeyer


On April 5, 2017, 11:44 p.m., Galen O'Sullivan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58155/
> ---
> 
> (Updated April 5, 2017, 11:44 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> And do some cleanup while I'm here:
>  * Change Mockito's `any` to `isA`.
>  * Replace some `Thread.sleep()` calls with Awaitility calls.
>  * Remove our `MethodExecuted` class -- this can be done with Mockito's 
> `verify()`.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
>  05ab6f7e5 
> 
> 
> Diff: https://reviews.apache.org/r/58155/diff/2/
> 
> 
> Testing
> ---
> 
> Precheckin passed.
> 
> Ran the test suite in IntelliJ a few hundred times on my machine.
> 
> 
> Thanks,
> 
> Galen O'Sullivan
> 
>

Re: Review Request 58155: GEODE-2653: fix a flaky test.

[Galen O'Sullivan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58155/
---

(Updated April 5, 2017, 11:44 p.m.)


Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.


Changes
---

Remove a redundant assert.

I can't push this 'cause I'm not a committer.


Repository: geode


Description
---

And do some cleanup while I'm here:
 * Change Mockito's `any` to `isA`.
 * Replace some `Thread.sleep()` calls with Awaitility calls.
 * Remove our `MethodExecuted` class -- this can be done with Mockito's 
`verify()`.


Diffs (updated)
-

  
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
 05ab6f7e5 


Diff: https://reviews.apache.org/r/58155/diff/2/

Changes: https://reviews.apache.org/r/58155/diff/1-2/


Testing (updated)
---

Precheckin passed.

Ran the test suite in IntelliJ a few hundred times on my machine.


Thanks,

Galen O'Sullivan

Re: Review Request 58155: GEODE-2653: fix a flaky test.

[Galen O'Sullivan]

> On April 3, 2017, 8:48 p.m., Bruce Schuchardt wrote:
> > geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
> > Line 377 (original), 371 (patched)
> > 
> >
> > These two lines are redundant now, aren't they?

I think we still need the old view to create the new view. The assert is 
probably redundant, though.


- Galen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58155/#review170927
---


On April 3, 2017, 6:31 p.m., Galen O'Sullivan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58155/
> ---
> 
> (Updated April 3, 2017, 6:31 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> And do some cleanup while I'm here:
>  * Change Mockito's `any` to `isA`.
>  * Replace some `Thread.sleep()` calls with Awaitility calls.
>  * Remove our `MethodExecuted` class -- this can be done with Mockito's 
> `verify()`.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
>  05ab6f7e5 
> 
> 
> Diff: https://reviews.apache.org/r/58155/diff/1/
> 
> 
> Testing
> ---
> 
> Running precheckin.
> 
> Ran the test suite in IntelliJ a few hundred times on my machine.
> 
> 
> Thanks,
> 
> Galen O'Sullivan
> 
>

Re: Review Request 58155: GEODE-2653: fix a flaky test.

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58155/#review170927
---




geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
Line 377 (original), 371 (patched)


These two lines are redundant now, aren't they?


- Bruce Schuchardt


On April 3, 2017, 6:31 p.m., Galen O'Sullivan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58155/
> ---
> 
> (Updated April 3, 2017, 6:31 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> And do some cleanup while I'm here:
>  * Change Mockito's `any` to `isA`.
>  * Replace some `Thread.sleep()` calls with Awaitility calls.
>  * Remove our `MethodExecuted` class -- this can be done with Mockito's 
> `verify()`.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
>  05ab6f7e5 
> 
> 
> Diff: https://reviews.apache.org/r/58155/diff/1/
> 
> 
> Testing
> ---
> 
> Running precheckin.
> 
> Ran the test suite in IntelliJ a few hundred times on my machine.
> 
> 
> Thanks,
> 
> Galen O'Sullivan
> 
>

Review Request 58155: GEODE-2653: fix a flaky test.

[Galen O'Sullivan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58155/
---

Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.


Repository: geode


Description
---

And do some cleanup while I'm here:
 * Change Mockito's `any` to `isA`.
 * Replace some `Thread.sleep()` calls with Awaitility calls.
 * Remove our `MethodExecuted` class -- this can be done with Mockito's 
`verify()`.


Diffs
-

  
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
 05ab6f7e5 


Diff: https://reviews.apache.org/r/58155/diff/1/


Testing
---

Running precheckin.

Ran the test suite in IntelliJ a few hundred times on my machine.


Thanks,

Galen O'Sullivan