PRs created/updated after 4pm today will now get the additional Java11 checks :)
The non-gating jobs have also been shifted right in the pipeline (this is only
visible when you click on the “complete
+1 I added my approval to your PRs. I don't know if the yml is correct or
not, but I support the overall goal.
On Thu, Nov 8, 2018 at 1:19 PM, Owen Nichols wrote:
> Sounds like the overwhelming consensus is to keep Java11 gating, add
> Java11 to PR, and defer non-gating tests.
>
> I have
Sounds like the overwhelming consensus is to keep Java11 gating, add Java11 to
PR, and defer non-gating tests.
I have prepared PRs for these changes:
https://github.com/apache/geode/pull/2806 (add Java11 to PR pipeline)
https://github.com/apache/geode/pull/2816 (run non-gating jobs only after
The key issue here is how closely the PR pipeline’s testing should match the
develop pipeline.
If parity is desirable, then we need to either add Java11 test jobs to the PR
pipeline, or go back to having Java11 tests be non-gating in the develop
pipeline.
If instead we want PR to be just a
I agree with Jinmei on all points. I definitely think there should be
parity between precheckin and the main pipeline, but that might just be
because I caused the main pipeline to fail on Java11 this week.
On Wed, Nov 7, 2018 at 1:34 PM, Jinmei Liao wrote:
> First of all, I believe all gating
First of all, I believe all gating tests should be run in precheckin. If we
make jdk11 tests gating, we should make it part of the precheckin. If we
don't put them in precheckin, they should not be gating.
Secondly, If we don't make jdk11 tests gating, soon they will become like
windows tests,
Now that tests are passing under Java 11, it was recommended last week to make
Java 11 tests gating for the develop pipeline. [Fyi, Windows tests are not yet
gating, meaning the pipeline will success and publish artifacts even if a
Windows tests fails.]
Three topics merit discussion:
1) For
