Github user scmbuildguy commented on the issue:
https://github.com/apache/geode/pull/342
+1 for this round
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user metatype commented on the issue:
https://github.com/apache/geode/pull/342
LGTM, these changes typically take multiple iterations to get right.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/342
Looks good so far, but there are still a lot of files missing apache
headers. I don't know how easy it will be to integrate [apache
rat](https://creadur.apache.org/rat/) into the cmake build,