Github user jujoramos commented on the issue:
https://github.com/apache/geode/pull/664
@jinmeiliao: thanks for reviewing this :-).
One more quick question and I'll leave you alone: do I need to change the
status of [GEODE-3292](https://issues.apache.org/jira/browse/GEODE-3292) to
Github user jinmeiliao commented on the issue:
https://github.com/apache/geode/pull/664
I will pull this in the moment I got a green pipeline
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/664
Thanks @jujoramos, this looks good to me. Do you have any thoughts
@jinmeiliao?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user jujoramos commented on the issue:
https://github.com/apache/geode/pull/664
Hello @jaredjstewart,
Just pushed the requested changes.
- Renamed `PulseVerificationTest` to `PulseConnectivityTest`.
- Removed `loginWithIncorrectPassword` test method, it is
Github user jujoramos commented on the issue:
https://github.com/apache/geode/pull/664
Hey @jaredjstewart,
Thanks for looking at this.
I'll write the tests, no worries at all.
Cheers.
---
If your project is set up for it, you can reply to this email and have your
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/664
Hi Juan,
Thanks for your contribution! Your changes look good to me, but our
[Criteria for Code
