[GitHub] geode pull request #330: [GEODE-2227] AutoSerializableJUnitTest.testMultiple...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/330


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #330: [GEODE-2227] AutoSerializableJUnitTest.testMultiple...

[metatype]

Github user metatype commented on a diff in the pull request:

https://github.com/apache/geode/pull/330#discussion_r94783782
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/pdx/AutoSerializableJUnitTest.java ---
@@ -1291,7 +1289,8 @@ public void testMultipleClassLoaders() throws 
Exception {
 List urls = new ArrayList();
 String classPathStr = System.getProperty("java.class.path");
 if (classPathStr != null) {
-  String[] cpList = classPathStr.split(":");
+  String[] cpList =
--- End diff --

You can avoid the ternary operator by using 
`System.getProperty("path.separator")`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #330: [GEODE-2227] AutoSerializableJUnitTest.testMultiple...

[vectorijk]

GitHub user vectorijk opened a pull request:

https://github.com/apache/geode/pull/330

[GEODE-2227] AutoSerializableJUnitTest.testMultipleClassLoaders fails on 
Windows

Parsing the path of classes is not correctly on Windows. The path of 
library classes on Windows is split by semicolon instead of colon. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vectorijk/geode GEODE-2227

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/330.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #330


commit 6f02008a1930ebf448d3387a59eccd57c2ce7ded
Author: Kai Jiang 
Date:   2017-01-05T12:11:26Z

GEODE-2227

AutoSerializableJUnitTest.testMultipleClassLoaders fails on Windows




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---