[GitHub] geode pull request #515: GEODE-240: Remove deprecated methods on Transaction...

2017-07-25 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/515


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #515: GEODE-240: Remove deprecated methods on Transaction...

2017-05-16 Thread shankarh
GitHub user shankarh opened a pull request:

https://github.com/apache/geode/pull/515

GEODE-240: Remove deprecated methods on TransactionEvent

Removed deprecated methods getCreateEvents, getDestroyEvents, getPutEvents, 
getInvalidateEvents from the TransactionEvent.
Removed implementation for methods getCreateEvents, getDestroyEvents, 
getPutEvents, getInvalidateEvents from TxEvent and TxRmtEvent.
Added utility methods getCreateEvents, getDestroyEvents, getPutEvents, 
getInvalidateEvents in TxEventTestUtil.
Changed tests to use the new utilty methods from TxEventTestUtil.

Signed-off-by: Shankar 

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
Yes.  GEODE-240
- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
Yes.
- [ ] Is your initial contribution a single, squashed commit?
Yes.
- [ ] Does `gradlew build` run cleanly?
Yes.
- [ ] Have you written or updated unit tests to verify your changes?
Yes.
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
Not applicable.
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shankarh/geode feature/GEODE-240

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/515.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #515


commit bff4e8efa5368fca1a77931ae16e0d94d9e03e53
Author: shankarh 
Date:   2017-05-16T02:47:05Z

GEODE-240: Remove deprecated methods on TransactionEvent

Removed deprecated methods getCreateEvents, getDestroyEvents, getPutEvents, 
getInvalidateEvents from the TransactionEvent.
Removed implementation for methods getCreateEvents, getDestroyEvents, 
getPutEvents, getInvalidateEvents from TxEvent and TxRmtEvent.
Added utility methods getCreateEvents, getDestroyEvents, getPutEvents, 
getInvalidateEvents in TxEventTestUtil.
Changed tests to use the new utilty methods from TxEventTestUtil.

Signed-off-by: Shankar 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---