[GitHub] geode pull request #671: GEODE-3255: Refactor CreateAlterDestroyRegionComman...

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/671 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #671: GEODE-3255: Refactor CreateAlterDestroyRegionComman...

2017-08-02 Thread YehEmily
Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/671#discussion_r131002611 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java --- @@ -1143,4 +721,26 @@ private boolean

[GitHub] geode pull request #671: GEODE-3255: Refactor CreateAlterDestroyRegionComman...

2017-08-01 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/671#discussion_r130668398 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java --- @@ -1143,4 +721,26 @@ private

[GitHub] geode pull request #671: GEODE-3255: Refactor CreateAlterDestroyRegionComman...

2017-07-31 Thread YehEmily
GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/671 GEODE-3255: Refactor CreateAlterDestroyRegionCommands and tests [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3255) `CreateAlterDestroyRegionCommands` was a