[jira] [Commented] (GEODE-2815) Incorrect Error Message in REST API docs for {region}/{key} HTTP.GET command
[
https://issues.apache.org/jira/browse/GEODE-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16001589#comment-16001589
]
ASF subversion and git services commented on GEODE-2815:
Commit 5a1b06210d756d7012d22b9e8841d390b6647857 in geode's branch
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5a1b062 ]
GEODE-2815 Incorrect Error Message in REST API docs for {region}/{key} HTTP.GET
command
This closes #493
> Incorrect Error Message in REST API docs for {region}/{key} HTTP.GET command
>
>
> Key: GEODE-2815
> URL: https://issues.apache.org/jira/browse/GEODE-2815
> Project: Geode
> Issue Type: Bug
> Components: docs
>Affects Versions: 1.1.1, 1.2.0
>Reporter: Michael Martell
>Assignee: Dave Barnes
>Priority: Minor
>
> According to the docs at
> http://gemfire.docs.pivotal.io/geode/rest_apps/get_region_key_data.html error
> responses HTTP 400 and HTTP 404 appear to be very similar,
> # 400 - BAD REQUEST - Returned if the supplied key is not found in the region.
> # 404 - NOT FOUND - Returned if key does not exist for the region.
> The source code at PdxBasedCrudController.java:210 & 213 show that 404
> actually means "Region does not exist", thus the documentation appears to be
> incorrect. Other commands are correct in the docs showing 404 means region
> does not exist.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2815) Incorrect Error Message in REST API docs for {region}/{key} HTTP.GET command
[
https://issues.apache.org/jira/browse/GEODE-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16001590#comment-16001590
]
ASF GitHub Bot commented on GEODE-2815:
---
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/493
> Incorrect Error Message in REST API docs for {region}/{key} HTTP.GET command
>
>
> Key: GEODE-2815
> URL: https://issues.apache.org/jira/browse/GEODE-2815
> Project: Geode
> Issue Type: Bug
> Components: docs
>Affects Versions: 1.1.1, 1.2.0
>Reporter: Michael Martell
>Assignee: Dave Barnes
>Priority: Minor
>
> According to the docs at
> http://gemfire.docs.pivotal.io/geode/rest_apps/get_region_key_data.html error
> responses HTTP 400 and HTTP 404 appear to be very similar,
> # 400 - BAD REQUEST - Returned if the supplied key is not found in the region.
> # 404 - NOT FOUND - Returned if key does not exist for the region.
> The source code at PdxBasedCrudController.java:210 & 213 show that 404
> actually means "Region does not exist", thus the documentation appears to be
> incorrect. Other commands are correct in the docs showing 404 means region
> does not exist.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2815) Incorrect Error Message in REST API docs for {region}/{key} HTTP.GET command
[
https://issues.apache.org/jira/browse/GEODE-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16001584#comment-16001584
]
ASF GitHub Bot commented on GEODE-2815:
---
Github user davebarnes97 commented on the issue:
https://github.com/apache/geode/pull/493
Received a drive-by +1 from mmartell, the filer of the JIRA ticket.
> Incorrect Error Message in REST API docs for {region}/{key} HTTP.GET command
>
>
> Key: GEODE-2815
> URL: https://issues.apache.org/jira/browse/GEODE-2815
> Project: Geode
> Issue Type: Bug
> Components: docs
>Affects Versions: 1.1.1, 1.2.0
>Reporter: Michael Martell
>Assignee: Dave Barnes
>Priority: Minor
>
> According to the docs at
> http://gemfire.docs.pivotal.io/geode/rest_apps/get_region_key_data.html error
> responses HTTP 400 and HTTP 404 appear to be very similar,
> # 400 - BAD REQUEST - Returned if the supplied key is not found in the region.
> # 404 - NOT FOUND - Returned if key does not exist for the region.
> The source code at PdxBasedCrudController.java:210 & 213 show that 404
> actually means "Region does not exist", thus the documentation appears to be
> incorrect. Other commands are correct in the docs showing 404 means region
> does not exist.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2815) Incorrect Error Message in REST API docs for {region}/{key} HTTP.GET command
[
https://issues.apache.org/jira/browse/GEODE-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999119#comment-15999119
]
ASF GitHub Bot commented on GEODE-2815:
---
GitHub user davebarnes97 opened a pull request:
https://github.com/apache/geode/pull/493
GEODE-2815 Incorrect Error Message in REST API docs for {region}/{key…
…} HTTP.GET command
404 does mean 'not found', and in the REST API context it can mean 'Region
not found', 'Key not found' or 'Either key or region not found', depending on
what was being requested.
Edited the various REST API command docs accordingly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davebarnes97/geode feature/GEODE-2815
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/493.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #493
commit d2b99aeb5e28307c95963c8ee4a2ce5bf979f7a9
Author: Dave Barnes
Date: 2017-05-05T21:37:07Z
GEODE-2815 Incorrect Error Message in REST API docs for {region}/{key}
HTTP.GET command
> Incorrect Error Message in REST API docs for {region}/{key} HTTP.GET command
>
>
> Key: GEODE-2815
> URL: https://issues.apache.org/jira/browse/GEODE-2815
> Project: Geode
> Issue Type: Bug
> Components: docs
>Affects Versions: 1.1.1, 1.2.0
>Reporter: Michael Martell
>Assignee: Dave Barnes
>Priority: Minor
>
> According to the docs at
> http://gemfire.docs.pivotal.io/geode/rest_apps/get_region_key_data.html error
> responses HTTP 400 and HTTP 404 appear to be very similar,
> # 400 - BAD REQUEST - Returned if the supplied key is not found in the region.
> # 404 - NOT FOUND - Returned if key does not exist for the region.
> The source code at PdxBasedCrudController.java:210 & 213 show that 404
> actually means "Region does not exist", thus the documentation appears to be
> incorrect. Other commands are correct in the docs showing 404 means region
> does not exist.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2815) Incorrect Error Message in REST API docs for {region}/{key} HTTP.GET command
[
https://issues.apache.org/jira/browse/GEODE-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999101#comment-15999101
]
Dave Barnes commented on GEODE-2815:
Digging a bit deeper, 404 does mean 'not found', and in the REST API context it
can mean 'Region not found', 'Key not found' or 'Either key or region not
found', depending on what was being requested.
Edited the various REST API command docs accordingly.
> Incorrect Error Message in REST API docs for {region}/{key} HTTP.GET command
>
>
> Key: GEODE-2815
> URL: https://issues.apache.org/jira/browse/GEODE-2815
> Project: Geode
> Issue Type: Bug
> Components: docs
>Affects Versions: 1.1.1, 1.2.0
>Reporter: Michael Martell
>Assignee: Dave Barnes
>Priority: Minor
>
> According to the docs at
> http://gemfire.docs.pivotal.io/geode/rest_apps/get_region_key_data.html error
> responses HTTP 400 and HTTP 404 appear to be very similar,
> # 400 - BAD REQUEST - Returned if the supplied key is not found in the region.
> # 404 - NOT FOUND - Returned if key does not exist for the region.
> The source code at PdxBasedCrudController.java:210 & 213 show that 404
> actually means "Region does not exist", thus the documentation appears to be
> incorrect. Other commands are correct in the docs showing 404 means region
> does not exist.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
