[jira] [Commented] (GEODE-2825) Lucene query may stackoverflow if enough function execution retries are executed

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995654#comment-15995654
 ] 

ASF subversion and git services commented on GEODE-2825:


Commit ecbf55769c1aa04b173e39f719565e03820ac8f2 in geode's branch 
refs/heads/feature/GEM-1353 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ecbf557 ]

GEODE-2825: Lucene query function will wait until index is returned if an index 
is defined

  * If an index is in a defined state but not yet created, the query will now 
wait
until the index is created or no longer defined.  Instead of throwing an
exception and possibly getting a stack overflow


> Lucene query may stackoverflow if enough function execution retries are 
> executed
> 
>
> Key: GEODE-2825
> URL: https://issues.apache.org/jira/browse/GEODE-2825
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>
> It is possible that a LuceneQueryFunction fails to obtain the lucene index, 
> this will cause a retry.  If this occurs enough, a stack overflow will occur 
> based on the way the function execution code is currently written.
> Instead we can detect if the index has been defined, if so, wait until the 
> index is created.  This will cause the query to block/wait until the index is 
> ready.  It is possible to get stuck in a loop like this, but this scenario 
> should only occur when an index is being created but has yet to complete.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2825) Lucene query may stackoverflow if enough function execution retries are executed

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994015#comment-15994015
 ] 

ASF subversion and git services commented on GEODE-2825:


Commit ecbf55769c1aa04b173e39f719565e03820ac8f2 in geode's branch 
refs/heads/develop from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ecbf557 ]

GEODE-2825: Lucene query function will wait until index is returned if an index 
is defined

  * If an index is in a defined state but not yet created, the query will now 
wait
until the index is created or no longer defined.  Instead of throwing an
exception and possibly getting a stack overflow


> Lucene query may stackoverflow if enough function execution retries are 
> executed
> 
>
> Key: GEODE-2825
> URL: https://issues.apache.org/jira/browse/GEODE-2825
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>
> It is possible that a LuceneQueryFunction fails to obtain the lucene index, 
> this will cause a retry.  If this occurs enough, a stack overflow will occur 
> based on the way the function execution code is currently written.
> Instead we can detect if the index has been defined, if so, wait until the 
> index is created.  This will cause the query to block/wait until the index is 
> ready.  It is possible to get stuck in a loop like this, but this scenario 
> should only occur when an index is being created but has yet to complete.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2825) Lucene query may stackoverflow if enough function execution retries are executed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994016#comment-15994016
 ] 

ASF GitHub Bot commented on GEODE-2825:
---

Github user jhuynh1 closed the pull request at:

https://github.com/apache/geode/pull/480


> Lucene query may stackoverflow if enough function execution retries are 
> executed
> 
>
> Key: GEODE-2825
> URL: https://issues.apache.org/jira/browse/GEODE-2825
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>
> It is possible that a LuceneQueryFunction fails to obtain the lucene index, 
> this will cause a retry.  If this occurs enough, a stack overflow will occur 
> based on the way the function execution code is currently written.
> Instead we can detect if the index has been defined, if so, wait until the 
> index is created.  This will cause the query to block/wait until the index is 
> ready.  It is possible to get stuck in a loop like this, but this scenario 
> should only occur when an index is being created but has yet to complete.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2825) Lucene query may stackoverflow if enough function execution retries are executed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993873#comment-15993873
 ] 

ASF GitHub Bot commented on GEODE-2825:
---

Github user jhuynh1 commented on the issue:

https://github.com/apache/geode/pull/480
  
Sure, I can re-add the one second sleep.


> Lucene query may stackoverflow if enough function execution retries are 
> executed
> 
>
> Key: GEODE-2825
> URL: https://issues.apache.org/jira/browse/GEODE-2825
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>
> It is possible that a LuceneQueryFunction fails to obtain the lucene index, 
> this will cause a retry.  If this occurs enough, a stack overflow will occur 
> based on the way the function execution code is currently written.
> Instead we can detect if the index has been defined, if so, wait until the 
> index is created.  This will cause the query to block/wait until the index is 
> ready.  It is possible to get stuck in a loop like this, but this scenario 
> should only occur when an index is being created but has yet to complete.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2825) Lucene query may stackoverflow if enough function execution retries are executed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985514#comment-15985514
 ] 

ASF GitHub Bot commented on GEODE-2825:
---

GitHub user jhuynh1 opened a pull request:

https://github.com/apache/geode/pull/480

GEODE-2825: Lucene query waits for defined index to be created

* If an index is in a defined state but not yet created, the
  query will now wait until the index is created or no longer
  defined.  Instead of throwing an exception and possibly
  getting a stack overflow

Review request list:
@upthewaterspout @nabarunnag @boglesby @ladyVader @gesterzhou 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-2825

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/480.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #480


commit fb01b37ce8b7acda184daabc40de969a15c933c4
Author: Jason Huynh 
Date:   2017-04-26T18:13:53Z

GEODE-2825: Lucene query waits for defined index to be created

* If an index is in a defined state but not yet created, the
  query will now wait until the index is created or no longer
  defined.  Instead of throwing an exception and possibly
  getting a stack overflow




> Lucene query may stackoverflow if enough function execution retries are 
> executed
> 
>
> Key: GEODE-2825
> URL: https://issues.apache.org/jira/browse/GEODE-2825
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>
> It is possible that a LuceneQueryFunction fails to obtain the lucene index, 
> this will cause a retry.  If this occurs enough, a stack overflow will occur 
> based on the way the function execution code is currently written.
> Instead we can detect if the index has been defined, if so, wait until the 
> index is created.  This will cause the query to block/wait until the index is 
> ready.  It is possible to get stuck in a loop like this, but this scenario 
> should only occur when an index is being created but has yet to complete.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2825) Lucene query may stackoverflow if enough function execution retries are executed

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985293#comment-15985293
 ] 

ASF subversion and git services commented on GEODE-2825:


Commit fb01b37ce8b7acda184daabc40de969a15c933c4 in geode's branch 
refs/heads/feature/GEODE-2825 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=fb01b37 ]

GEODE-2825: Lucene query waits for defined index to be created

* If an index is in a defined state but not yet created, the
  query will now wait until the index is created or no longer
  defined.  Instead of throwing an exception and possibly
  getting a stack overflow


> Lucene query may stackoverflow if enough function execution retries are 
> executed
> 
>
> Key: GEODE-2825
> URL: https://issues.apache.org/jira/browse/GEODE-2825
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>
> It is possible that a LuceneQueryFunction fails to obtain the lucene index, 
> this will cause a retry.  If this occurs enough, a stack overflow will occur 
> based on the way the function execution code is currently written.
> Instead we can detect if the index has been defined, if so, wait until the 
> index is created.  This will cause the query to block/wait until the index is 
> ready.  It is possible to get stuck in a loop like this, but this scenario 
> should only occur when an index is being created but has yet to complete.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)