[jira] [Commented] (GEODE-2853) Change of locator list request interval
[ https://issues.apache.org/jira/browse/GEODE-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011005#comment-16011005 ] ASF subversion and git services commented on GEODE-2853: Commit a7441ae99afb2b1b0ef032814c3c19fdd25b73d6 in geode's branch refs/heads/develop from [~masaki.yamakawa] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a7441ae ] GEODE-2853: Change of locator list request interval If you connect to a Geode cluster using a locator from the client, the locator list request will be executed at regular intervals in the background thread. I want to tune this interval. I understand that this interval can be changed by the ping-interval of the Pool attribute. However, I think that ping-interval originally sets the ping interval for health check to the cache server. Therefore, it is not possible to change the locator list request interval without changing the health check interval to the cache server. So,I want to add a java system property that can change the locator list request interval. The locator list request interval is determined by the following priority order. 1. java system property "gemfire.LOCATOR_UPDATE_INTERVAL" 2. ping-interval of the Pool attribute In addition, when changing this time, the background thread is activated only when this value is a positive value. > Change of locator list request interval > --- > > Key: GEODE-2853 > URL: https://issues.apache.org/jira/browse/GEODE-2853 > Project: Geode > Issue Type: Improvement > Components: client/server >Reporter: Masaki Yamakawa >Priority: Minor > > If you connect to a Geode cluster using a locator from the client, the > locator list request will be executed at regular intervals in the background > thread. I want to tune this interval. I understand that this interval can be > changed by the ping-interval of the Pool attribute. However, I think that > ping-interval originally sets the ping interval for health check to the cache > server. Therefore, it is not possible to change the locator list request > interval without changing the health check interval to the cache server. So,I > want to add a java system property that can change the locator list request > interval. > The locator list request interval is determined by the following priority > order. > 1. java system property "gemfire.LOCATOR_UPDATE_INTERVAL" > 2. ping-interval of the Pool attribute > In addition, when changing this time, the background thread is activated only > when this value is a positive value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2853) Change of locator list request interval
[ https://issues.apache.org/jira/browse/GEODE-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011006#comment-16011006 ] ASF subversion and git services commented on GEODE-2853: Commit 762666c23e63d1153ccfb902692b9ce9d1a90e4f in geode's branch refs/heads/develop from [~masaki.yamakawa] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=762666c ] GEODE-2853: Change of locator list request interval Moved the test added to AutoConnectionSourceDUnitTest to AutoConnectionSourceImplJUnitTest, and revert AutoConnectionSourceDUnitTest. > Change of locator list request interval > --- > > Key: GEODE-2853 > URL: https://issues.apache.org/jira/browse/GEODE-2853 > Project: Geode > Issue Type: Improvement > Components: client/server >Reporter: Masaki Yamakawa >Priority: Minor > > If you connect to a Geode cluster using a locator from the client, the > locator list request will be executed at regular intervals in the background > thread. I want to tune this interval. I understand that this interval can be > changed by the ping-interval of the Pool attribute. However, I think that > ping-interval originally sets the ping interval for health check to the cache > server. Therefore, it is not possible to change the locator list request > interval without changing the health check interval to the cache server. So,I > want to add a java system property that can change the locator list request > interval. > The locator list request interval is determined by the following priority > order. > 1. java system property "gemfire.LOCATOR_UPDATE_INTERVAL" > 2. ping-interval of the Pool attribute > In addition, when changing this time, the background thread is activated only > when this value is a positive value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2853) Change of locator list request interval
[ https://issues.apache.org/jira/browse/GEODE-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011007#comment-16011007 ] ASF subversion and git services commented on GEODE-2853: Commit 4b2609597c0ff3081d3032ef57f90e5367a3c6f5 in geode's branch refs/heads/develop from [~masaki.yamakawa] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=4b26095 ] GEODE-2853: Change of locator list request interval Replace the manual cleanup of system properties with the Rule. This closes #483 > Change of locator list request interval > --- > > Key: GEODE-2853 > URL: https://issues.apache.org/jira/browse/GEODE-2853 > Project: Geode > Issue Type: Improvement > Components: client/server >Reporter: Masaki Yamakawa >Priority: Minor > > If you connect to a Geode cluster using a locator from the client, the > locator list request will be executed at regular intervals in the background > thread. I want to tune this interval. I understand that this interval can be > changed by the ping-interval of the Pool attribute. However, I think that > ping-interval originally sets the ping interval for health check to the cache > server. Therefore, it is not possible to change the locator list request > interval without changing the health check interval to the cache server. So,I > want to add a java system property that can change the locator list request > interval. > The locator list request interval is determined by the following priority > order. > 1. java system property "gemfire.LOCATOR_UPDATE_INTERVAL" > 2. ping-interval of the Pool attribute > In addition, when changing this time, the background thread is activated only > when this value is a positive value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2853) Change of locator list request interval
[ https://issues.apache.org/jira/browse/GEODE-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011008#comment-16011008 ] ASF GitHub Bot commented on GEODE-2853: --- Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/483 > Change of locator list request interval > --- > > Key: GEODE-2853 > URL: https://issues.apache.org/jira/browse/GEODE-2853 > Project: Geode > Issue Type: Improvement > Components: client/server >Reporter: Masaki Yamakawa >Priority: Minor > > If you connect to a Geode cluster using a locator from the client, the > locator list request will be executed at regular intervals in the background > thread. I want to tune this interval. I understand that this interval can be > changed by the ping-interval of the Pool attribute. However, I think that > ping-interval originally sets the ping interval for health check to the cache > server. Therefore, it is not possible to change the locator list request > interval without changing the health check interval to the cache server. So,I > want to add a java system property that can change the locator list request > interval. > The locator list request interval is determined by the following priority > order. > 1. java system property "gemfire.LOCATOR_UPDATE_INTERVAL" > 2. ping-interval of the Pool attribute > In addition, when changing this time, the background thread is activated only > when this value is a positive value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2853) Change of locator list request interval
[ https://issues.apache.org/jira/browse/GEODE-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009296#comment-16009296 ] ASF GitHub Bot commented on GEODE-2853: --- Github user masaki-yamakawa commented on the issue: https://github.com/apache/geode/pull/483 I don't mind even if you don't complete by early next week. I would appreciate it if you can do it by the week after the next. > Change of locator list request interval > --- > > Key: GEODE-2853 > URL: https://issues.apache.org/jira/browse/GEODE-2853 > Project: Geode > Issue Type: Improvement > Components: client/server >Reporter: Masaki Yamakawa >Priority: Minor > > If you connect to a Geode cluster using a locator from the client, the > locator list request will be executed at regular intervals in the background > thread. I want to tune this interval. I understand that this interval can be > changed by the ping-interval of the Pool attribute. However, I think that > ping-interval originally sets the ping interval for health check to the cache > server. Therefore, it is not possible to change the locator list request > interval without changing the health check interval to the cache server. So,I > want to add a java system property that can change the locator list request > interval. > The locator list request interval is determined by the following priority > order. > 1. java system property "gemfire.LOCATOR_UPDATE_INTERVAL" > 2. ping-interval of the Pool attribute > In addition, when changing this time, the background thread is activated only > when this value is a positive value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2853) Change of locator list request interval
[ https://issues.apache.org/jira/browse/GEODE-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008401#comment-16008401 ] ASF GitHub Bot commented on GEODE-2853: --- Github user bschuchardt commented on the issue: https://github.com/apache/geode/pull/483 I will merge this pull request to develop. I may not get it done until early next week. > Change of locator list request interval > --- > > Key: GEODE-2853 > URL: https://issues.apache.org/jira/browse/GEODE-2853 > Project: Geode > Issue Type: Improvement > Components: client/server >Reporter: Masaki Yamakawa >Priority: Minor > > If you connect to a Geode cluster using a locator from the client, the > locator list request will be executed at regular intervals in the background > thread. I want to tune this interval. I understand that this interval can be > changed by the ping-interval of the Pool attribute. However, I think that > ping-interval originally sets the ping interval for health check to the cache > server. Therefore, it is not possible to change the locator list request > interval without changing the health check interval to the cache server. So,I > want to add a java system property that can change the locator list request > interval. > The locator list request interval is determined by the following priority > order. > 1. java system property "gemfire.LOCATOR_UPDATE_INTERVAL" > 2. ping-interval of the Pool attribute > In addition, when changing this time, the background thread is activated only > when this value is a positive value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2853) Change of locator list request interval
[ https://issues.apache.org/jira/browse/GEODE-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008238#comment-16008238 ] ASF GitHub Bot commented on GEODE-2853: --- Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/483#discussion_r116248082 --- Diff: geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java --- @@ -109,6 +110,7 @@ public void setUp() throws Exception { @After public void tearDown() { +System.clearProperty(DistributionConfig.GEMFIRE_PREFIX + "LOCATOR_UPDATE_INTERVAL"); --- End diff -- This can be replaced with `@Rule public final RestoreSystemProperties restoreSystemProperties = new RestoreSystemProperties();` > Change of locator list request interval > --- > > Key: GEODE-2853 > URL: https://issues.apache.org/jira/browse/GEODE-2853 > Project: Geode > Issue Type: Improvement > Components: client/server >Reporter: Masaki Yamakawa >Priority: Minor > > If you connect to a Geode cluster using a locator from the client, the > locator list request will be executed at regular intervals in the background > thread. I want to tune this interval. I understand that this interval can be > changed by the ping-interval of the Pool attribute. However, I think that > ping-interval originally sets the ping interval for health check to the cache > server. Therefore, it is not possible to change the locator list request > interval without changing the health check interval to the cache server. So,I > want to add a java system property that can change the locator list request > interval. > The locator list request interval is determined by the following priority > order. > 1. java system property "gemfire.LOCATOR_UPDATE_INTERVAL" > 2. ping-interval of the Pool attribute > In addition, when changing this time, the background thread is activated only > when this value is a positive value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2853) Change of locator list request interval
[ https://issues.apache.org/jira/browse/GEODE-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008156#comment-16008156 ] ASF GitHub Bot commented on GEODE-2853: --- Github user masaki-yamakawa commented on the issue: https://github.com/apache/geode/pull/483 I moved the test added to AutoConnectionSourceDUnitTest to AutoConnectionSourceImplJUnitTest, and revert AutoConnectionSourceDUnitTest. I tested by gradle precheckin. > Change of locator list request interval > --- > > Key: GEODE-2853 > URL: https://issues.apache.org/jira/browse/GEODE-2853 > Project: Geode > Issue Type: Improvement > Components: client/server >Reporter: Masaki Yamakawa >Priority: Minor > > If you connect to a Geode cluster using a locator from the client, the > locator list request will be executed at regular intervals in the background > thread. I want to tune this interval. I understand that this interval can be > changed by the ping-interval of the Pool attribute. However, I think that > ping-interval originally sets the ping interval for health check to the cache > server. Therefore, it is not possible to change the locator list request > interval without changing the health check interval to the cache server. So,I > want to add a java system property that can change the locator list request > interval. > The locator list request interval is determined by the following priority > order. > 1. java system property "gemfire.LOCATOR_UPDATE_INTERVAL" > 2. ping-interval of the Pool attribute > In addition, when changing this time, the background thread is activated only > when this value is a positive value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2853) Change of locator list request interval
[ https://issues.apache.org/jira/browse/GEODE-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004482#comment-16004482 ] ASF GitHub Bot commented on GEODE-2853: --- Github user masaki-yamakawa commented on the issue: https://github.com/apache/geode/pull/483 Thanks @bschuchardt @kirklund for review. Is this PR OK to merge? If it is possible to merge, I do not have the merge permission, so I would appreciate if you could please merge it. > Change of locator list request interval > --- > > Key: GEODE-2853 > URL: https://issues.apache.org/jira/browse/GEODE-2853 > Project: Geode > Issue Type: Improvement > Components: client/server >Reporter: Masaki Yamakawa >Priority: Minor > > If you connect to a Geode cluster using a locator from the client, the > locator list request will be executed at regular intervals in the background > thread. I want to tune this interval. I understand that this interval can be > changed by the ping-interval of the Pool attribute. However, I think that > ping-interval originally sets the ping interval for health check to the cache > server. Therefore, it is not possible to change the locator list request > interval without changing the health check interval to the cache server. So,I > want to add a java system property that can change the locator list request > interval. > The locator list request interval is determined by the following priority > order. > 1. java system property "gemfire.LOCATOR_UPDATE_INTERVAL" > 2. ping-interval of the Pool attribute > In addition, when changing this time, the background thread is activated only > when this value is a positive value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2853) Change of locator list request interval
[ https://issues.apache.org/jira/browse/GEODE-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997301#comment-15997301 ] ASF GitHub Bot commented on GEODE-2853: --- Github user masaki-yamakawa commented on the issue: https://github.com/apache/geode/pull/483 Thanks for the suggestion. I fixed that. @bschuchardt @kirklund > Change of locator list request interval > --- > > Key: GEODE-2853 > URL: https://issues.apache.org/jira/browse/GEODE-2853 > Project: Geode > Issue Type: Improvement > Components: client/server >Reporter: Masaki Yamakawa >Priority: Minor > > If you connect to a Geode cluster using a locator from the client, the > locator list request will be executed at regular intervals in the background > thread. I want to tune this interval. I understand that this interval can be > changed by the ping-interval of the Pool attribute. However, I think that > ping-interval originally sets the ping interval for health check to the cache > server. Therefore, it is not possible to change the locator list request > interval without changing the health check interval to the cache server. So,I > want to add a java system property that can change the locator list request > interval. > The locator list request interval is determined by the following priority > order. > 1. java system property "gemfire.LOCATOR_UPDATE_INTERVAL" > 2. ping-interval of the Pool attribute > In addition, when changing this time, the background thread is activated only > when this value is a positive value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2853) Change of locator list request interval
[ https://issues.apache.org/jira/browse/GEODE-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995876#comment-15995876 ] ASF GitHub Bot commented on GEODE-2853: --- Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/483#discussion_r114674582 --- Diff: geode-core/src/test/java/org/apache/geode/cache/client/internal/LocatorTestBase.java --- @@ -289,6 +289,13 @@ public void run() throws Exception { } } + protected void startBridgeClient(final String group, final String host, final int port, --- End diff -- +1 to Bruce's suggestion > Change of locator list request interval > --- > > Key: GEODE-2853 > URL: https://issues.apache.org/jira/browse/GEODE-2853 > Project: Geode > Issue Type: Improvement > Components: client/server >Reporter: Masaki Yamakawa >Priority: Minor > > If you connect to a Geode cluster using a locator from the client, the > locator list request will be executed at regular intervals in the background > thread. I want to tune this interval. I understand that this interval can be > changed by the ping-interval of the Pool attribute. However, I think that > ping-interval originally sets the ping interval for health check to the cache > server. Therefore, it is not possible to change the locator list request > interval without changing the health check interval to the cache server. So,I > want to add a java system property that can change the locator list request > interval. > The locator list request interval is determined by the following priority > order. > 1. java system property "gemfire.LOCATOR_UPDATE_INTERVAL" > 2. ping-interval of the Pool attribute > In addition, when changing this time, the background thread is activated only > when this value is a positive value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2853) Change of locator list request interval
[ https://issues.apache.org/jira/browse/GEODE-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995331#comment-15995331 ] ASF GitHub Bot commented on GEODE-2853: --- Github user bschuchardt commented on a diff in the pull request: https://github.com/apache/geode/pull/483#discussion_r114611067 --- Diff: geode-core/src/test/java/org/apache/geode/cache/client/internal/LocatorTestBase.java --- @@ -289,6 +289,13 @@ public void run() throws Exception { } } + protected void startBridgeClient(final String group, final String host, final int port, --- End diff -- Since this method is setting system properties I don't think it is appropriate to have it in LocatorTestBase. You should move it to AutoConnectionSourceDUnitTest and use the DistributedRestoreSystemProperties rule to ensure that the properties are cleaned up. To do that, add this to AutoConnectionSourceDUnitTest: @Rule public DistributedRestoreSystemProperties restoreSystemProperties = new DistributedRestoreSystemProperties(); > Change of locator list request interval > --- > > Key: GEODE-2853 > URL: https://issues.apache.org/jira/browse/GEODE-2853 > Project: Geode > Issue Type: Improvement > Components: client/server >Reporter: Masaki Yamakawa >Priority: Minor > > If you connect to a Geode cluster using a locator from the client, the > locator list request will be executed at regular intervals in the background > thread. I want to tune this interval. I understand that this interval can be > changed by the ping-interval of the Pool attribute. However, I think that > ping-interval originally sets the ping interval for health check to the cache > server. Therefore, it is not possible to change the locator list request > interval without changing the health check interval to the cache server. So,I > want to add a java system property that can change the locator list request > interval. > The locator list request interval is determined by the following priority > order. > 1. java system property "gemfire.LOCATOR_UPDATE_INTERVAL" > 2. ping-interval of the Pool attribute > In addition, when changing this time, the background thread is activated only > when this value is a positive value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-2853) Change of locator list request interval
[ https://issues.apache.org/jira/browse/GEODE-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990120#comment-15990120 ] ASF GitHub Bot commented on GEODE-2853: --- GitHub user masaki-yamakawa opened a pull request: https://github.com/apache/geode/pull/483 GEODE-2853: Change of locator list request interval If you connect to a Geode cluster using a locator from the client, the locator list request will be executed at regular intervals in the background thread. I want to tune this interval. I understand that this interval can be changed by the ping-interval of the Pool attribute. However, I think that ping-interval originally sets the ping interval for health check to the cache server. Therefore, it is not possible to change the locator list request interval without changing the health check interval to the cache server. So,I want to add a java system property that can change the locator list request interval. The locator list request interval is determined by the following priority order. 1. java system property "gemfire.LOCATOR_UPDATE_INTERVAL" 2. ping-interval of the Pool attribute In addition, when changing this time, the background thread is activated only when this value is a positive value. You can merge this pull request into a Git repository by running: $ git pull https://github.com/masaki-yamakawa/geode feature/GEODE-2853 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/483.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #483 commit f909d4fb7dcdf5dfc0f122663169324788fe5538 Author: masaki.yamakawaDate: 2017-04-30T04:38:10Z GEODE-2853: Change of locator list request interval If you connect to a Geode cluster using a locator from the client, the locator list request will be executed at regular intervals in the background thread. I want to tune this interval. I understand that this interval can be changed by the ping-interval of the Pool attribute. However, I think that ping-interval originally sets the ping interval for health check to the cache server. Therefore, it is not possible to change the locator list request interval without changing the health check interval to the cache server. So,I want to add a java system property that can change the locator list request interval. The locator list request interval is determined by the following priority order. 1. java system property "gemfire.LOCATOR_UPDATE_INTERVAL" 2. ping-interval of the Pool attribute In addition, when changing this time, the background thread is activated only when this value is a positive value. > Change of locator list request interval > --- > > Key: GEODE-2853 > URL: https://issues.apache.org/jira/browse/GEODE-2853 > Project: Geode > Issue Type: Improvement > Components: client/server >Reporter: Masaki Yamakawa >Priority: Minor > > If you connect to a Geode cluster using a locator from the client, the > locator list request will be executed at regular intervals in the background > thread. I want to tune this interval. I understand that this interval can be > changed by the ping-interval of the Pool attribute. However, I think that > ping-interval originally sets the ping interval for health check to the cache > server. Therefore, it is not possible to change the locator list request > interval without changing the health check interval to the cache server. So,I > want to add a java system property that can change the locator list request > interval. > The locator list request interval is determined by the following priority > order. > 1. java system property "gemfire.LOCATOR_UPDATE_INTERVAL" > 2. ping-interval of the Pool attribute > In addition, when changing this time, the background thread is activated only > when this value is a positive value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)