Re: Fix for ClassCastException when using Logback for 1.10.0

2019-08-08 Thread Owen Nichols
There appears to be consensus that this is a critical fix. The following commit has been brought into support/1.10.0 as the critical fix for GEODE-7050 : git cherry-pick -x

Re: Fix for ClassCastException when using Logback for 1.10.0

2019-08-08 Thread John Blum
+1 On Thu, Aug 8, 2019 at 11:31 AM Juan José Ramos wrote: > +1 > > On Thu, Aug 8, 2019 at 7:26 PM Mark Hanson wrote: > > > +1 > > > > I think it is valuable to make life easier for Spring Boot users. > > > > Thanks, > > Mark > > > > > On Aug 8, 2019, at 11:24 AM, Kirk Lund wrote: > > > > > >

Re: Fix for ClassCastException when using Logback for 1.10.0

2019-08-08 Thread Juan José Ramos
+1 On Thu, Aug 8, 2019 at 7:26 PM Mark Hanson wrote: > +1 > > I think it is valuable to make life easier for Spring Boot users. > > Thanks, > Mark > > > On Aug 8, 2019, at 11:24 AM, Kirk Lund wrote: > > > > This is the last logging related fix that I'd like to propose adding to > > 1.10.0 > >

Re: Fix for ClassCastException when using Logback for 1.10.0

2019-08-08 Thread Mark Hanson
+1 I think it is valuable to make life easier for Spring Boot users. Thanks, Mark > On Aug 8, 2019, at 11:24 AM, Kirk Lund wrote: > > This is the last logging related fix that I'd like to propose adding to > 1.10.0 > release branch. > > Spring Boot adds Logback and log4j-to-slf4j to the

Fix for ClassCastException when using Logback for 1.10.0

2019-08-08 Thread Kirk Lund
This is the last logging related fix that I'd like to propose adding to 1.10.0 release branch. Spring Boot adds Logback and log4j-to-slf4j to the classpath. This results in ClassCastExceptions if log4j-core is not excluded. This change prevents Geode from using Log4jAgent if Log4j Core is