Re: Fixing Awaitility await().untilAsserted(new WaitCriterion

2019-04-11 Thread Kirk Lund
I didn't realize anyone had added to the WaitCriterion interface. That explains why we don't have constant failures caused by this! Unfortunately, that means I didn't find a potential cause of flakiness in one of my tests. On Thu, Apr 11, 2019 at 12:20 PM Dan Smith wrote: > WaitCriterion

Re: Fixing Awaitility await().untilAsserted(new WaitCriterion

2019-04-11 Thread Dan Smith
WaitCriterion extends ThrowingRunnable. So this pattern should still work as WaitCriterion did before. But just using an assertion inside of a lambda is the better option. -Dan On Thu, Apr 11, 2019 at 12:02 PM Kirk Lund wrote: > Just a quick heads up... I'm seeing an Awaitility usage pattern

Fixing Awaitility await().untilAsserted(new WaitCriterion

2019-04-11 Thread Kirk Lund
Just a quick heads up... I'm seeing an Awaitility usage pattern that is broken and does nothing. Specifically, it's any uses of dunit WaitCriterion with untilAsserted: GeodeAwaitility.*await().untilAsserted(new WaitCriterion*() { @Override public boolean done() {