Re: GEODE-6662 for 1.9.0

2019-04-17 Thread Bruce Schuchardt
I've cherry-picked the fix into release/1.9.0 On 4/17/19 1:22 PM, Lynn Hughes-Godfrey wrote: +1 to Bruce & Anthony's suggestion to fix it. GemFire servers are meant to be long running processes. On Wed, Apr 17, 2019 at 12:09 PM Jacob Barrett wrote: If it Leakes on object overt the life of

Re: GEODE-6662 for 1.9.0

2019-04-17 Thread Lynn Hughes-Godfrey
+1 to Bruce & Anthony's suggestion to fix it. GemFire servers are meant to be long running processes. On Wed, Apr 17, 2019 at 12:09 PM Jacob Barrett wrote: > If it Leakes on object overt the life of the application, no biggy. If it > leaks an object frequently, say every time you call get,

Re: GEODE-6662 for 1.9.0

2019-04-17 Thread Jacob Barrett
If it Leakes on object overt the life of the application, no biggy. If it leaks an object frequently, say every time you call get, then fixxy. -Jake > On Apr 17, 2019, at 12:05 PM, Anthony Baker wrote: > > If a geode process leaks memory, I think that’s a critical issue. > > Anthony > >

Re: GEODE-6662 for 1.9.0

2019-04-17 Thread Anthony Baker
If a geode process leaks memory, I think that’s a critical issue. Anthony > On Apr 17, 2019, at 11:45 AM, Udo Kohlmeyer wrote: > > Unless this is a critical issue I'd vote -1 for including this. > > The process to release 1.9 has already been started and should be closed to > anything

Re: GEODE-6662 for 1.9.0

2019-04-17 Thread Bruce Schuchardt
This leak could cause a long running server to run out of direct-buffer memory, especially if conserve-sockets=false. On 4/17/19 11:45 AM, Udo Kohlmeyer wrote: Unless this is a critical issue I'd vote -1 for including this. The process to release 1.9 has already been started and should be

Re: GEODE-6662 for 1.9.0

2019-04-17 Thread Udo Kohlmeyer
Unless this is a critical issue I'd vote -1 for including this. The process to release 1.9 has already been started and should be closed to anything other than critical CVE's. --Udo On 4/17/19 11:30, Bruce Schuchardt wrote: I'd like to include the fix for this memory leak that Darrel found.

GEODE-6662 for 1.9.0

2019-04-17 Thread Bruce Schuchardt
I'd like to include the fix for this memory leak that Darrel found.  It's new in 1.9 and the fix is pretty simple - I'm putting up a PR now.