Re: Proposal to backport GEODE-8395 (gfsh help banner) to support branches

2020-08-03 Thread Mark Bretl
I would vote for 1.13 since that is still up for release, however, I do not
see a need for 1.12 as it is not a critical issue.

--Mark

On Mon, Aug 3, 2020 at 9:00 AM Dave Barnes  wrote:

> Hard to believe this problem was still hanging around. Definitely
> back-port, the sooner, the better.
>
> On Mon, Aug 3, 2020 at 7:56 AM Dave Barnes  wrote:
>
> > +1
> >
> >
> > On Sun, Aug 2, 2020 at 7:07 AM Donal Evans  wrote:
> >
> >> +1
> >>
> >> Nice catch!
> >>
> >> Get Outlook for Android<https://aka.ms/ghei36>
> >>
> >> 
> >> From: Jinmei Liao 
> >> Sent: Saturday, August 1, 2020 11:09:45 PM
> >> To: dev@geode.apache.org 
> >> Subject: Re: Proposal to backport GEODE-8395 (gfsh help banner) to
> >> support branches
> >>
> >> +1
> >>
> >> On Aug 1, 2020 10:30 PM, Owen Nichols  wrote:
> >> This issue was present since Geode 1.0.  There is zero risk from this
> >> fix, which is already on develop.  It is critical because Geode releases
> >> are a legal Act of the Apache Foundation and should not misrepresent the
> >> identity of the project.
> >>
> >> Here’s the issue:
> >>
> >> $ gfsh
> >> _ __
> >>/ _/ __/ __/ // /
> >>   / /  __/ /___  /_  / _  /
> >> / /__/ / /  _/ / // /
> >> /__/_/  /__/_//_/1.12.0
> >>
> >> Monitor and Manage Apache Geode<-- right product name
> >>
> >> $gfsh --help
> >> Pivotal GemFire(R) v1.12.0 Command Line Shell   <-- WRONG product name
> >>
> >> The “right” instance above was fixed 5 years ago.  GEODE-8395 fixes gfsh
> >> to use the “right” code in both places.  Please vote +1 to backport this
> >> fix to support/1.13 and support/1.12.
> >>
> >>
> >>
>


Re: Proposal to backport GEODE-8395 (gfsh help banner) to support branches

2020-08-03 Thread Dave Barnes
Hard to believe this problem was still hanging around. Definitely
back-port, the sooner, the better.

On Mon, Aug 3, 2020 at 7:56 AM Dave Barnes  wrote:

> +1
>
>
> On Sun, Aug 2, 2020 at 7:07 AM Donal Evans  wrote:
>
>> +1
>>
>> Nice catch!
>>
>> Get Outlook for Android<https://aka.ms/ghei36>
>>
>> 
>> From: Jinmei Liao 
>> Sent: Saturday, August 1, 2020 11:09:45 PM
>> To: dev@geode.apache.org 
>> Subject: Re: Proposal to backport GEODE-8395 (gfsh help banner) to
>> support branches
>>
>> +1
>>
>> On Aug 1, 2020 10:30 PM, Owen Nichols  wrote:
>> This issue was present since Geode 1.0.  There is zero risk from this
>> fix, which is already on develop.  It is critical because Geode releases
>> are a legal Act of the Apache Foundation and should not misrepresent the
>> identity of the project.
>>
>> Here’s the issue:
>>
>> $ gfsh
>> _ __
>>/ _/ __/ __/ // /
>>   / /  __/ /___  /_  / _  /
>> / /__/ / /  _/ / // /
>> /__/_/  /__/_//_/1.12.0
>>
>> Monitor and Manage Apache Geode<-- right product name
>>
>> $gfsh --help
>> Pivotal GemFire(R) v1.12.0 Command Line Shell   <-- WRONG product name
>>
>> The “right” instance above was fixed 5 years ago.  GEODE-8395 fixes gfsh
>> to use the “right” code in both places.  Please vote +1 to backport this
>> fix to support/1.13 and support/1.12.
>>
>>
>>


Odg: Proposal to backport GEODE-8395 (gfsh help banner) to support branches

2020-08-03 Thread Mario Kevo
+1

Šalje: Dave Barnes 
Poslano: 3. kolovoza 2020. 16:56
Prima: dev@geode.apache.org 
Predmet: Re: Proposal to backport GEODE-8395 (gfsh help banner) to support 
branches

+1


On Sun, Aug 2, 2020 at 7:07 AM Donal Evans  wrote:

> +1
>
> Nice catch!
>
> Get Outlook for Android<https://aka.ms/ghei36>
>
> 
> From: Jinmei Liao 
> Sent: Saturday, August 1, 2020 11:09:45 PM
> To: dev@geode.apache.org 
> Subject: Re: Proposal to backport GEODE-8395 (gfsh help banner) to support
> branches
>
> +1
>
> On Aug 1, 2020 10:30 PM, Owen Nichols  wrote:
> This issue was present since Geode 1.0.  There is zero risk from this fix,
> which is already on develop.  It is critical because Geode releases are a
> legal Act of the Apache Foundation and should not misrepresent the identity
> of the project.
>
> Here’s the issue:
>
> $ gfsh
> _ __
>/ _/ __/ __/ // /
>   / /  __/ /___  /_  / _  /
> / /__/ / /  _/ / // /
> /__/_/  /__/_//_/1.12.0
>
> Monitor and Manage Apache Geode<-- right product name
>
> $gfsh --help
> Pivotal GemFire(R) v1.12.0 Command Line Shell   <-- WRONG product name
>
> The “right” instance above was fixed 5 years ago.  GEODE-8395 fixes gfsh
> to use the “right” code in both places.  Please vote +1 to backport this
> fix to support/1.13 and support/1.12.
>
>
>


Re: Proposal to backport GEODE-8395 (gfsh help banner) to support branches

2020-08-03 Thread Dave Barnes
+1


On Sun, Aug 2, 2020 at 7:07 AM Donal Evans  wrote:

> +1
>
> Nice catch!
>
> Get Outlook for Android<https://aka.ms/ghei36>
>
> 
> From: Jinmei Liao 
> Sent: Saturday, August 1, 2020 11:09:45 PM
> To: dev@geode.apache.org 
> Subject: Re: Proposal to backport GEODE-8395 (gfsh help banner) to support
> branches
>
> +1
>
> On Aug 1, 2020 10:30 PM, Owen Nichols  wrote:
> This issue was present since Geode 1.0.  There is zero risk from this fix,
> which is already on develop.  It is critical because Geode releases are a
> legal Act of the Apache Foundation and should not misrepresent the identity
> of the project.
>
> Here’s the issue:
>
> $ gfsh
> _ __
>/ _/ __/ __/ // /
>   / /  __/ /___  /_  / _  /
> / /__/ / /  _/ / // /
> /__/_/  /__/_//_/1.12.0
>
> Monitor and Manage Apache Geode<-- right product name
>
> $gfsh --help
> Pivotal GemFire(R) v1.12.0 Command Line Shell   <-- WRONG product name
>
> The “right” instance above was fixed 5 years ago.  GEODE-8395 fixes gfsh
> to use the “right” code in both places.  Please vote +1 to backport this
> fix to support/1.13 and support/1.12.
>
>
>


Re: Proposal to backport GEODE-8395 (gfsh help banner) to support branches

2020-08-02 Thread Donal Evans
+1

Nice catch!

Get Outlook for Android<https://aka.ms/ghei36>


From: Jinmei Liao 
Sent: Saturday, August 1, 2020 11:09:45 PM
To: dev@geode.apache.org 
Subject: Re: Proposal to backport GEODE-8395 (gfsh help banner) to support 
branches

+1

On Aug 1, 2020 10:30 PM, Owen Nichols  wrote:
This issue was present since Geode 1.0.  There is zero risk from this fix, 
which is already on develop.  It is critical because Geode releases are a legal 
Act of the Apache Foundation and should not misrepresent the identity of the 
project.

Here’s the issue:

$ gfsh
_ __
   / _/ __/ __/ // /
  / /  __/ /___  /_  / _  /
/ /__/ / /  _/ / // /
/__/_/  /__/_//_/1.12.0

Monitor and Manage Apache Geode<-- right product name

$gfsh --help
Pivotal GemFire(R) v1.12.0 Command Line Shell   <-- WRONG product name

The “right” instance above was fixed 5 years ago.  GEODE-8395 fixes gfsh to use 
the “right” code in both places.  Please vote +1 to backport this fix to 
support/1.13 and support/1.12.




Re: Proposal to backport GEODE-8395 (gfsh help banner) to support branches

2020-08-02 Thread Jinmei Liao
+1

On Aug 1, 2020 10:30 PM, Owen Nichols  wrote:
This issue was present since Geode 1.0.  There is zero risk from this fix, 
which is already on develop.  It is critical because Geode releases are a legal 
Act of the Apache Foundation and should not misrepresent the identity of the 
project.

Here’s the issue:

$ gfsh
_ __
   / _/ __/ __/ // /
  / /  __/ /___  /_  / _  /
/ /__/ / /  _/ / // /
/__/_/  /__/_//_/1.12.0

Monitor and Manage Apache Geode<-- right product name

$gfsh --help
Pivotal GemFire(R) v1.12.0 Command Line Shell   <-- WRONG product name

The “right” instance above was fixed 5 years ago.  GEODE-8395 fixes gfsh to use 
the “right” code in both places.  Please vote +1 to backport this fix to 
support/1.13 and support/1.12.




Proposal to backport GEODE-8395 (gfsh help banner) to support branches

2020-08-01 Thread Owen Nichols
This issue was present since Geode 1.0.  There is zero risk from this fix, 
which is already on develop.  It is critical because Geode releases are a legal 
Act of the Apache Foundation and should not misrepresent the identity of the 
project.

Here’s the issue:

$ gfsh
_ __
   / _/ __/ __/ // /
  / /  __/ /___  /_  / _  /
/ /__/ / /  _/ / // /
/__/_/  /__/_//_/1.12.0

Monitor and Manage Apache Geode<-- right product name

$gfsh --help
Pivotal GemFire(R) v1.12.0 Command Line Shell   <-- WRONG product name

The “right” instance above was fixed 5 years ago.  GEODE-8395 fixes gfsh to use 
the “right” code in both places.  Please vote +1 to backport this fix to 
support/1.13 and support/1.12.