geode repo) but it seems github does not allow to configure draft
PRs as default option for a given repository.
De: Mark Hanson
Enviado: viernes, 7 de mayo de 2021 23:06
Para: dev@geode.apache.org ; Blake Bender
Asunto: Re: Reminder to use
Para: dev@geode.apache.org ; Blake Bender
Asunto: Re: Reminder to use draft mode
Correct me if I am wrong, but I think the basic consensus here is that the
starting state for all PRs should be draft. We should change the default if we
can... The sticky part is when to put a PR from standard
Subject: RE: Reminder to use draft mode
+1 to Mark's proposal of setting draft mode as default when creating
PRs (Im wondering if a new VOTE thread is needed to approve it)
And also +1 to Donal's comments.
De: Darrel Schneider
ante Reyes
Sent: Thursday, May 6, 2021 1:19 PM
To: dev@geode.apache.org
Subject: RE: Reminder to use draft mode
+1 to Mark's proposal of setting draft mode as default when creating PRs
(Im wondering if a new VOTE thread is needed to approve it)
And also +1 to Donal'
Message-
From: Alberto Bustamante Reyes
Sent: Thursday, May 6, 2021 1:19 PM
To: dev@geode.apache.org
Subject: RE: Reminder to use draft mode
+1 to Mark's proposal of setting draft mode as default when creating PRs (Im
wondering if a new VOTE thread is needed to approve it)
And also +1
Side note: I think using discussion to achieve consensus on topics like this
tends to work better than [VOTE] threads. If we fail to reach a consensus we
can resort to a vote thread, or for reasons spelled out in [1].
IMHO,
Anthony
[1] https://www.apache.org/foundation/voting.html
On May
Asunto: Re: Reminder to use draft mode
+1 to Donal's comments
From: Donal Evans
Sent: Thursday, May 6, 2021 11:44 AM
To: dev@geode.apache.org
Subject: Re: Reminder to use draft mode
+1 to Naba's PR flow described above.
Creating PRs in draft mode is almost always
+1 to Donal's comments
From: Donal Evans
Sent: Thursday, May 6, 2021 11:44 AM
To: dev@geode.apache.org
Subject: Re: Reminder to use draft mode
+1 to Naba's PR flow described above.
Creating PRs in draft mode is almost always the best choice, as it prevents
ng back to draft mode would probably be a
good idea.
Donal
From: Nabarun Nag
Sent: Thursday, May 6, 2021 10:22 AM
To: dev@geode.apache.org
Subject: Re: Reminder to use draft mode
I feel that Owen has a valid point and I myself feel that it is ok to start the
PR in draft mode till th
Hanson
Date: Thursday, May 6, 2021 at 10:45 AM
To: dev@geode.apache.org
Subject: Re: Reminder to use draft mode
I agree, I like the draft mode switch. The hesitations that I have are
mentioned by Jens in that you can have failures that are unrelated. Especially
DUnits at this point. Perhaps
- reviewers assigned
* reviewers review
Regards
Naba
From: Owen Nichols
Sent: Thursday, May 6, 2021 9:59 AM
To: dev@geode.apache.org
Subject: Re: Reminder to use draft mode
Given the lack of conse
ers review
Regards
Naba
From: Owen Nichols
Sent: Thursday, May 6, 2021 9:59 AM
To: dev@geode.apache.org
Subject: Re: Reminder to use draft mode
Given the lack of consensus, it sounds like it will not be possible to make
any a
code
* tests pass - all green
* convert PR to ready for review - reviewers assigned
* reviewers review
Regards
Naba
From: Owen Nichols
Sent: Thursday, May 6, 2021 9:59 AM
To: dev@geode.apache.org
Subject: Re: Reminder to use draft mode
Given
apache.org
Subject: Re: Reminder to use draft mode
A PR in "Draft" mode simply conveys that at least one more commit is coming
before it will be "done". Reviewers generously volunteer their time to look at
your PR, and are welcome to look at it while in draft mode if the
decisions on our behalf.
Has some situation arisen that is driving this? It feels like there is some
underlying issue that isn’t being fully communicated.
--Jens
From: Owen Nichols
Date: Thursday, May 6, 2021 at 9:12 AM
To: dev@geode.apache.org
Subject: Re: Reminder to use draft mode
A PR in "
A PR in "Draft" mode simply conveys that at least one more commit is coming
before it will be "done". Reviewers generously volunteer their time to look at
your PR, and are welcome to look at it while in draft mode if they wish, but if
they are quite busy, some may prefer to wait until the PR
Comments inline…
Please keep your PR in draft mode anytime it is not ready to be reviewed.
This includes if you have received request for changes, or if any PR checks are
not passing.
How do I know if everyone is done reviewing? Or even who might be reviewing?
Different reviewers may be
Please keep your PR in draft mode anytime it is not ready to be reviewed.
This includes if you have received request for changes, or if any PR checks are
not passing.
If you’re reviewing someone’s PR, and notice any checks not passing or you are
requesting changes, please also click “Convert
18 matches
Mail list logo
