Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

2017-01-27 Thread Jason Huynh
> On Jan. 27, 2017, 7:22 p.m., nabarun nag wrote: > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java, > > line 62 > > > > > > Can a call to afterSecondary at this point

Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

2017-01-27 Thread Jason Huynh
> On Jan. 27, 2017, 6:48 p.m., nabarun nag wrote: > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LucenePrimaryBucketListener.java, > > line 57 > > > > > > We should now change the name of the f

Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

2017-01-27 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55956/#review163316 --- Ship it! Ship It! - nabarun nag On Jan. 27, 2017, 7:05 a.m.,

Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

2017-01-27 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55956/#review163317 --- Ship it! Ship It! - nabarun nag On Jan. 27, 2017, 7:05 a.m.,

Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

2017-01-27 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55956/#review163315 --- geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal

Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

2017-01-27 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55956/#review163299 --- geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal

Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

2017-01-26 Thread Jason Huynh
> On Jan. 25, 2017, 9:59 p.m., Dan Smith wrote: > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java, > > line 64 > > > > > > This may somehow need to be synchronized with

Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

2017-01-26 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55956/ --- (Updated Jan. 27, 2017, 7:05 a.m.) Review request for geode, Barry Oglesby, nab

Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

2017-01-25 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55956/#review163079 --- Ship it! Looks good. I think the synchronization issues I menti

Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

2017-01-25 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55956/ --- (Updated Jan. 26, 2017, 1:15 a.m.) Review request for geode, Barry Oglesby, nab

Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

2017-01-25 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55956/#review163019 --- Hey, Looks like this is a big improvement on the reliability of t

Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

2017-01-25 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55956/ --- Review request for geode, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zh