Re: Review Request 58891: GEODE-2837: Start server creates specified working dir if necessary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58891/ --- (Updated May 2, 2017, 4:03 p.m.) Review request for geode, Jinmei Liao, Ken Howe, Kirk Lund, and Patrick Rhomberg. Repository: geode Description --- GEODE-2837: Start server creates specified working dir if necessary Diffs - geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java b51505a geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 0e681d7 geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java a793235 Diff: https://reviews.apache.org/r/58891/diff/2/ Testing (updated) --- Precheckin passed Thanks, Jared Stewart
Re: Review Request 58891: GEODE-2837: Start server creates specified working dir if necessary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58891/#review173551 --- Ship it! Ship It! - Jinmei Liao On May 1, 2017, 10:16 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58891/ > --- > > (Updated May 1, 2017, 10:16 p.m.) > > > Review request for geode, Jinmei Liao, Ken Howe, Kirk Lund, and Patrick > Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-2837: Start server creates specified working dir if necessary > > > Diffs > - > > > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java > b51505a > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java > 0e681d7 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java > a793235 > > > Diff: https://reviews.apache.org/r/58891/diff/2/ > > > Testing > --- > > Precheckin started (still running) > > > Thanks, > > Jared Stewart > >
Re: Review Request 58891: GEODE-2837: Start server creates specified working dir if necessary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58891/ --- (Updated May 1, 2017, 10:16 p.m.) Review request for geode, Jinmei Liao, Ken Howe, Kirk Lund, and Patrick Rhomberg. Changes --- Added test to verify behavior when the working dir is specified as a relative path. Repository: geode Description --- GEODE-2837: Start server creates specified working dir if necessary Diffs (updated) - geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java b51505a geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 0e681d7 geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java a793235 Diff: https://reviews.apache.org/r/58891/diff/2/ Changes: https://reviews.apache.org/r/58891/diff/1-2/ Testing --- Precheckin started (still running) Thanks, Jared Stewart
