Re: Review Request 59893: GEODE-3032: Fix CI failure of CommandOverHttpDUnitTest

2017-06-08 Thread Ken Howe

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59893/#review177303
---


Ship it!




Ship It!

- Ken Howe


On June 7, 2017, 11:13 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59893/
> ---
> 
> (Updated June 7, 2017, 11:13 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3032: Fix CI failure of CommandOverHttpDUnitTest
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MemberCommandsDUnitTest.java
>  5bbfc5b 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java
>  2a6a03b 
> 
> 
> Diff: https://reviews.apache.org/r/59893/diff/2/
> 
> 
> Testing
> ---
> 
> Precheckin is green except for unrelated flaky DUnits.
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>



Re: Review Request 59893: GEODE-3032: Fix CI failure of CommandOverHttpDUnitTest

2017-06-07 Thread Jinmei Liao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59893/#review177251
---


Ship it!




Ship It!

- Jinmei Liao


On June 7, 2017, 11:13 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59893/
> ---
> 
> (Updated June 7, 2017, 11:13 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3032: Fix CI failure of CommandOverHttpDUnitTest
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MemberCommandsDUnitTest.java
>  5bbfc5b 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java
>  2a6a03b 
> 
> 
> Diff: https://reviews.apache.org/r/59893/diff/2/
> 
> 
> Testing
> ---
> 
> Precheckin is green except for unrelated flaky DUnits.
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>



Re: Review Request 59893: GEODE-3032: Fix CI failure of CommandOverHttpDUnitTest

2017-06-07 Thread Jared Stewart

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59893/
---

(Updated June 7, 2017, 11:13 p.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Changes
---

Upon further exception, MemberCommandsDUnitTest doesn't even read the "useHTTP" 
system property being set by the CommandOverHttpDUnitTest Suite.  As such, we 
can simply remove it from the suite.


Repository: geode


Description
---

GEODE-3032: Fix CI failure of CommandOverHttpDUnitTest


Diffs (updated)
-

  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MemberCommandsDUnitTest.java
 5bbfc5b 
  
geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java
 2a6a03b 


Diff: https://reviews.apache.org/r/59893/diff/2/

Changes: https://reviews.apache.org/r/59893/diff/1-2/


Testing
---

Precheckin is green except for unrelated flaky DUnits.


Thanks,

Jared Stewart



Re: Review Request 59893: GEODE-3032: Fix CI failure of CommandOverHttpDUnitTest

2017-06-07 Thread Jinmei Liao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59893/#review177248
---


Ship it!




Ship It!

- Jinmei Liao


On June 7, 2017, 9:08 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59893/
> ---
> 
> (Updated June 7, 2017, 9:08 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3032: Fix CI failure of CommandOverHttpDUnitTest
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MemberCommandsDUnitTest.java
>  5bbfc5b3d4ba1a37f8c1e700a36bd96b4ea40667 
> 
> 
> Diff: https://reviews.apache.org/r/59893/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin is green except for unrelated flaky DUnits.
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>



Re: Review Request 59893: GEODE-3032: Fix CI failure of CommandOverHttpDUnitTest

2017-06-07 Thread Emily Yeh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59893/#review177237
---


Ship it!




Ship It!

- Emily Yeh


On June 7, 2017, 9:08 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59893/
> ---
> 
> (Updated June 7, 2017, 9:08 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3032: Fix CI failure of CommandOverHttpDUnitTest
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MemberCommandsDUnitTest.java
>  5bbfc5b3d4ba1a37f8c1e700a36bd96b4ea40667 
> 
> 
> Diff: https://reviews.apache.org/r/59893/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin is green except for unrelated flaky DUnits.
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>



Review Request 59893: GEODE-3032: Fix CI failure of CommandOverHttpDUnitTest

2017-06-07 Thread Jared Stewart

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59893/
---

Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

GEODE-3032: Fix CI failure of CommandOverHttpDUnitTest


Diffs
-

  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MemberCommandsDUnitTest.java
 5bbfc5b3d4ba1a37f8c1e700a36bd96b4ea40667 


Diff: https://reviews.apache.org/r/59893/diff/1/


Testing
---

Precheckin is green except for unrelated flaky DUnits.


Thanks,

Jared Stewart