Re: Review Request 59896: GEODE-3043 surprise member added when the member is already in the cluster

[Brian Rowe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59896/#review177375
---


Ship it!




Ship It!

- Brian Rowe


On June 7, 2017, 10:02 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59896/
> ---
> 
> (Updated June 7, 2017, 10:02 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Bugs: GEODE-3043
> https://issues.apache.org/jira/browse/GEODE-3043
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Modified InternalDistributedMember to disregard the "name" field in compareTo 
> if partial IDs are being used in the comparison.
> 
> Modified GMSMembershipManager to attempt to replace partial IDs with the full 
> IDs from the membership view.  Typically these IDs will cause no problems and 
> methods in GMSMembershipManager that send messages to a recipient will also 
> attempt to replace the ID with a full ID from the membership view, but it's 
> good to try to keep IDs canonical.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java
>  6982d31f13ad5f5f004f0e7c9a0f4e1aa26a151a 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMember.java
>  c82d97e9facca19bfb08b20407abf21dd274684e 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
>  fe560d9eb71131cf1ca5e5ca124e877769e9d518 
>   
> geode-core/src/test/java/org/apache/geode/distributed/DistributedMemberDUnitTest.java
>  0153ca6506af574798ad01b98d9a395fad7be5d5 
> 
> 
> Diff: https://reviews.apache.org/r/59896/diff/1/
> 
> 
> Testing
> ---
> 
> New tests, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 59896: GEODE-3043 surprise member added when the member is already in the cluster

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59896/#review177249
---


Ship it!




Ship It!


geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
Lines 1137 (patched)


Can this feasibly return a partial? Looking at the code it might be able 
to. Is this correct behaviour?


- Udo Kohlmeyer


On June 7, 2017, 10:02 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59896/
> ---
> 
> (Updated June 7, 2017, 10:02 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Bugs: GEODE-3043
> https://issues.apache.org/jira/browse/GEODE-3043
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Modified InternalDistributedMember to disregard the "name" field in compareTo 
> if partial IDs are being used in the comparison.
> 
> Modified GMSMembershipManager to attempt to replace partial IDs with the full 
> IDs from the membership view.  Typically these IDs will cause no problems and 
> methods in GMSMembershipManager that send messages to a recipient will also 
> attempt to replace the ID with a full ID from the membership view, but it's 
> good to try to keep IDs canonical.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java
>  6982d31f13ad5f5f004f0e7c9a0f4e1aa26a151a 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMember.java
>  c82d97e9facca19bfb08b20407abf21dd274684e 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
>  fe560d9eb71131cf1ca5e5ca124e877769e9d518 
>   
> geode-core/src/test/java/org/apache/geode/distributed/DistributedMemberDUnitTest.java
>  0153ca6506af574798ad01b98d9a395fad7be5d5 
> 
> 
> Diff: https://reviews.apache.org/r/59896/diff/1/
> 
> 
> Testing
> ---
> 
> New tests, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Review Request 59896: GEODE-3043 surprise member added when the member is already in the cluster

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59896/
---

Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh Khamesra, 
Udo Kohlmeyer, and Brian Rowe.


Bugs: GEODE-3043
https://issues.apache.org/jira/browse/GEODE-3043


Repository: geode


Description
---

Modified InternalDistributedMember to disregard the "name" field in compareTo 
if partial IDs are being used in the comparison.

Modified GMSMembershipManager to attempt to replace partial IDs with the full 
IDs from the membership view.  Typically these IDs will cause no problems and 
methods in GMSMembershipManager that send messages to a recipient will also 
attempt to replace the ID with a full ID from the membership view, but it's 
good to try to keep IDs canonical.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java
 6982d31f13ad5f5f004f0e7c9a0f4e1aa26a151a 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMember.java
 c82d97e9facca19bfb08b20407abf21dd274684e 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
 fe560d9eb71131cf1ca5e5ca124e877769e9d518 
  
geode-core/src/test/java/org/apache/geode/distributed/DistributedMemberDUnitTest.java
 0153ca6506af574798ad01b98d9a395fad7be5d5 


Diff: https://reviews.apache.org/r/59896/diff/1/


Testing
---

New tests, precheckin


Thanks,

Bruce Schuchardt