Re: Review Request 60523: GEODE-3141 New flow: GetRegion

2017-07-13 Thread Alexander Murmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60523/#review180447 ---

Re: Review Request 60523: GEODE-3141 New flow: GetRegion

2017-06-29 Thread Bruce Schuchardt
> On June 28, 2017, 6:24 p.m., Udo Kohlmeyer wrote: > > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandler.java > > Lines 42 (patched) > > > > > > Does this

Re: Review Request 60523: GEODE-3141 New flow: GetRegion

2017-06-29 Thread Bruce Schuchardt
> On June 28, 2017, 4:39 p.m., Brian Rowe wrote: > > geode-protobuf/src/main/proto/region_API.proto > > Lines 119 (patched) > > > > > > I think it'd be cleaner to add these fields to the Region protobuf > > object

Re: Review Request 60523: GEODE-3141 New flow: GetRegion

2017-06-29 Thread Bruce Schuchardt
> On June 28, 2017, 6:27 p.m., Udo Kohlmeyer wrote: > > geode-protobuf/src/main/proto/region_API.proto > > Lines 117 (patched) > > > > > > What does this service do? Just check if a region exists? If so, should > >

Re: Review Request 60523: GEODE-3141 New flow: GetRegion

2017-06-28 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60523/#review179218 --- geode-protobuf/src/main/proto/region_API.proto Lines 117

Re: Review Request 60523: GEODE-3141 New flow: GetRegion

2017-06-28 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60523/#review179217 ---

Re: Review Request 60523: GEODE-3141 New flow: GetRegion

2017-06-28 Thread Brian Rowe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60523/#review179202 ---

Re: Review Request 60523: GEODE-3141 New flow: GetRegion

2017-06-28 Thread Alexander Murmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60523/#review179201 --- Ship it! Ship It! - Alexander Murmann On June 28, 2017,

Review Request 60523: GEODE-3141 New flow: GetRegion

2017-06-28 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60523/ --- Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh Khamesra,