Re: Test coverage and PRs

2019-04-16 Thread Helena Bales
+1 On Tue, Apr 16, 2019 at 1:33 AM Juan José Ramos wrote: > +1 > > On Mon, Apr 15, 2019 at 11:22 PM Alexander Murmann > wrote: > > > Hi everyone, > > > > TL;DR: > > 1. Let's call each other out on our PRs when test coverage is missing or > > insufficient > > 2. Let's require test coverage for c

Re: Test coverage and PRs

2019-04-16 Thread Juan José Ramos
+1 On Mon, Apr 15, 2019 at 11:22 PM Alexander Murmann wrote: > Hi everyone, > > TL;DR: > 1. Let's call each other out on our PRs when test coverage is missing or > insufficient > 2. Let's require test coverage for code that gets refactored as well > > We already have a really great wiki page > <

Test coverage and PRs

2019-04-15 Thread Alexander Murmann
Hi everyone, TL;DR: 1. Let's call each other out on our PRs when test coverage is missing or insufficient 2. Let's require test coverage for code that gets refactored as well We already have a really great wiki page