Re: build is broken on develop

[Sai Boorlagadda]

I fixed the build. My apologies I didn't rebase before merging my PR.

On Tue, Feb 26, 2019 at 12:33 PM Sai Boorlagadda 
wrote:

> My commit broke the build on develop. I am on it.
>
>

build is broken on develop

[Sai Boorlagadda]

My commit broke the build on develop. I am on it.

Re: build is broken

[Anthony Baker]

There was a PR for these changes:  https://github.com/apache/geode/pull/1212 


I didn’t comment on the PR but I did review the dependency for license 
compatibility (it’s ASL 2.0).

Anthony


> On Jan 23, 2018, at 2:29 PM, Mark Bretl  wrote:
> 
> I agree with Kirk. A simple notice to the dev list to say what dependency
> and why it is being added, this would also be an opportunity to make sure
> the dependency is not using a Cat-X license [1].
> 
> --Mark
> 
> [1] https://www.apache.org/legal/resolved.html#category-x
> 
> On Tue, Jan 23, 2018 at 2:09 PM, Kirk Lund  wrote:
> 
>> Discussing the addition of new dependencies is something the community
>> should be doing on the dev-list regardless of how many git repos we have.
>> It's part of the Apache Way that we are beholden to as an Apache project.
>> 
>> On Tue, Jan 23, 2018 at 11:25 AM, Udo Kohlmeyer 
>> wrote:
>> 
>>> This really just another reason that we should be pushing for the
>>> separation of Geode into different (independent) modules with potentially
>>> separate repos.
>>> This way modules can advance and iterate faster without having to be
>>> influenced by external factors causing unrelated failures.
>>> 
>>> I would push for this, rather than having to slow the whole development
>>> process down, whilst waiting for consensus on libraries used for external
>>> tooling.
>>> 
>>> --Udo
>>> 
>>> On Tue, Jan 23, 2018 at 11:15 AM, Kirk Lund  wrote:
>>> 
 I have it working now. My IntelliJ project was using JDK1.8.0_66 for
>>> Gradle
 which prevented updating of dependencies which then caused compilation
>> in
 IntelliJ to fail on that new dependency.
 
 This doesn't resolve my main issue here which is this: *all new
 dependencies should be discussed on the dev list before introducing
>> them
>>> in
 a commit*. Can you please point me at an email that proposes adding
>> this
 dependency?
 
 On Tue, Jan 23, 2018 at 10:10 AM, Anthony Baker 
>>> wrote:
 
> I just ran `gradle clean build` from HEAD and did not get any errors.
> 
>> On Jan 23, 2018, at 10:08 AM, Jens Deppe 
>> wrote:
>> 
>> The dependency is the rmi-io library. It provides functionality for
>> streaming data over RMI.
>> 
>> It was added a few weeks ago, so I'm not sure why your build is
 breaking
>> now.
>> 
>> --Jens
>> 
>> On Tue, Jan 23, 2018 at 9:41 AM, Kirk Lund 
>> wrote:
>> 
>>> Looks like this dependency is Jackcess (used for reading and
>> writing
 MS
>>> Access databases). I cannot find any discussion about adding this
>>> dependency on the dev-list. Why does Geode need to talk to MS
>> Access
>>> databases for Cluster Configuration?
>>> 
>>> It does have an Apache 2.0 license, but I think there are two
>>> problems
> with
>>> adding Jackcess: 1) all new dependencies should be discussed on
 dev-list
>>> BEFORE adding them to Geode, 2) we shouldn't need to talk to MS
>>> Access
> for
>>> Cluster Configuration.
>>> 
>>> On Tue, Jan 23, 2018 at 9:30 AM, Kirk Lund 
>>> wrote:
>>> 
 I just tried to compile Geode develop.
>> ClusterConfigurationService
 has
>>> two
 broken imports that don't exist:
 
 import com.healthmarketscience.rmiio.RemoteInputStream;
 import com.healthmarketscience.rmiio.RemoteInputStreamClient;
 
 Was there a new dependency added to Geode?
 
>>> 
> 
> 
 
>>> 
>> 

Re: build is broken

[Mark Bretl]

I agree with Kirk. A simple notice to the dev list to say what dependency
and why it is being added, this would also be an opportunity to make sure
the dependency is not using a Cat-X license [1].

--Mark

[1] https://www.apache.org/legal/resolved.html#category-x

On Tue, Jan 23, 2018 at 2:09 PM, Kirk Lund  wrote:

> Discussing the addition of new dependencies is something the community
> should be doing on the dev-list regardless of how many git repos we have.
> It's part of the Apache Way that we are beholden to as an Apache project.
>
> On Tue, Jan 23, 2018 at 11:25 AM, Udo Kohlmeyer 
> wrote:
>
> > This really just another reason that we should be pushing for the
> > separation of Geode into different (independent) modules with potentially
> > separate repos.
> > This way modules can advance and iterate faster without having to be
> > influenced by external factors causing unrelated failures.
> >
> > I would push for this, rather than having to slow the whole development
> > process down, whilst waiting for consensus on libraries used for external
> > tooling.
> >
> > --Udo
> >
> > On Tue, Jan 23, 2018 at 11:15 AM, Kirk Lund  wrote:
> >
> > > I have it working now. My IntelliJ project was using JDK1.8.0_66 for
> > Gradle
> > > which prevented updating of dependencies which then caused compilation
> in
> > > IntelliJ to fail on that new dependency.
> > >
> > > This doesn't resolve my main issue here which is this: *all new
> > > dependencies should be discussed on the dev list before introducing
> them
> > in
> > > a commit*. Can you please point me at an email that proposes adding
> this
> > > dependency?
> > >
> > > On Tue, Jan 23, 2018 at 10:10 AM, Anthony Baker 
> > wrote:
> > >
> > > > I just ran `gradle clean build` from HEAD and did not get any errors.
> > > >
> > > > > On Jan 23, 2018, at 10:08 AM, Jens Deppe 
> wrote:
> > > > >
> > > > > The dependency is the rmi-io library. It provides functionality for
> > > > > streaming data over RMI.
> > > > >
> > > > > It was added a few weeks ago, so I'm not sure why your build is
> > > breaking
> > > > > now.
> > > > >
> > > > > --Jens
> > > > >
> > > > > On Tue, Jan 23, 2018 at 9:41 AM, Kirk Lund 
> wrote:
> > > > >
> > > > >> Looks like this dependency is Jackcess (used for reading and
> writing
> > > MS
> > > > >> Access databases). I cannot find any discussion about adding this
> > > > >> dependency on the dev-list. Why does Geode need to talk to MS
> Access
> > > > >> databases for Cluster Configuration?
> > > > >>
> > > > >> It does have an Apache 2.0 license, but I think there are two
> > problems
> > > > with
> > > > >> adding Jackcess: 1) all new dependencies should be discussed on
> > > dev-list
> > > > >> BEFORE adding them to Geode, 2) we shouldn't need to talk to MS
> > Access
> > > > for
> > > > >> Cluster Configuration.
> > > > >>
> > > > >> On Tue, Jan 23, 2018 at 9:30 AM, Kirk Lund 
> > wrote:
> > > > >>
> > > > >>> I just tried to compile Geode develop.
> ClusterConfigurationService
> > > has
> > > > >> two
> > > > >>> broken imports that don't exist:
> > > > >>>
> > > > >>> import com.healthmarketscience.rmiio.RemoteInputStream;
> > > > >>> import com.healthmarketscience.rmiio.RemoteInputStreamClient;
> > > > >>>
> > > > >>> Was there a new dependency added to Geode?
> > > > >>>
> > > > >>
> > > >
> > > >
> > >
> >
>

Re: build is broken

[Udo Kohlmeyer]

This really just another reason that we should be pushing for the
separation of Geode into different (independent) modules with potentially
separate repos.
This way modules can advance and iterate faster without having to be
influenced by external factors causing unrelated failures.

I would push for this, rather than having to slow the whole development
process down, whilst waiting for consensus on libraries used for external
tooling.

--Udo

On Tue, Jan 23, 2018 at 11:15 AM, Kirk Lund  wrote:

> I have it working now. My IntelliJ project was using JDK1.8.0_66 for Gradle
> which prevented updating of dependencies which then caused compilation in
> IntelliJ to fail on that new dependency.
>
> This doesn't resolve my main issue here which is this: *all new
> dependencies should be discussed on the dev list before introducing them in
> a commit*. Can you please point me at an email that proposes adding this
> dependency?
>
> On Tue, Jan 23, 2018 at 10:10 AM, Anthony Baker  wrote:
>
> > I just ran `gradle clean build` from HEAD and did not get any errors.
> >
> > > On Jan 23, 2018, at 10:08 AM, Jens Deppe  wrote:
> > >
> > > The dependency is the rmi-io library. It provides functionality for
> > > streaming data over RMI.
> > >
> > > It was added a few weeks ago, so I'm not sure why your build is
> breaking
> > > now.
> > >
> > > --Jens
> > >
> > > On Tue, Jan 23, 2018 at 9:41 AM, Kirk Lund  wrote:
> > >
> > >> Looks like this dependency is Jackcess (used for reading and writing
> MS
> > >> Access databases). I cannot find any discussion about adding this
> > >> dependency on the dev-list. Why does Geode need to talk to MS Access
> > >> databases for Cluster Configuration?
> > >>
> > >> It does have an Apache 2.0 license, but I think there are two problems
> > with
> > >> adding Jackcess: 1) all new dependencies should be discussed on
> dev-list
> > >> BEFORE adding them to Geode, 2) we shouldn't need to talk to MS Access
> > for
> > >> Cluster Configuration.
> > >>
> > >> On Tue, Jan 23, 2018 at 9:30 AM, Kirk Lund  wrote:
> > >>
> > >>> I just tried to compile Geode develop. ClusterConfigurationService
> has
> > >> two
> > >>> broken imports that don't exist:
> > >>>
> > >>> import com.healthmarketscience.rmiio.RemoteInputStream;
> > >>> import com.healthmarketscience.rmiio.RemoteInputStreamClient;
> > >>>
> > >>> Was there a new dependency added to Geode?
> > >>>
> > >>
> >
> >
>

Re: build is broken

[Kirk Lund]

I have it working now. My IntelliJ project was using JDK1.8.0_66 for Gradle
which prevented updating of dependencies which then caused compilation in
IntelliJ to fail on that new dependency.

This doesn't resolve my main issue here which is this: *all new
dependencies should be discussed on the dev list before introducing them in
a commit*. Can you please point me at an email that proposes adding this
dependency?

On Tue, Jan 23, 2018 at 10:10 AM, Anthony Baker  wrote:

> I just ran `gradle clean build` from HEAD and did not get any errors.
>
> > On Jan 23, 2018, at 10:08 AM, Jens Deppe  wrote:
> >
> > The dependency is the rmi-io library. It provides functionality for
> > streaming data over RMI.
> >
> > It was added a few weeks ago, so I'm not sure why your build is breaking
> > now.
> >
> > --Jens
> >
> > On Tue, Jan 23, 2018 at 9:41 AM, Kirk Lund  wrote:
> >
> >> Looks like this dependency is Jackcess (used for reading and writing MS
> >> Access databases). I cannot find any discussion about adding this
> >> dependency on the dev-list. Why does Geode need to talk to MS Access
> >> databases for Cluster Configuration?
> >>
> >> It does have an Apache 2.0 license, but I think there are two problems
> with
> >> adding Jackcess: 1) all new dependencies should be discussed on dev-list
> >> BEFORE adding them to Geode, 2) we shouldn't need to talk to MS Access
> for
> >> Cluster Configuration.
> >>
> >> On Tue, Jan 23, 2018 at 9:30 AM, Kirk Lund  wrote:
> >>
> >>> I just tried to compile Geode develop. ClusterConfigurationService has
> >> two
> >>> broken imports that don't exist:
> >>>
> >>> import com.healthmarketscience.rmiio.RemoteInputStream;
> >>> import com.healthmarketscience.rmiio.RemoteInputStreamClient;
> >>>
> >>> Was there a new dependency added to Geode?
> >>>
> >>
>
>

Re: build is broken

[Anthony Baker]

I just ran `gradle clean build` from HEAD and did not get any errors.

> On Jan 23, 2018, at 10:08 AM, Jens Deppe  wrote:
> 
> The dependency is the rmi-io library. It provides functionality for
> streaming data over RMI.
> 
> It was added a few weeks ago, so I'm not sure why your build is breaking
> now.
> 
> --Jens
> 
> On Tue, Jan 23, 2018 at 9:41 AM, Kirk Lund  wrote:
> 
>> Looks like this dependency is Jackcess (used for reading and writing MS
>> Access databases). I cannot find any discussion about adding this
>> dependency on the dev-list. Why does Geode need to talk to MS Access
>> databases for Cluster Configuration?
>> 
>> It does have an Apache 2.0 license, but I think there are two problems with
>> adding Jackcess: 1) all new dependencies should be discussed on dev-list
>> BEFORE adding them to Geode, 2) we shouldn't need to talk to MS Access for
>> Cluster Configuration.
>> 
>> On Tue, Jan 23, 2018 at 9:30 AM, Kirk Lund  wrote:
>> 
>>> I just tried to compile Geode develop. ClusterConfigurationService has
>> two
>>> broken imports that don't exist:
>>> 
>>> import com.healthmarketscience.rmiio.RemoteInputStream;
>>> import com.healthmarketscience.rmiio.RemoteInputStreamClient;
>>> 
>>> Was there a new dependency added to Geode?
>>> 
>> 

Re: build is broken

[Jens Deppe]

The dependency is the rmi-io library. It provides functionality for
streaming data over RMI.

It was added a few weeks ago, so I'm not sure why your build is breaking
now.

--Jens

On Tue, Jan 23, 2018 at 9:41 AM, Kirk Lund  wrote:

> Looks like this dependency is Jackcess (used for reading and writing MS
> Access databases). I cannot find any discussion about adding this
> dependency on the dev-list. Why does Geode need to talk to MS Access
> databases for Cluster Configuration?
>
> It does have an Apache 2.0 license, but I think there are two problems with
> adding Jackcess: 1) all new dependencies should be discussed on dev-list
> BEFORE adding them to Geode, 2) we shouldn't need to talk to MS Access for
> Cluster Configuration.
>
> On Tue, Jan 23, 2018 at 9:30 AM, Kirk Lund  wrote:
>
> > I just tried to compile Geode develop. ClusterConfigurationService has
> two
> > broken imports that don't exist:
> >
> > import com.healthmarketscience.rmiio.RemoteInputStream;
> > import com.healthmarketscience.rmiio.RemoteInputStreamClient;
> >
> > Was there a new dependency added to Geode?
> >
>

Re: build is broken

[Kirk Lund]

Looks like this dependency is Jackcess (used for reading and writing MS
Access databases). I cannot find any discussion about adding this
dependency on the dev-list. Why does Geode need to talk to MS Access
databases for Cluster Configuration?

It does have an Apache 2.0 license, but I think there are two problems with
adding Jackcess: 1) all new dependencies should be discussed on dev-list
BEFORE adding them to Geode, 2) we shouldn't need to talk to MS Access for
Cluster Configuration.

On Tue, Jan 23, 2018 at 9:30 AM, Kirk Lund  wrote:

> I just tried to compile Geode develop. ClusterConfigurationService has two
> broken imports that don't exist:
>
> import com.healthmarketscience.rmiio.RemoteInputStream;
> import com.healthmarketscience.rmiio.RemoteInputStreamClient;
>
> Was there a new dependency added to Geode?
>

build is broken

[Kirk Lund]

I just tried to compile Geode develop. ClusterConfigurationService has two
broken imports that don't exist:

import com.healthmarketscience.rmiio.RemoteInputStream;
import com.healthmarketscience.rmiio.RemoteInputStreamClient;

Was there a new dependency added to Geode?

Re: Geode build is broken

[Jared Stewart]

My mistake, I will fix this.

- Jared
> On Apr 17, 2017, at 8:49 AM, Bruce Schuchardt  wrote:
> 
> The "rat" task is failing
> Unapproved licenses:
> 
>   
> C:/devel/gfdev/open/geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest_FunctionATemplate
>   
> C:/devel/gfdev/open/geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest_FunctionBTemplate
> These were added late last week in this commit:
> commit 6f7f943998153de1f00b1446eb80fa6d304ac40f
> Author: Jared Stewart  
> Date:   Wed Apr 12 10:53:13 2017 -0700
> 
> GEODE-2290: Limit scanning of deployed jars
> 
>  - Uses fast-classpath-scanner to scan jars for classes containing 
> Functions without eagerly loading all classes in the jar.
> 

Geode build is broken

[Bruce Schuchardt]

The "rat" task is failing

   Unapproved licenses:

   
C:/devel/gfdev/open/geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest_FunctionATemplate
   
C:/devel/gfdev/open/geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest_FunctionBTemplate

These were added late last week in this commit:

   commit 6f7f943998153de1f00b1446eb80fa6d304ac40f
   Author: Jared Stewart 
   Date:   Wed Apr 12 10:53:13 2017 -0700

GEODE-2290: Limit scanning of deployed jars

 - Uses fast-classpath-scanner to scan jars for classes
   containing Functions without eagerly loading all classes in the jar.