Re: Proposal to allow eviction and expiration operations/events with AsyncEventQueue.

2016-06-03 Thread William Markito
+1 On Fri, Jun 3, 2016 at 3:32 PM, Dan Smith wrote: > +1 for splitting it up and getting rid of the Eviction option for now. > > I think I was the one who suggested setIgnoreExpiration originally. > Ignore/Forward, I guess it's not really a big deal. But since you are >

Re: Review Request 48188: GEODE-1495: Changes are made to remove the cached destroyed token/events from the CQ.

2016-06-03 Thread anilkumar gingade
> On June 3, 2016, 10:10 p.m., Dan Smith wrote: > > I think there should be a test with these changes. Dan, I am adding that...Wanted to get early feedback on this and get tests started... I will add the test changes to this review post. - anilkumar

Re: Review Request 48188: GEODE-1495: Changes are made to remove the cached destroyed token/events from the CQ.

2016-06-03 Thread anilkumar gingade
> On June 3, 2016, 10:05 p.m., Bruce Schuchardt wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java, > > line 696 > > > > > > You're missing braces on all of your

Re: Review Request 48239: GEODE-1498 CI Failure: DurableClientCommandsDUnitTest.testCloseDurableClients

2016-06-03 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48239/#review136142 --- Ship it! Ship It! - Hitesh Khamesra On June 3, 2016, 11:42

Review Request 48239: GEODE-1498 CI Failure: DurableClientCommandsDUnitTest.testCloseDurableClients

2016-06-03 Thread Jianxia Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48239/ --- Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #329 was SUCCESSFUL (with 1398 tests)

2016-06-03 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #329 was successful. --- Scheduled 1400 tests in total. https://build.spring.io/browse/SGF-NAG-329/ -- This

Re: Review Request 48188: GEODE-1495: Changes are made to remove the cached destroyed token/events from the CQ.

2016-06-03 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48188/#review136116 --- I think there should be a test with these changes. - Dan Smith

Re: Review Request 48188: GEODE-1495: Changes are made to remove the cached destroyed token/events from the CQ.

2016-06-03 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48188/#review136115 --- Fix it, then Ship it! Fix it, then Ship it!

[GitHub] incubator-geode pull request #149: GEODE-1331: gfsh.bat on Windows is incorr...

2016-06-03 Thread kjduling
Github user kjduling commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/149#discussion_r65782155 --- Diff: geode-assembly/src/main/dist/bin/gfsh.bat --- @@ -74,14 +70,14 @@ REM ) REM Consider java is from JDK @set

Framework for testing example shell scripts

2016-06-03 Thread William Markito
Guys, What do you think about using something like Bats [1] to test shell scripts that will be available as part of the examples ? Not sure if we would have any conflicts or problems with their license [2] but it doesn't seem the case... Thanks [1] https://github.com/sstephenson/bats [2]

[GitHub] incubator-geode pull request #150: Feature/geode 308

2016-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/150 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Proposal to allow eviction and expiration operations/events with AsyncEventQueue.

2016-06-03 Thread Anilkumar Gingade
Yes...Jason, thanks for correction... [corrected] I will wait for other feedbacks/comments, if there is no objection i will change it to "forwardExpirationDestroy" with default value set to false. -Anil. On Fri, Jun 3, 2016 at 12:01 PM, Jason Huynh wrote: > *I will wait

Re: Proposal to allow eviction and expiration operations/events with AsyncEventQueue.

2016-06-03 Thread Jason Huynh
*I will wait for other feedbacks/comments, if there is no objection i willchange it to "forwardExpirationDestroy" with default value set to true.* think you meant to say default value to set false :-) On Fri, Jun 3, 2016 at 11:47 AM, Anilkumar Gingade wrote: > Thanks

Re: Proposal to allow eviction and expiration operations/events with AsyncEventQueue.

2016-06-03 Thread Anilkumar Gingade
Thanks Darrel... The name change was based on the review comments: https://reviews.apache.org/r/46243/ I am fine with either one, ignoreXXX or forwardXXX. I will wait for other feedbacks/comments, if there is no objection i will change it to "forwardExpirationDestroy" with default value set to

Re: Review Request 48187: GEODE-1491 A rollback command could fail with IllegalStateException if the client failed over and the transaction has been rolled back

2016-06-03 Thread Eric Shu
> On June 2, 2016, 10:58 p.m., Darrel Schneider wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java, > > line 1024 > > > > > > failoverMap is synchronized but this code does

Re: c++ native client

2016-06-03 Thread Jacob Barrett
The native client in geode will likely be v1 to match the Java bits, or whatever geode version is when nc is ready to release with geode. On Fri, Jun 3, 2016 at 7:18 AM Dor Ben Dov wrote: > Hi, > > Anyone can tell me what is the version of the native client (c++) ? > >

c++ native client

2016-06-03 Thread Dor Ben Dov
Hi, Anyone can tell me what is the version of the native client (c++) ? Dor This message and the information contained herein is proprietary and confidential and subject to the Amdocs policy statement, you may review at http://www.amdocs.com/email_disclaimer.asp

Build failed in Jenkins: Geode-nightly #488

2016-06-03 Thread Apache Jenkins Server
See Changes: [jdeppe] GEODE-1185: typo in gfsh help on alter disk-store [jdeppe] GEODE-1463: Legacy OperationContexts do not set the appropriate Shiro [huynhja] GEODE-1377: Changed property for spark tests to use new [jdeppe]