Re: M3 vs. M2 dependencies

2016-08-22 Thread Anthony Baker
I think the findbugs-annotations dependency can be optional—we don’t need to ship this jar with the binary distribution. Anthony > On Aug 22, 2016, at 5:38 PM, Dan Smith wrote: > > I was comparing our required dependencies of geode-core for the M3 vs. M2 > release (Anything

M3 vs. M2 dependencies

2016-08-22 Thread Dan Smith
I was comparing our required dependencies of geode-core for the M3 vs. M2 release (Anything with compile or runtime scope in the pom and not marked optional). It looks like they are pretty similar, with the below differences. Removed in M3: geode-joptsimple Added in M3: shiro-core

Re: Review Request 51308: GEODE-1811: Marking runtime dependencies as optional in the pom

2016-08-22 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51308/#review146460 --- Ship it! Ship It! - Anthony Baker On Aug. 23, 2016, 12:13

Review Request 51308: GEODE-1811: Marking runtime dependencies as optional in the pom

2016-08-22 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51308/ --- Review request for geode, Anthony Baker and Mark Bretl. Repository: geode

Re: Review Request 51305: GEODE-1810: WAN locator exchange doesn't include hostname-for-clients if it is set

2016-08-22 Thread Barry Oglesby
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51305/#review146458 --- Ship it! Ship It! - Barry Oglesby On Aug. 22, 2016, 10:42

Re: Review Request 51302: GEODE-1768: CI failure: ResourceManagerDUnitTest.testRemoveDuringKeySet

2016-08-22 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51302/#review146456 --- Ship it! Ship It! - Eric Shu On Aug. 22, 2016, 9:11 p.m.,

Re: Review Request 51227: GEODE-420: Locator SSL

2016-08-22 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51227/ --- (Updated Aug. 22, 2016, 5:43 p.m.) Review request for geode, Bruce Schuchardt

Re: Review Request 49962: Removed extra fields from distributedmember while serialization/de

2016-08-22 Thread Hitesh Khamesra
> On Aug. 22, 2016, 3:29 p.m., Bruce Schuchardt wrote: > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java, > > line 895 > > > > > > I don't think