Re: Review Request 53360: GEODE-2050 Remove doc of statistics no longer present

2016-11-01 Thread Joey McAllister
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53360/#review154484 --- Ship it! Ship It! - Joey McAllister On Nov. 1, 2016, 11:55

Re: Review Request 53360: GEODE-2050 Remove doc of statistics no longer present

2016-11-01 Thread Karen Miller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53360/ --- (Updated Nov. 1, 2016, 11:55 p.m.) Review request for geode, Bruce Schuchardt,

Re: Review Request 53360: GEODE-2050 Remove doc of statistics no longer present

2016-11-01 Thread Karen Miller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53360/ --- (Updated Nov. 1, 2016, 11:51 p.m.) Review request for geode, Bruce Schuchardt,

Review Request 53360: GEODE-2050 Remove doc of statistics no longer present

2016-11-01 Thread Karen Miller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53360/ --- Review request for geode, Bruce Schuchardt, Dave Barnes, and Joey McAllister.

Review Request 53355: fix deadlock caused by how the GemFireCacheImpl class synchronization is done

2016-11-01 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53355/ --- Review request for geode, anilkumar gingade and Scott Jewell. Bugs: GEODE-1971

Re: Backwards compatibility for 1.1

2016-11-01 Thread Jianxia Chen
+1 On Tue, Nov 1, 2016 at 4:00 PM, Dan Smith wrote: > Hi, > > We made a lot of changes in 1.0 that broke compatibility with old versions > of gemfire for various reasons (package renaming, changing membership > system). I just wanted to confirm that starting with 1.1, we're

Re: Backwards compatibility for 1.1

2016-11-01 Thread Darrel Schneider
yes +1 On Tue, Nov 1, 2016 at 4:00 PM, Dan Smith wrote: > Hi, > > We made a lot of changes in 1.0 that broke compatibility with old versions > of gemfire for various reasons (package renaming, changing membership > system). I just wanted to confirm that starting with 1.1,

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-01 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86040503 --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java --- @@ -1091,6

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-01 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86041266 --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java --- @@ -1091,6

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-01 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86039620 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/RegionCreateFunction.java --- @@ -405,9 +408,48 @@ private

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-01 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86039193 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java --- @@ -907,6 +903,31

[GitHub] incubator-geode pull request #:

2016-11-01 Thread upthewaterspout
Github user upthewaterspout commented on the pull request: https://github.com/apache/incubator-geode/commit/c1216eb1817df3c6b20afbaff49ba30e76d34b44#commitcomment-1965 @vectorijk Shoot, I just updated the version to 1.0.0-incubating (no SNAPSHOT) to get the build to pass before I

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-01 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86038578 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java --- @@ -907,6 +903,31

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-01 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86033727 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java --- @@ -907,6 +903,31

[GitHub] incubator-geode issue #278: Feature/geode 1896 unable to specify a Partition...

2016-11-01 Thread upthewaterspout
Github user upthewaterspout commented on the issue: https://github.com/apache/incubator-geode/pull/278 +1 Looks good to me after addressing Kirk's comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-01 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86033253 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java --- @@ -907,6 +903,31

Re: Review Request 53335: GEODE-2028: Fix license issues from 1.0.0-incubating release

2016-11-01 Thread Mark Bretl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53335/#review154466 --- Ship it! Ship It! - Mark Bretl On Oct. 31, 2016, 8:03 p.m.,

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-01 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86031904 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java --- @@ -31,19 +31,13 @@

Re: Review Request 53345: Adding new PDX , order by and Index Query tests to the open side

2016-11-01 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53345/#review154457 --- Fix it, then Ship it!

Re: Review Request 53345: Adding new PDX , order by and Index Query tests to the open side

2016-11-01 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53345/#review154429 ---

Review Request 53345: Adding new PDX , order by and Index Query tests to the open side

2016-11-01 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53345/ --- Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, Dan

Re: Review Request 53108: GEODE-2012: always write stat types to archive

2016-11-01 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53108/#review154425 --- Ship it! Ship It! - Darrel Schneider On Oct. 31, 2016, 4:54

Re: Review Request 53331: GEODE-2047 Document change to enable-network-partition-detection

2016-11-01 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53331/#review154423 --- Ship it! Ship It! - Bruce Schuchardt On Nov. 1, 2016, 4:02

Re: [DISCUSS] Graduation

2016-11-01 Thread Xiaojian Zhou
+1 On Mon, Oct 31, 2016 at 4:12 PM, Jianxia Chen wrote: > +1 > > On Mon, Oct 31, 2016 at 2:47 PM, Anilkumar Gingade > wrote: > > > +1 > > > > On Fri, Oct 28, 2016 at 10:23 PM, Avinash Dongre > > wrote: > > > > > +1 > > > > > > On Sat,

Re: Review Request 53274: GEODE-1955: fix flaky tests by properly closing the gfsh instance in ConnectToLocatorSSLDUnitTest

2016-11-01 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53274/ --- (Updated Nov. 1, 2016, 5:19 p.m.) Review request for geode, Kevin Duling and

Re: Review Request 53274: GEODE-1955: fix flaky tests by properly closing the gfsh instance in ConnectToLocatorSSLDUnitTest

2016-11-01 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53274/ --- (Updated Nov. 1, 2016, 5:18 p.m.) Review request for geode, Kevin Duling and

Re: Review Request 53331: GEODE-2047 Document change to enable-network-partition-detection

2016-11-01 Thread Dave Barnes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53331/#review154415 --- Ship it! Ship It! - Dave Barnes On Nov. 1, 2016, 4:02 p.m.,

Re: Review Request 53331: GEODE-2047 Document change to enable-network-partition-detection

2016-11-01 Thread Karen Miller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53331/ --- (Updated Nov. 1, 2016, 4:02 p.m.) Review request for geode, Bruce Schuchardt,

Build failed in Jenkins: Geode-spark-connector #101

2016-11-01 Thread Apache Jenkins Server
See Changes: [sbawaskar] Adding my PGP key to KEYS [jiliao] GEODE-2014: Upgrade Swagger libraries [jiliao] GEODE-2025: do not use 8080 as the default http-server-port since we [jiliao] GEODE-2014: add the missing license header

Jenkins build is back to normal : Geode-nightly #640

2016-11-01 Thread Apache Jenkins Server
See