[GitHub] incubator-geode issue #278: Feature/geode 1896 unable to specify a Partition...

Github user upthewaterspout commented on the issue: https://github.com/apache/incubator-geode/pull/278 +1 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

Re: Review Request 53587: GEODE-2014: explicitly declare spring-web as a direct dependency rather than a transitive one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53587/#review155379 --- Ship it! Ship It! - Kevin Duling On Nov. 8, 2016, 2:31

Review Request 53587: GEODE-2014: explicitly declare spring-web as a direct dependency rather than a transitive one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53587/ --- Review request for geode, Anthony Baker, Kevin Duling, and Kirk Lund.

Re: Review Request 53566: GEODE-2078: Fix manifest classpath

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53566/#review155358 --- Ship it! Ship It! - Mark Bretl On Nov. 7, 2016, 8:23 p.m.,

Re: Review Request 53566: GEODE-2078: Fix manifest classpath

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53566/#review155360 --- Ship it! Ship It! - Dan Smith On Nov. 8, 2016, 4:23 a.m.,

Re: Review Request 53581: GEODE-2070 Improve documentation of region management

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53581/#review155353 --- Ship it! Ship It! - Joey McAllister On Nov. 8, 2016, 6:53

Re: Review Request 53579: GEODE-1570: add a test to verify rest security with SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53579/ --- (Updated Nov. 8, 2016, 8:53 p.m.) Review request for geode, Kevin Duling and

Re: Review Request 53581: GEODE-2070 Improve documentation of region management

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53581/#review155329 --- Ship it! Ship It! - Dave Barnes On Nov. 8, 2016, 6:53 p.m.,

Review Request 53581: GEODE-2070 Improve documentation of region management

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53581/ --- Review request for geode, Dave Barnes and Joey McAllister. Repository: geode

Re: Review Request 53577: Remove illegal javadoc tag that generates warning

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53577/#review155328 --- Ship it! Ship It! - Jinmei Liao On Nov. 8, 2016, 5:54 p.m.,

Re: Review Request 53553: GEODE-2082: fix flakiness in sameKeepsOneFile

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53553/#review155327 --- Ship it! Ship It! - Kevin Duling On Nov. 7, 2016, 11:25

Re: Review Request 53579: GEODE-1570: add a test to verify rest security with SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53579/#review155326 --- Ship it! Ship It! - Kevin Duling On Nov. 8, 2016, 10:13

[GitHub] incubator-geode issue #280: GEODE-1740: Potential region inconsistency with ...

Github user gemzdude commented on the issue: https://github.com/apache/incubator-geode/pull/280 Closed as incomplete --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-geode pull request #280: GEODE-1740: Potential region inconsistenc...

Github user gemzdude closed the pull request at: https://github.com/apache/incubator-geode/pull/280 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Review Request 53577: Remove illegal javadoc tag that generates warning

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53577/#review155325 --- Ship it! Ship It! - Kevin Duling On Nov. 8, 2016, 9:54

Re: Review Request 53579: GEODE-1570: add a test to verify rest security with SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53579/ --- (Updated Nov. 8, 2016, 6:13 p.m.) Review request for geode, Kevin Duling and

Review Request 53579: GEODE-1570: add a test to verify rest security with SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53579/ --- Review request for geode. Repository: geode Description --- GEODE-1570:

Review Request 53577: Remove illegal javadoc tag that generates warning

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53577/ --- Review request for geode, Jinmei Liao and Kevin Duling. Repository: geode

[GitHub] incubator-geode issue #276: GEODE-1993: postprocess region/key

Github user kjduling commented on the issue: https://github.com/apache/incubator-geode/pull/276 1. I am using Autowire, the annotation is on the base class's constructor. But as for the injection via the constructor, please review

Re: Review Request 53557: GEODE-2080 Rest POST put call not working with region valueConstrain

> On Nov. 8, 2016, 1:44 a.m., Darrel Schneider wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java, > > line 3323 > > > > > > Is ".equals" too specific? You want something like

Re: Review Request 53557: GEODE-2080 Rest POST put call not working with region valueConstrain

> On Nov. 8, 2016, 1:44 a.m., Darrel Schneider wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java, > > line 3315 > > > > > > If pdx.getClassName() is not equals to JSON_CLASSNAME

Re: Build failed in Jenkins: Geode-nightly #647

spotlessApply added to DiskSpaceLimitIntegrationTest.java and pushed to develop. - local build was successful with no error. On Tue, Nov 8, 2016 at 8:06 AM Nabarun Nag wrote: > Fixing it. > On Tue, Nov 8, 2016 at 7:48 AM Apache Jenkins Server < > jenk...@builds.apache.org>

Build failed in Jenkins: Geode-nightly #647

See Changes: [upthewaterspout] Adding a geode-benchmark project with support for running jmh benchmarks [upthewaterspout] GEODE-1985 Removing some string comparisons in the AttributesDescriptor [upthewaterspout] GEODE-1985: Updating

RE: classpath in geode release

Gr8, now all is clear :) Thanks! Gal -Original Message- From: Anthony Baker [mailto:aba...@pivotal.io] Sent: Tuesday, November 08, 2016 16:17 To: dev@geode.incubator.apache.org Subject: Re: classpath in geode release > On Nov 8, 2016, at 1:09 AM, Gal Palmery

Re: classpath in geode release

> On Nov 8, 2016, at 1:09 AM, Gal Palmery wrote: > > Actually I do see them in the lib dir, after running the build, inside the > zip in the distributions: > > geode-assembly\build\distributions\apache-geode-1.0.0-incubating.zip\apache-geode-1.0.0-incubating\lib

RE: classpath in geode release

Actually I do see them in the lib dir, after running the build, inside the zip in the distributions: geode-assembly\build\distributions\apache-geode-1.0.0-incubating.zip\apache-geode-1.0.0-incubating\lib also, when comparing to the Gemfire distribution (that we use in our product in